RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 893904 - xfs_repair segfaults when using ag_stride option.
Summary: xfs_repair segfaults when using ag_stride option.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: xfsprogs
Version: 6.3
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Eric Sandeen
QA Contact: Boris Ranto
URL:
Whiteboard:
Depends On:
Blocks: 1020438
TreeView+ depends on / blocked
 
Reported: 2013-01-10 07:49 UTC by Steven Haigh
Modified: 2018-12-04 14:56 UTC (History)
6 users (show)

Fixed In Version: xfsprogs-3.1.1-11.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1020438 (view as bug list)
Environment:
Last Closed: 2013-11-21 21:19:21 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2013:1657 0 normal SHIPPED_LIVE xfsprogs bug fix update 2013-11-20 21:53:13 UTC

Description Steven Haigh 2013-01-10 07:49:35 UTC 
Description of problem:
When running xfs_repair with the ag_stride option to attempt to speed up the repair, part way through Phase 2, we receive a segfault.

Version-Release number of selected component (if applicable):
[root@zeus ~]# rpm -qa | grep xfs
xfsprogs-3.1.1-7.el6.x86_64
[root@zeus ~]#

Steps to Reproduce:
[root@zeus ~]# xfs_repair -o bhash=16384 -o ihash=16384 -o ag_stride=16 -t 60 /dev/xvdb
Phase 1 - find and verify superblock...
        - reporting progress in intervals of 1 minute
Phase 2 - using internal log
        - zero log...
XFS: totally zeroed log
Segmentation fault
[root@zeus ~]#

Additional info:
The latest version of xfsprogs (3.1.8) are known to fix this problem.

See:
http://comments.gmane.org/gmane.comp.file-systems.xfs.general/43191
http://blog.jcuff.net/2012/04/turn-xfsrepair-up-to-eleven-with.html

Updating xfsprogs would probably fix a whole lot of issues, as well as increase performance of actual repairs.
Comment 2 Eric Sandeen 2013-01-10 15:33:50 UTC 
commit 356357a446424c54851608bb7cebce6cead14590
Author: Christoph Hellwig <hch>
Date:   Fri Mar 2 08:35:08 2012 +0000

    repair: fix incorrect use of thread local data in dir and attr code
    
    The attribute and dirv1 code use pthread thread local data incorrectly in
    a few places, which will make them fail in horrible ways when using the
    ag_stride options.
    
    Replace the use of thread local data with simple local allocations given
    that there is no needed to micro-optimize these allocations as much
    as e.g. the extent map.  The added benefit is that we have to allocate
    less memory, and can free it quickly.
    
    Reviewed-by: Dave Chinner <dchinner>
    Reported-by: Tom Crane <T.Crane.uk>
    Tested-by: Tom Crane <T.Crane.uk>
    Signed-off-by: Christoph Hellwig <hch>
Comment 3 RHEL Program Management 2013-01-14 06:48:22 UTC 
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.
Comment 21 errata-xmlrpc 2013-11-21 21:19:21 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1657.html
Note You need to log in before you can comment on or make changes to this bug.