Bug 893923 - Evolution not able to show attachment in 3.6.2
Summary: Evolution not able to show attachment in 3.6.2
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: evolution
Version: 18
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Matthew Barnes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 894003 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-10 09:17 UTC by Samarjit Adhikari
Modified: 2013-01-17 19:04 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-14 18:58:20 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Example Exchange screenshot with all messages showing 0 bytes as their size (169.57 KB, image/png)
2013-01-13 13:08 UTC, BartS
no flags Details
Sample message with invisible attachment screenshot (170.73 KB, image/png)
2013-01-13 13:09 UTC, BartS
no flags Details
sample message with visible attachment (in OWA). (218.71 KB, image/png)
2013-01-13 13:10 UTC, BartS
no flags Details
The sample message saved in .mbox format (attachment is clearly present). (362.40 KB, application/mbox)
2013-01-13 13:10 UTC, BartS
no flags Details
mbox format (115.33 KB, image/png)
2013-01-14 17:11 UTC, Samarjit Adhikari
no flags Details


Links
System ID Private Priority Status Summary Last Updated
GNOME Bugzilla 691732 0 None None None Never

Description Samarjit Adhikari 2013-01-10 09:17:49 UTC
Created attachment 676183 [details]
evolution -screenshot

Description of problem:
Simple open evolution and try to download any attachment file. it will not give button to download attachment.

Version-Release number of selected component (if applicable):
Fedora18-pre release
Evolution 3.6.2

How reproducible:
evolution-screenshot not showing attachment in mail message. Attachment cant be downloaded to hark disk. ThunderBird shows attachment and can be save to hard disk

Steps to Reproduce:
1. Given above
2.
3.
  
Actual results:
Attachment not there is detailed mail message and ca not be downloaded.

Expected results:


Additional info:

Comment 1 Samarjit Adhikari 2013-01-10 09:19:29 UTC
Created attachment 676184 [details]
Thunder bird attachment

Please make those attachment private as it contains sensitive data.

Comment 2 Milan Crha 2013-01-10 14:54:09 UTC
Thanks for a bug report. It seems to me, on the first look, that Thunderbird is showing a text/html part, while Evolution is using the text/plain part, and hides the inline attachment used by the html part.

Could you open Edit->Preferences->Mail Preferences->tab HTML Messages and at the bottom section Plain Text Mode? I guess you've there set either "Show plain text if present" or "Only ever show plain text", and the "Show suppressed HTML parts as attachments" is not checked, thus you cannot see the rest of the message. I would tell for sure with the message source, but from my point of view it's enough to check the attachment checkbox and you get to both HTML part and inside it to the inline image as well.

Comment 3 Milan Crha 2013-01-10 14:58:16 UTC
*** Bug 894003 has been marked as a duplicate of this bug. ***

Comment 4 Samarjit Adhikari 2013-01-11 05:09:43 UTC
Created attachment 676648 [details]
New attachment screenshots

Comment 5 Samarjit Adhikari 2013-01-11 05:21:31 UTC
(In reply to comment #3)
> *** Bug 894003 has been marked as a duplicate of this bug. ***

Thanks for looking into it. The setting in mail preference tab partially resolve the issue#894003. There are 2 different issues. (i have attached screenshots)

1) With desired mail preference setting some of the messages from "quixy.hp.com" showing correctly in html format not all.
Check the screenshots 
Screenshot from 2013-01-11 10:32:51.png
Screenshot from 2013-01-11 10:34:14.png


2) Mail Message from "grow.notifications" does not show the attached ".msg" file which is shown by thunderbird at bottom (Given in evolution -screenshot zip ) See the attached screen shot 
Screenshot from 2013-01-11 10:35:44.png

I have created another attachment #676648 [details]

Comment 6 Milan Crha 2013-01-11 07:25:45 UTC
ad 1) I hope the screenshots are both correct. I cannot tell without the messages.

ad 2) I found one issue with image attachments just today, which I fixed for 3.6.3+, though it's not used for message attachments. Could you right-click the message, save it as mbox, zip it, and send it to me (bugzilla email address), with bug link in Subject/Body, thus I'll be able to test it locally and possibly find out what is wrong, please? I promise I'll use the message for testing only, but feel free to edit the saved mbox file and remove from there any sensitive information. I'm interested in message structure only anyway.

Comment 7 Samarjit Adhikari 2013-01-13 10:21:25 UTC
(In reply to comment #6)
> ad 1) I hope the screenshots are both correct. I cannot tell without the
> messages.
> 
> ad 2) I found one issue with image attachments just today, which I fixed for
> 3.6.3+, though it's not used for message attachments. Could you right-click
> the message, save it as mbox, zip it, and send it to me (bugzilla email
> address), with bug link in Subject/Body, thus I'll be able to test it
> locally and possibly find out what is wrong, please? I promise I'll use the
> message for testing only, but feel free to edit the saved mbox file and
> remove from there any sensitive information. I'm interested in message
> structure only anyway.

After doing some investigation i found that evolution 3.6.2 is not able to show attachment for those messages where the Content-Type is "multipart/related"

If the Content-Type is "multipart/alternative". evolution is able to show attachment.

with regards,
Samarjit

Comment 8 Samarjit Adhikari 2013-01-13 12:40:40 UTC
(In reply to comment #7)

> If the Content-Type is "multipart/alternative". evolution is able to show
> attachment.
> 
> with regards,
> Samarjit

I found following in evolution-hacker mailing list regarding multipart/related message type.

https://lists.gnome.org/archives/commits-list/2012-June/msg02019.html

Comment 9 BartS 2013-01-13 13:07:40 UTC
I haven't dug that deeply but can confirm that attachments sent by colleagues (i.e. internal, Exchange 2010 mail) seem to get through, but external attachments dont.

A sample screenshot of the "all emails report their size as zero" issue along with a sample message (with invisible simple pdf attachment), and associated screen shots are below.

Comment 10 BartS 2013-01-13 13:08:36 UTC
Created attachment 677694 [details]
Example Exchange screenshot with all messages showing 0 bytes as their size

Comment 11 BartS 2013-01-13 13:09:22 UTC
Created attachment 677695 [details]
Sample message with invisible attachment screenshot

Comment 12 BartS 2013-01-13 13:10:01 UTC
Created attachment 677696 [details]
sample message with visible attachment (in OWA).

Comment 13 BartS 2013-01-13 13:10:49 UTC
Created attachment 677705 [details]
The sample message saved in .mbox format (attachment is clearly present).

Comment 14 Samarjit Adhikari 2013-01-14 06:51:40 UTC
(In reply to comment #13)
> Created attachment 677705 [details]
> The sample message saved in .mbox format (attachment is clearly present).

BartS, I checked the mbox format of your attachment #677705 [details] and found that the content-Type is "muitipart/related". Thus as discussed above, evolution is not able to show attachment. 

Now i am waiting to confirm my findings from some evolution dev guy. :-)

Comment 15 BartS 2013-01-14 07:55:31 UTC
Samarjit,

Do you also have the "all messages show size as 0 bytes" issue like I do?

Comment 16 Milan Crha 2013-01-14 12:28:47 UTC
Samarjit, thanks for the messages. The first one, which came first, doesn't have real attachments, I see there only images for the HTML part, and CSS styles for it. Your second message seems to be the same like the first, only its main Content-Type is changed to multipart/related and the text/html part is removed. The commit you found may cause hide of those parts.

The message size being zero, there was a similar bug in evolution-mapi too, which is fixed now, but EWS may have it too (they do not share code, each is completely independent). It'll be good to have it filled upstream:
https://bugzilla.gnome.org/enter_bug.cgi?product=evolution-ews
This has no influence on the attachments itself, only the summary size field is not properly filled.

Comment 17 Samarjit Adhikari 2013-01-14 16:47:16 UTC
(In reply to comment #16)
> Samarjit, thanks for the messages. The first one, which came first, doesn't
> have real attachments, I see there only images for the HTML part, and CSS
> styles for it. Your second message seems to be the same like the first, only
> its main Content-Type is changed to multipart/related and the text/html part
> is removed. The commit you found may cause hide of those parts.
> 
> The message size being zero, there was a similar bug in evolution-mapi too,
> which is fixed now, but EWS may have it too (they do not share code, each is
> completely independent). It'll be good to have it filled upstream:
> https://bugzilla.gnome.org/enter_bug.cgi?product=evolution-ews
> This has no influence on the attachments itself, only the summary size field
> is not properly filled.

Milan, Thanks for confirming this.
Yes you are correct. In issue! 1) the mail does not contain any real attachment, but one mail was perfectly showing in html format where as other did not. The message where content type is "multipart/related" did not show html mail correctly.

In issue #2) there was real attachment, but it was not shown in evolution. Here also the content-type is "multipart/related". I did not forward you that mail content.


@BartS, I am using evolution-mapi, thus may not face the issue of size 0

Comment 18 Samarjit Adhikari 2013-01-14 17:11:24 UTC
Created attachment 678301 [details]
mbox format

Comment 19 Samarjit Adhikari 2013-01-14 17:14:05 UTC
(In reply to comment #18)
> Created attachment 678301 [details]
> mbox format

Screen shot attached when i imported attachment #677705 [details]  into evolution. It also do not show attachment to download which is issue #2 in my previous communication.

Comment 20 Milan Crha 2013-01-14 18:58:20 UTC
Right, I see it the same. I've a patch for this, but I'd prefer to discuss it in upstream bugzilla, thus let's move there [1], please. I'll give you a test package of evolution with the patch applied too, to confirm it works before the next Monday's 3.6.2 release. Thanks in advance.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=691732

Comment 21 Milan Crha 2013-01-14 19:10:54 UTC
(In reply to comment #20)
> before the next Monday's 3.6.2 release. Thanks in advance.

Err, 3.6.3 is to be released on the Monday, January 21st.

Comment 22 Milan Crha 2013-01-14 19:20:45 UTC
A test build with the upstream patch included is currently building at [1]. I expect it being done within 30 minutes. If anything breaks, I'll update the bug. Thanks for your help with this.

Comment 23 Samarjit Adhikari 2013-01-15 05:36:06 UTC
(In reply to comment #22)
> A test build with the upstream patch included is currently building at [1].
> I expect it being done within 30 minutes. If anything breaks, I'll update
> the bug. Thanks for your help with this.

Will the code change also address the issue #1 in my earlier communication, i.e. not showing the html message/image if the content type is "multipart/related", even though the mail message doe not contain any real attachment. [comment #16]

Comment 24 Samarjit Adhikari 2013-01-15 05:37:20 UTC
(In reply to comment #22)
> A test build with the upstream patch included is currently building at [1].
> I expect it being done within 30 minutes. If anything breaks, I'll update
> the bug. Thanks for your help with this.

Will the code change also address the issue #1 in my earlier communication, i.e. not showing the html message/image if the content type is "multipart/related", even though the mail message doe not contain any real attachment. [comment #16]

Comment 25 Milan Crha 2013-01-15 09:36:39 UTC
I didn't see a content of the message from comment #0, thus I cannot tell for sure. Better if you install the test package and try it. Though I guess the issue is related to your bug #895381 and message reconstruction in evolution-mapi, rather than to multipart/related Content-Type.

Comment 26 Milan Crha 2013-01-16 18:42:21 UTC
(In reply to comment #22)
> A test build with the upstream patch included is currently building at [1].
> I expect it being done within 30 minutes. If anything breaks, I'll update
> the bug. Thanks for your help with this.

Err, I didn't paste the actual URL to download the package from :-/
I'm sorry for that. The link is:

[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=4868421

At the bottom, you can see green links for packages. Choose the architecture you use (32 or 64 bit), then the page it links to will open another set of links, with .rpm files. Pick those you have currently installed:
   $ rpm -qa | grep evolution | sort
and downloaded them to some folder. Then, as root run this:
   $ yum update /path/where/saved/evolution-*.rpm
which should update the evolution packages to version from the .rpm files you downloaded.

Comment 27 Samarjit Adhikari 2013-01-17 12:04:28 UTC
(In reply to comment #26)
> Err, I didn't paste the actual URL to download the package from :-/
> I'm sorry for that. The link is:
> 
> [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=4868421
> 
> At the bottom, you can see green links for packages. Choose the architecture
> you use (32 or 64 bit), then the page it links to will open another set of
> links, with .rpm files. Pick those you have currently installed:
>    $ rpm -qa | grep evolution | sort
> and downloaded them to some folder. Then, as root run this:
>    $ yum update /path/where/saved/evolution-*.rpm
> which should update the evolution packages to version from the .rpm files
> you downloaded.

Yes, attachments now i can see.

Comment 28 Milan Crha 2013-01-17 19:04:05 UTC
Thanks for the testing, I'm committing the upstream fix right now.


Note You need to log in before you can comment on or make changes to this bug.