Bug 894154 - Missing symlink for org.eclipse.emf.edit_*.jar
Summary: Missing symlink for org.eclipse.emf.edit_*.jar
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: eclipse-emf
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Krzysztof Daniel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-10 20:46 UTC by Gerard Ryan
Modified: 2014-01-13 00:27 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-08 02:00:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
git formatted patch for eclipse repo to add the symlink (2.08 KB, patch)
2013-01-18 14:14 UTC, Gerard Ryan
no flags Details | Diff

Description Gerard Ryan 2013-01-10 20:46:42 UTC
Description of problem:
Plugin jars for eclipse-emf-core are installed to /usr/share/java/emf/eclipse/plugins/. They are symlinked into %{_libdir}/eclipse.

The problem is that there are 5 jars, and only 4 are symlinked. The missing one is /usr/share/java/emf/eclipse/plugins/org.eclipse.emf.edit_*.jar. Other plugins that depend on this jar fail to build. This happens with plugins that use pdebuild at least, not sure about tycho. See eclipse-wtp-common (also anything that requires eclipse-wtp-common, except in places where I added a shameful workaround to just get them to build quickly).

Comment 1 Fedora Update System 2013-01-17 11:56:28 UTC
eclipse-emf-2.8.1-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-emf-2.8.1-5.fc18

Comment 2 Krzysztof Daniel 2013-01-17 12:00:07 UTC
Hey Gerard,

f18, f19 and buildroot override :-).

Comment 3 Fedora Update System 2013-01-17 15:20:22 UTC
eclipse-emf-2.8.1-6.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-emf-2.8.1-6.fc18

Comment 4 Gerard Ryan 2013-01-18 14:14:11 UTC
Created attachment 682435 [details]
git formatted patch for eclipse repo to add the symlink

The link still needs to be added from %{_javadir}/emf/... to %{libdir}/eclipse/plugins. I think the attached patch is what's necessary, it should be something close to that at least.

Comment 5 Fedora Update System 2013-01-20 02:58:57 UTC
Package eclipse-emf-2.8.1-6.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing eclipse-emf-2.8.1-6.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-1005/eclipse-emf-2.8.1-6.fc18
then log in and leave karma (feedback).

Comment 6 Krzysztof Daniel 2013-01-21 07:48:50 UTC
Hey,

the emf.edit link cannot be a part of platform as no feature includes it.

I thought it would be as simple as moving the emf.edit from eclipse-emf-core to eclipse-emf, but that broke Eclipse build (it turned out to be required during Eclipse build). This is a no-go, because eclipse-emf has a lot of dependencies, while eclipse-emf-core has not. So I added a symlink from eclipse-emf to emf.edit inside eclipse-emf-core. That seems to work.

Comment 7 Gerard Ryan 2013-01-28 03:34:13 UTC
Sorry for the late reply, the link is broken though.

pushd %{buildroot}%{eclipse_dropin}/emf/eclipse/plugins
	ln -s %{_javadir}/emf/eclipse/plugins/org.eclipse.emf.edit_*
popd

should maybe that be:

pushd %{buildroot}%{eclipse_dropin}/emf/eclipse/plugins
	ln -s %{buildroot}%{_javadir}/emf/eclipse/plugins/org.eclipse.emf.edit_*
popd

?

I'm not sure if that's the problem. I'm trying to test now, but I don't know if I have the time to finish this test build of eclipse-emf. If I do, I'll let you know if it worked.

Comment 8 Krzysztof Daniel 2013-01-28 09:03:44 UTC
The link must be in the form of %{javadir}... because this is the place where emf.edit will be installed. Local build succeed because I had eclipse-emf-core installed locally, so the wildcard in the link was able to match it. This is not the case in koji, so the symlink must be without wildcards.

Comment 9 Fedora Update System 2013-01-28 09:36:57 UTC
eclipse-emf-2.8.1-7.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-emf-2.8.1-7.fc18

Comment 10 Fedora Update System 2013-01-28 11:37:13 UTC
eclipse-4.2.2-0.5.git20121217.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-4.2.2-0.5.git20121217.fc18

Comment 11 Fedora Update System 2013-02-06 11:16:38 UTC
eclipse-4.2.2-0.7.git20121217.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-4.2.2-0.7.git20121217.fc18

Comment 12 Fedora Update System 2013-02-08 02:00:33 UTC
eclipse-emf-2.8.1-7.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2013-02-20 11:18:12 UTC
eclipse-4.2.2-0.10.git20121217.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-4.2.2-0.10.git20121217.fc18

Comment 14 Fedora Update System 2013-02-27 18:44:56 UTC
eclipse-4.2.2-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-4.2.2-2.fc18

Comment 15 Fedora Update System 2013-03-04 09:09:46 UTC
eclipse-4.2.2-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-4.2.2-3.fc18

Comment 16 Fedora Update System 2013-03-15 11:52:25 UTC
eclipse-4.2.2-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-4.2.2-5.fc18

Comment 17 Fedora Update System 2013-03-19 20:04:00 UTC
eclipse-4.2.2-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.