Spec URL: http://ausil.us/packages/compat-libffi.spec SRPM URL: http://ausil.us/packages/compat-libffi-3.0.10-1.fc19.src.rpm Description: Compilers for high level languages generate code that follow certain conventions. These conventions are necessary, in part, for separate compilation to work. One such convention is the "calling convention". The calling convention is a set of assumptions made by the compiler about where function arguments will be found on entry to a function. A calling convention also specifies where the return value for a function is found. Some programs may not know at the time of compilation what arguments are to be passed to a function. For instance, an interpreter may be told at run-time about the number and types of arguments used to call a given function. `Libffi' can be used in such programs to provide a bridge from the interpreter program to compiled code. The `libffi' library provides a portable, high level programming interface to various calling conventions. This allows a programmer to call any function specified by a call interface description at run time. FFI stands for Foreign Function Interface. A foreign function interface is the popular name for the interface that allows code written in one language to call code written in another language. The `libffi' library really only provides the lowest, machine dependent layer of a fully featured foreign function interface. A layer must exist above `libffi' that handles type conversions for values passed between the two languages. Fedora Account System Username: ausil
I'll try and review this this weekend...
this is a compatibility library only to allow for a soname bump. its intended to have a life of only a few fedora releases.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: f01eb9027e9eb56aeaeef636649877756d475d714ef8b47f627f65bc5f3b492f libffi-3.0.10.tar.gz f01eb9027e9eb56aeaeef636649877756d475d714ef8b47f627f65bc5f3b492f libffi-3.0.10.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Spec has needed ldconfig in post and postun OK - .la files are removed. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Minor nits: The "# part of upstream commit 5feacad4" looks like a leftover. remove. Unless you intend to support old rhels: - Remove BuildRoot - Remove clean section - Remove rm -rf at the top of install Might mention in the description that this is a compat package for old versions. 2. rpmlint says: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. I Don't see any blockers here so this package is APPROVED. You can correct the nitpicks before import. ;)
New Package SCM Request ======================= Package Name: comapt-libffi Short Description: A portable foreign function interface compatability library Owners: ausil dbhole Branches: InitialCC:
Git done (by process-git-requests).
This is in and done. closing.