Bug 895168 - Port cinnamon's use of PIL to support Pillow for F19
Summary: Port cinnamon's use of PIL to support Pillow for F19
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: cinnamon
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: leigh scott
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PILLOW
TreeView+ depends on / blocked
 
Reported: 2013-01-14 18:01 UTC by Toshio Ernie Kuratomi
Modified: 2013-02-05 01:16 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-05 01:16:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to use the form of import of PIL that is pillow compatible (1.18 KB, patch)
2013-01-14 18:01 UTC, Toshio Ernie Kuratomi
no flags Details | Diff

Description Toshio Ernie Kuratomi 2013-01-14 18:01:03 UTC
Created attachment 678363 [details]
Patch to use the form of import of PIL that is pillow compatible

Fedora 19 is going to stop shipping python-imaging (PIL) and start shipping python-pillow instead.  Rationale can be found on the feature page: https://fedoraproject.org/wiki/Features/Pillow .  pillow should be compatible with PIL at the code level but the import statement changes slightly.

PIL supports both of these:

import Image

from PIL import Image

Pillow only supports the latter form.

I grepped through the cinnamon source and found some occurrences of "import Image".  I'll attach a patch that updates these to the new form of import.

Comment 1 Toshio Ernie Kuratomi 2013-01-29 17:13:35 UTC
If I don't hear anything back from you, I'll go ahead and use provenpackager powers to apply this patch to the RawHide package next week.  I'll leave sending the patch to upstream up to you, though.

Comment 2 leigh scott 2013-01-29 17:30:22 UTC
(In reply to comment #1)

> If I don't hear anything back from you, I'll go ahead and use provenpackager
> powers to apply this patch to the RawHide package next week.

I was waiting for python-pillow to be packaged but I note you added a virtual provides to python-imaging the other day.  

> I'll leave
> sending the patch to upstream up to you, though.

Done

https://github.com/linuxmint/Cinnamon/pull/1612

Comment 3 Toshio Ernie Kuratomi 2013-02-05 01:16:31 UTC
Cool.  New Cinnamon package built for rawhide.


Note You need to log in before you can comment on or make changes to this bug.