Bug 895226 - Review Request: python-django-grappelli - A jazzy skin for the Django admin interface
Summary: Review Request: python-django-grappelli - A jazzy skin for the Django admin i...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-14 21:28 UTC by Luis Bazan
Modified: 2013-08-25 12:17 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-08-25 12:17:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Luis Bazan 2013-01-14 21:28:43 UTC
Description

Grappelli is a grid-based alternative/extension to the Django
administration interface.

SPEC: 

http://lbazan.fedorapeople.org/python-django-grappelli.spec

SRPMS:

http://lbazan.fedorapeople.org/python-django-grappelli-2.4.3-3.fc17.src.rpm

$ rpmlint -i -v *
python-django-grappelli.noarch: I: checking
python-django-grappelli.noarch: I: checking-url https://github.com/sehmaschine/django-grappelli (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


$ rpmlint -v python-django-grappelli.spec
python-django-grappelli.spec: I: checking-url http://pypi.python.org/packages/source/d/django-grappelli/django-grappelli-2.4.3.tar.gz (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.


Regards

Comment 1 Eduardo Echeverria 2013-01-15 04:48:10 UTC
Hi Luis

Don't needed remove these files:
find . -name "*.js" -exec  rm -rfv '{}' \;

I removed this line and this is what rpmlint complains (e.g):

python-django-grappelli.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/grappelli/static/grappelli/tinymce/jscripts/tiny_mce/themes/advanced/langs/en_dlg.js
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.
.........

this can be solved with these lines:

for file in `find %{buildroot}/%{python_sitelib}/grappelli -type f  -perm /a+x -name '*.js'`; do
        chmod -v a-x $file
done

what is your intention in removing these files?
rm -rf grappelli/static/admin/js/compress.py
rm -rf grappelli/models.py
rm -rf grappelli/static/grappelli/jquery/ui/css/custom-theme/jquery-ui-1.8.18.custom.css
rm -rf grappelli/static/grappelli/stylesheets/mueller/screen.css

In the LICENSE file can be read: 
django-grappelli contains code from django-admin-tools

I think we're in a bundling problem here, the url of this project is [1]
Identify files that might be affected by the "bundling" and try to do a patch to solve this issues or try to ask for an exception to fpc [2]

This package also bundle jquery, although I think we can do nothing here for now, There is a stalled packaging guideline draft about JavaScript libraries [3]

[1] https://bitbucket.org/izi/django-admin-tools/overview
[2] https://fedorahosted.org/fpc/
[3] https://fedoraproject.org/wiki/JavaScript_libraries_packaging_guideline_draft

and jquery package has tried getting into Fedora several times without success
more information in:

- bug 457343
- bug 805587
- bug 857992


There is documentation to generate in this package, if you find it useful and interesting please add it to the package, need python-sphinx as BR

Regards

Comment 2 Mario Blättermann 2013-06-04 17:39:05 UTC
Any progress here...?

Comment 3 Mario Blättermann 2013-08-25 12:17:25 UTC
No response from the packager for eight months. I close it as FE-DEADREVIEW.


Note You need to log in before you can comment on or make changes to this bug.