Bug 895270 - Port impressive's use of PIL to support Pillow for F19
Summary: Port impressive's use of PIL to support Pillow for F19
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: impressive
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michael J Gruber
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PILLOW
TreeView+ depends on / blocked
 
Reported: 2013-01-14 23:13 UTC by Toshio Ernie Kuratomi
Modified: 2013-01-18 08:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-18 08:10:12 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to use the form of import of PIL that is pillow compatible (806 bytes, patch)
2013-01-14 23:13 UTC, Toshio Ernie Kuratomi
no flags Details | Diff

Description Toshio Ernie Kuratomi 2013-01-14 23:13:08 UTC
Created attachment 678496 [details]
Patch to use the form of import of PIL that is pillow compatible

Fedora 19 is going to stop shipping python-imaging (PIL) and start shipping python-pillow instead.  Rationale can be found on the feature page: https://fedoraproject.org/wiki/Features/Pillow .  pillow should be compatible with PIL at the code level but the import statement changes slightly.

PIL supports both of these:

import Image

from PIL import Image

Pillow only supports the latter form.

I grepped through the impressive source and found some occurrences of "import Image".  I'll attach a patch that updates these to the new form of import.

Comment 1 Michael J Gruber 2013-01-15 17:24:46 UTC
Update is pushed and in koji:

http://koji.fedoraproject.org/koji/buildinfo?buildID=378200

I can confirm that this works with the old PIL. Please confirm that it goes smoothly with PILLOW also ;)

Comment 2 Toshio Ernie Kuratomi 2013-01-17 21:03:36 UTC
@Sandro Mani -> are you able to confirm that the new build works with your proposed python-pillow packages?

Comment 3 Sandro Mani 2013-01-17 21:10:39 UTC
Doing a
$ impressive /some/file.pdf
seems to work just fine.

Comment 4 Michael J Gruber 2013-01-18 08:10:12 UTC
Thanks everyone.

Assuming that pillow doesn't go to F18, I'm closing this RAWHIDE.


Note You need to log in before you can comment on or make changes to this bug.