Bug 895290 - Port nml's use of PIL to support Pillow for F19
Summary: Port nml's use of PIL to support Pillow for F19
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: nml
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Felix Kaechele
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PILLOW
TreeView+ depends on / blocked
 
Reported: 2013-01-15 00:58 UTC by Toshio Ernie Kuratomi
Modified: 2013-09-01 21:12 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-01 21:12:07 UTC
Type: Bug


Attachments (Terms of Use)
Patch to use the form of import of PIL that is pillow compatible (2.07 KB, patch)
2013-01-15 00:58 UTC, Toshio Ernie Kuratomi
no flags Details | Diff

Description Toshio Ernie Kuratomi 2013-01-15 00:58:25 UTC
Created attachment 678529 [details]
Patch to use the form of import of PIL that is pillow compatible

Description of problem:
Fedora 19 is going to stop shipping python-imaging (PIL) and start shipping python-pillow instead.  Rationale can be found on the feature page: https://fedoraproject.org/wiki/Features/Pillow .  pillow should be compatible with PIL at the code level but the import statement changes slightly.

PIL supports both of these:

import Image

from PIL import Image

Pillow only supports the latter form.

I grepped through the nml source and found some occurrences of "import Image".  I'll attach a patch that updates these to the new form of import.

Comment 1 Felix Kaechele 2013-01-15 14:25:27 UTC
I plan on bringing this into Fedora right through upstream.

Upstream request here: http://dev.openttdcoop.org/issues/4799

Comment 2 Felix Kaechele 2013-01-19 10:18:53 UTC
Applied upstream: http://dev.openttdcoop.org/projects/nml/repository/revisions/013ceeaee4d1

Will be in next release which will in turn land in Fedora as soon as it's released.

Thanks so far.

Comment 3 Toshio Ernie Kuratomi 2013-02-05 01:39:21 UTC
Cool.  I'll try to remember to ping this bug when python-pillow is reviewed and approved for fedora.  (Since it will Provide and Obsolete python-imaging, packages that have the old import statements will stop working when that enters the repository).

Comment 4 Toshio Ernie Kuratomi 2013-03-06 16:14:06 UTC
The python-pillow package has now passed review.  It will enter rawhide soon.  This package will be unable to import PIL once that happens unless a version with the changed imports is built.

https://bugzilla.redhat.com/show_bug.cgi?id=908114

Comment 5 Fedora End Of Life 2013-04-03 19:21:42 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 6 Felix Kaechele 2013-09-01 21:12:07 UTC
Patch added long ago ;)
Will be in next upstream release.


Note You need to log in before you can comment on or make changes to this bug.