Spec URL: http://xor.cryptomilk.org/rpm/cmocka.spec SRPM URL: http://xor.cryptomilk.org/rpm/cmocka-0.2.0-1.fc18.src.rpm Description: There are a variety of C unit testing frameworks available supporting different platforms and compilers. Some development requires a lot of different compilers and older versions which makes it difficult to use unit testing frameworks. The idea of CMocka is that a test application only requires the standard C library and CMocka itself to minimize the conflicts with standard C library headers especially on a lot of different platforms. Fedora Account System Username: asn Reviewer: jhrozek
rpmlint output: libcmocka.x86_64: W: spelling-error %description -l en_US CMocka -> Cockatoo libcmocka.x86_64: W: non-standard-group System/Libraries libcmocka.x86_64: W: no-version-in-last-changelog libcmocka.x86_64: W: invalid-license Apache License 2.0 libcmocka.x86_64: W: shared-lib-calls-exit /usr/lib64/libcmocka.so.0.0.1 exit.5 libcmocka.x86_64: W: one-line-command-in-%post /sbin/ldconfig libcmocka.x86_64: W: one-line-command-in-%postun /sbin/ldconfig libcmocka-devel.x86_64: W: spelling-error Summary(en_US) cmocka -> cockatoo libcmocka-devel.x86_64: W: spelling-error %description -l en_US cmocka -> cockatoo libcmocka-devel.x86_64: W: non-standard-group Development/Libraries/C and C++ libcmocka-devel.x86_64: W: no-version-in-last-changelog libcmocka-devel.x86_64: W: invalid-license Apache-2.0 libcmocka-devel.x86_64: W: no-documentation cmocka-debuginfo.x86_64: W: no-version-in-last-changelog cmocka-debuginfo.x86_64: W: invalid-license Apache-2.0 cmocka-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmocka-0.2.0/src/cmocka.c cmocka-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmocka-0.2.0/include/cmocka.h cmocka.src: W: non-standard-group Productivity/Networking/Other cmocka.src: W: no-version-in-last-changelog cmocka.src: W: invalid-license Apache-2.0 cmocka.src: W: invalid-url Source0: cmocka-0.2.0.tar.gz There's a couple of things to fix: 1) libcmocka.x86_64: W: non-standard-group System/Libraries Please pick a group from /usr/share/doc/rpm-4.10.2/GROUPS 2) libcmocka.x86_64: W: no-version-in-last-changelog Please format the changelog lines according to https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs 3) libcmocka.x86_64: W: invalid-license Apache License 2.0 Please see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License:_field The license field should be a short name, in your case it should be "ASL 2.0" 4) libcmocka.x86_64: W: shared-lib-calls-exit /usr/lib64/libcmocka.so.0.0.1 exit.5 I guess this is something to fix upstream.. 5) libcmocka.x86_64: W: one-line-command-in-%post /sbin/ldconfig libcmocka.x86_64: W: one-line-command-in-%postun /sbin/ldconfig You can use %post -n <name> -p /sbin/ldconfig on one line
1) Fixed 2) Fixed 3) Fixed 4) No, that's how you exit a failing test. A testcase is a forked process. 5) Fixed Spec URL: http://xor.cryptomilk.org/rpm/cmocka.spec SRPM URL: http://xor.cryptomilk.org/rpm/cmocka-0.2.0-2.fc18.src.rpm
Full rpmlint output with the new packages: libcmocka.x86_64: W: spelling-error %description -l en_US CMocka -> Cockatoo libcmocka.x86_64: W: shared-lib-calls-exit /usr/lib64/libcmocka.so.0.0.1 exit.5 libcmocka-static.x86_64: W: spelling-error %description -l en_US cmocka -> cockatoo libcmocka-static.x86_64: W: no-documentation libcmocka-devel.x86_64: W: spelling-error Summary(en_US) cmocka -> cockatoo libcmocka-devel.x86_64: W: spelling-error %description -l en_US cmocka -> cockatoo libcmocka-devel.x86_64: W: no-documentation cmocka-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmocka-0.2.0/src/cmocka.c cmocka-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmocka-0.2.0/include/cmocka.h The executable permissions is something to fix eventually, but I think this seems like a problem in the tarball, not packaging.
Koji build succeeded: http://koji.fedoraproject.org/koji/taskinfo?taskID=4878884
FYI: I've fixed the permission of the header and C file upstream.
Sorry I still found one issue with the URL. 1) The URL points to 404 $ spectool -gf cmocka.spec Getting https://open.cryptomilk.org/attachments/download/7/cmocka-0.2.0.tar.gz/cmocka-0.2.0.tar.gz to ./cmocka-0.2.0.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 Not Found Another issue was actually found by the fedora-review tool: [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text But I think it's wrong, the upstream tarball includes COPYING, you include it with %doc and it's present in the RPMs, too (/usr/share/doc/libcmocka-0.2.0/COPYING). So please just fix the URL and I'll approve.
Spec URL: http://xor.cryptomilk.org/rpm/cmocka.spec SRPM URL: http://xor.cryptomilk.org/rpm/cmocka-0.2.0-3.fc18.src.rpm
Thank you. Looking good now.
This package is APPROVED. Setting fedora-review+.
btw here's a koji build with the latest packages: http://koji.fedoraproject.org/koji/taskinfo?taskID=4882381
New Package SCM Request ======================= Package Name: cmocka Short Description: Lightweight library to simplify and generalize unit tests for C Owners: asn Branches: f18 rawhide InitialCC: jhrozek
Git done (by process-git-requests).
cmocka-0.2.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/cmocka-0.2.0-3.fc18
cmocka-0.2.0-3.fc18 has been pushed to the Fedora 18 testing repository.
cmocka-0.2.0-3.fc18 has been pushed to the Fedora 18 stable repository.
Package Change Request ====================== Package Name: cmocka New Branches: el6 Owners: asn jhrozek
cmocka-0.4.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/cmocka-0.4.1-3.el6
cmocka-0.4.1-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
cmocka-0.4.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository.