Spec URL: http://bochecha.fedorapeople.org/packages/perl-ClamAV-Client.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ClamAV-Client-0.11-1.fc18.src.rpm Description: ClamAV::Client is a class acting as a client for a ClamAV clamd virus scanner daemon. The daemon may run locally or on a remote system as ClamAV::Client can use both Unix domain sockets and TCP/IP sockets. The full functionality of the clamd client/server protocol is supported. Fedora Account System Username: bochecha
URL and Source0 are usable. Ok. Source file is original (SHA-256: 2cf05681145d745269d6712c5ad424a10f381494123f568884d958d257e75246). Ok. Summary verified from README. Ok. Description verified from README. Ok. License verified from lib/ClamAV/Client.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: You can replace %{__perl} macros with plain perl command. No tests, not run-time dependencies are needed at build-time. Ok. `TODO' file does not contain any useful data. Not packaging it is Ok. $ rpmlint perl-ClamAV-Client.spec ../SRPMS/perl-ClamAV-Client-0.11-1.fc19.src.rpm ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm perl-ClamAV-Client.src: W: spelling-error Summary(en_US) clamd -> clams, clam, clad perl-ClamAV-Client.src: W: spelling-error %description -l en_US clamd -> clams, clam, clad perl-ClamAV-Client.noarch: W: spelling-error Summary(en_US) clamd -> clams, clam, clad perl-ClamAV-Client.noarch: W: spelling-error %description -l en_US clamd -> clams, clam, clad 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Jan 21 17:15 /usr/share/doc/perl-ClamAV-Client-0.11 -rw-r--r-- 1 root root 346 Jan 21 2005 /usr/share/doc/perl-ClamAV-Client-0.11/CHANGES -rw-r--r-- 1 root root 606 Jan 21 2005 /usr/share/doc/perl-ClamAV-Client-0.11/README -rw-r--r-- 1 root root 4138 Jan 21 17:15 /usr/share/man/man3/ClamAV::Client.3pm.gz -rw-r--r-- 1 root root 2319 Jan 21 17:15 /usr/share/man/man3/ClamAV::Config.3pm.gz drwxr-xr-x 2 root root 0 Jan 21 17:15 /usr/share/perl5/vendor_perl/ClamAV -rw-r--r-- 1 root root 14715 Jan 21 17:15 /usr/share/perl5/vendor_perl/ClamAV/Client.pm -rw-r--r-- 1 root root 3223 Jan 21 17:15 /usr/share/perl5/vendor_perl/ClamAV/Config.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm | sort |uniq -c 1 perl(base) 1 perl(Carp) 1 perl(ClamAV::Config) 1 perl(constant) 1 perl(Error) 1 perl(Error::Simple) 1 perl(IO::File) 1 perl(IO::Socket) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(IO::Socket::INET)' (lib/ClamAV/Client.pm:387). FIX: Run-require `perl(IO::Socket::UNIX)' (lib/ClamAV/Client.pm:448). $ rpm -q --provides -p ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm | sort |uniq -c 1 perl(ClamAV::Client) = 0.11 1 perl-ClamAV-Client = 0.11-1.fc19 1 perl(ClamAV::Client::Error) 1 perl(ClamAV::Config) = 0.11 1 perl(ClamAV::Config::Error) Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4889977). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: NOT approved.
(In reply to comment #1) > TODO: You can replace %{__perl} macros with plain perl command. Fixed. > $ rpm -q --requires -p > ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm | sort |uniq -c > 1 perl(base) > 1 perl(Carp) > 1 perl(ClamAV::Config) > 1 perl(constant) > 1 perl(Error) > 1 perl(Error::Simple) > 1 perl(IO::File) > 1 perl(IO::Socket) > 1 perl(:MODULE_COMPAT_5.16.2) > 1 perl(strict) > 1 perl(warnings) > 1 rpmlib(CompressedFileNames) <= 3.0.4-1 > 1 rpmlib(FileDigests) <= 4.6.0-1 > 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > 1 rpmlib(PayloadIsXz) <= 5.2-1 > FIX: Run-require `perl(IO::Socket::INET)' (lib/ClamAV/Client.pm:387). > FIX: Run-require `perl(IO::Socket::UNIX)' (lib/ClamAV/Client.pm:448). Oh, good catch. Fixed. > $ resolvedeps rawhide > ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm > Binary dependencies resolvable. Ok. [OFF-TOPIC] resolvedeps looks like a cool tool, where can I find it? :) > Please correct all `FIX' issues, consider fixing `TODO' items, and provide > new spec file. Thanks for the comments, here's the new submission. Spec URL: http://bochecha.fedorapeople.org/packages/perl-ClamAV-Client.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ClamAV-Client-0.11-2.fc18.src.rpm
Spec file changes: --- perl-ClamAV-Client.spec.old 2013-01-15 11:06:19.000000000 +0100 +++ perl-ClamAV-Client.spec 2013-01-22 04:40:16.000000000 +0100 @@ -1,7 +1,7 @@ Name: perl-ClamAV-Client Summary: Client class for the ClamAV clamd virus scanner daemon Version: 0.11 -Release: 1%{?dist} +Release: 2%{?dist} License: GPL+ or Artistic URL: http://search.cpan.org/dist/ClamAV-Client/ Source0: http://www.cpan.org/authors/id/J/JM/JMEHNLE/clamav-client/ClamAV-Client-%{version}.tar.gz @@ -10,7 +10,11 @@ BuildRequires: perl(Module::Build) -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) + +# These are not found by rpmbuild +Requires: perl(IO::Socket::INET) +Requires: perl(IO::Socket::UNIX) %{?perl_default_filter} @@ -26,7 +30,7 @@ %build -%{__perl} Build.PL installdirs=vendor +perl Build.PL installdirs=vendor ./Build @@ -47,5 +51,9 @@ %changelog +* Tue Jan 22 2013 Mathieu Bridon <bochecha> - 0.11-2 +- Replace usage of the %%{__perl} macro by the plain perl command. +- Add two run-time requirements missed by rpmbuild. + * Tue Jan 15 2013 Mathieu Bridon <bochecha> - 0.11-1 - Initial package for Fedora, with help from cpanspec. > TODO: You can replace %{__perl} macros with plain perl command. -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) -%{__perl} Build.PL installdirs=vendor +perl Build.PL installdirs=vendor Ok. > FIX: Run-require `perl(IO::Socket::INET)' (lib/ClamAV/Client.pm:387). +Requires: perl(IO::Socket::INET) Ok. > FIX: Run-require `perl(IO::Socket::UNIX)' (lib/ClamAV/Client.pm:448). +Requires: perl(IO::Socket::UNIX) Ok. $ rpmlint perl-ClamAV-Client.spec ../SRPMS/perl-ClamAV-Client-0.11-2.fc19.src.rpm ../RPMS/noarch/perl-ClamAV-Client-0.11-2.fc19.noarch.rpm perl-ClamAV-Client.src: W: spelling-error Summary(en_US) clamd -> clams, clam, clad perl-ClamAV-Client.src: W: spelling-error %description -l en_US clamd -> clams, clam, clad perl-ClamAV-Client.noarch: W: spelling-error Summary(en_US) clamd -> clams, clam, clad perl-ClamAV-Client.noarch: W: spelling-error %description -l en_US clamd -> clams, clam, clad 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-ClamAV-Client-0.11-2.fc19.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(Carp) 1 perl(ClamAV::Config) 1 perl(constant) 1 perl(Error) 1 perl(Error::Simple) 1 perl(IO::File) 1 perl(IO::Socket) 1 perl(IO::Socket::INET) 1 perl(IO::Socket::UNIX) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-ClamAV-Client-0.11-2.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4892697). Ok. Package is good. Resolution: Package APPROVED.
(In reply to comment #2) > [OFF-TOPIC] resolvedeps looks like a cool tool, where can I find it? :) > It's just a short shell script <http://ppisar.fedorapeople.org/betterfedora/resolvedeps>.
Thanks for the review Petr! (In reply to comment #4) > (In reply to comment #2) > > [OFF-TOPIC] resolvedeps looks like a cool tool, where can I find it? :) > > > It's just a short shell script > <http://ppisar.fedorapeople.org/betterfedora/resolvedeps>. Oh, nice, thanks for that. New Package SCM Request ======================= Package Name: perl-ClamAV-Client Short Description: Client class for the ClamAV clamd virus scanner daemon Owners: bochecha Branches: devel InitialCC: perl-sig
Git done (by process-git-requests).
Thanks for the Git process Jon. Package built in Rawhide, closing.