Bug 896295 - Port textile's use of PIL to support Pillow for F19
Summary: Port textile's use of PIL to support Pillow for F19
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-textile
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Thomas Moschny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PILLOW
TreeView+ depends on / blocked
 
Reported: 2013-01-17 00:27 UTC by Toshio Ernie Kuratomi
Modified: 2013-01-30 18:41 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-30 18:41:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to use the form of import of PIL that is pillow compatible (1.03 KB, patch)
2013-01-17 00:27 UTC, Toshio Ernie Kuratomi
no flags Details | Diff

Description Toshio Ernie Kuratomi 2013-01-17 00:27:23 UTC
Created attachment 679941 [details]
Patch to use the form of import of PIL that is pillow compatible

Description of problem:

Fedora 19 is going to stop shipping python-imaging (PIL) and start shipping python-pillow instead.  Rationale can be found on the feature page: https://fedoraproject.org/wiki/Features/Pillow .  pillow should be compatible with PIL at the code level but the import statement changes slightly.

PIL supports both of these:

import Image

from PIL import Image

Pillow only supports the latter form.

I grepped through the textile source and found some occurrences of "import Image".  I'll attach a patch that updates these to the new form of import.

Comment 1 Toshio Ernie Kuratomi 2013-01-17 00:50:37 UTC
Also, python-textile should probably have:

Require: python-imaging

in its spec file

Comment 2 Toshio Ernie Kuratomi 2013-01-29 17:18:59 UTC
If I don't hear anything back from you, I'll go ahead and use provenpackager powers to apply this patch to the RawHide package next week.  I'll leave sending the patch to upstream and the decision whether to add python-imaging to the spec file up to you, though.

Comment 3 Thomas Moschny 2013-01-30 18:41:59 UTC
Filed a bug upstream: https://github.com/sebix/python-textile/pull/10

To me python-imaging seems to be an optional runtime dependency, so I think we should not add the Requires: tag.

Updated package in Rawhide.


Note You need to log in before you can comment on or make changes to this bug.