Bug 896296 - Port polybori's use of PIL to support Pillow for F19
Summary: Port polybori's use of PIL to support Pillow for F19
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: polybori
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PILLOW
TreeView+ depends on / blocked
 
Reported: 2013-01-17 00:28 UTC by Toshio Ernie Kuratomi
Modified: 2013-01-21 23:26 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-21 23:26:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to use the form of import of PIL that is pillow compatible (726 bytes, patch)
2013-01-17 00:28 UTC, Toshio Ernie Kuratomi
no flags Details | Diff

Description Toshio Ernie Kuratomi 2013-01-17 00:28:08 UTC
Created attachment 679942 [details]
Patch to use the form of import of PIL that is pillow compatible

Description of problem:

Fedora 19 is going to stop shipping python-imaging (PIL) and start shipping python-pillow instead.  Rationale can be found on the feature page: https://fedoraproject.org/wiki/Features/Pillow .  pillow should be compatible with PIL at the code level but the import statement changes slightly.

PIL supports both of these:

import Image

from PIL import Image

Pillow only supports the latter form.

I grepped through the polybori source and found some occurrences of "import Image".  I'll attach a patch that updates these to the new form of import.

Comment 1 Jerry James 2013-01-17 04:34:41 UTC
Thanks for the patch.  Will a BR of python-imaging-devel and an R of python-imaging still be correct, or will they need to be changed too?

Comment 2 Toshio Ernie Kuratomi 2013-01-17 06:23:38 UTC
The plan is to have python-pillow Provide python-imaging{-devel,-tk,etc} since the API is the same except for dropping the old method of importing.

You can update the package to use python-pillow and python-pillow-devel once those packages have replaced python-imaging in the repository if you like but it shouldn't be necessary for at least the next few releases.

Comment 3 Jerry James 2013-01-21 23:26:04 UTC
I just rebuilt polybori in Rawhide with this patch, and forwarded the patch upstream.  Thanks, Toshio.


Note You need to log in before you can comment on or make changes to this bug.