Attempted to create a new PHP-5.3 app with git URL: git:smarterclayton/drupal-example.git Got a site exception, search site logs for reference # def6c9255744c68ebf95bf3ff8718aa8
Tested this issue on devenv_2687, and STG, found that the new PHP-5.3 app can be created successfully both on dev and STG with git URL: https://github.com/smarterclayton/drupal-example.git . However, the new PHP-5.3 app can only be created successfully on dev with git URL: git:smarterclayton/drupal-example.git , and will get a site exception on STG. Steps to test as follows: 1. Created a new PHP-5.3 app with git URL: git:smarterclayton/drupal-example.git on devenv_2687. 2. Created a new PHP-5.3 app with git URL: https://github.com/smarterclayton/drupal-example.git on devenv_2687. 3. Created a new PHP-5.3 app with git URL: git:smarterclayton/drupal-example.git on STG. 4. Created a new PHP-5.3 app with git URL: https://github.com/smarterclayton/drupal-example.git on STG. Actual result: 1. Created successfully. 2. Created successfully. 3. Got site exception. 4. Created successfully. Expected result: Both app created at step 1,2,3,4 should be created successfully.
Created attachment 682450 [details] Log from mcollective/broker showing node execution failure The attached log shows a node execution failure in prod. Transient possibly?
I think this is the issue (from the mcollective log)... Cloning git repository from remote 'git:smarterclayton/drupal-example.git'. Initialized empty Git repository in /var/lib/openshift/20fcbca5a856484ba34143c842682999/git/drupal719.git/ Host key verification failed. fatal: The remote end hung up unexpectedly
This fails on my devenv. There's a host key for github, then a host key for my app but there's no line-break between them. Whatever procedure added the git hub host key has a bug. Since ssh cloning may have host and authorization key issues; I think we should restrict cloning to just http://, https:// and git:// on app create.
Pristine devenv is fine. Its just when you ssh from the devenv and a new host key is added that the github host key breaks. https://github.com/openshift/li/pull/771 Still need to diagnose whether the same issue happened on prod. Still think we should not allow the ssh git clone method.
Updated the release ticket.
Created attachment 684175 [details] Git output on prod. This problem does not seem to exist in prod. I have attached the output of me going a git clone on git@gitub then https then doing git@github.
The git clone happens as root as part of the cartridge hooks. Is it possible to try cloning the git repo as root on all ex nodes on stg and prod? Thanks!
Feedback from ops is that prod does not carry the keys. I think given that host key issues can crop up on any ex node based on changes outside our control, and we don't provide a way to include ssh keys anyway for git cloning; we're going to have to exclude ssh based git cloning when creating an app with an external repository. Users will still be able to create apps with external repositories of the following types: git://host.xz[:port]/path/to/repo.git/ http[s]://host.xz[:port]/path/to/repo.git/ ftp[s]://host.xz[:port]/path/to/repo.git/ rsync://host.xz/path/to/repo.git/
Restrict URL types and emit useful error messages. https://github.com/openshift/origin-server/pull/1190 One last piece to fix is how to tell the UI which box to highlight for the error.
Make the strings consistent so that the broker can set the field properly. https://github.com/openshift/origin-server/pull/1195 An additional bug has been filed to have the broker specify the proper hint to the UI. Bug 902947.
*** Bug 829452 has been marked as a duplicate of this bug. ***
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/138ed190b878a1afddce9c6cf9ec707bc572553e Bug 896364 - Minor cleanup.
Retest this issue on devenv_2709 and INT (same with devenv_2709) with following steps: 1. Created a new PHP-5.3 app with git URL not allowed: git:smarterclayton/drupal-example.git on devenv_2709. 2. Created a new PHP-5.3 app with git URL not valid: ftp://github.com/smarterclayton/drupal-example.git on devenv_2709. 3. Created a new PHP-5.3 app with correct and allowed git URL : https://github.com/smarterclayton/drupal-example.git on devenv_2709. 4. Created a new PHP-5.3 app with git URL: git:smarterclayton/drupal-example.git on INT. 5. Created a new PHP-5.3 app with git URL: https://github.com/smarterclayton/drupal-example.git on INT. Actual result: 1. Error message :"Source Code repository URL type must be one of: git:// http:// https:// ftp:// ftps:// rsync:// " was shown when created app. And the "Public URL" dialogue box is highlighted. 2. Error message :"Unable to clone the remote git repository: 'ftp://github.com/smarterclayton/drupal-example.git'. Please verify the repository is correct and contact support. " was shown when created app. And the "Public URL" dialogue box is highlighted. 3.Created successfully. 4. Error message :"Source Code repository URL type must be one of: git:// http:// https:// ftp:// ftps:// rsync:// " was shown when created app. And the "Public URL" dialogue box is highlighted. 5.Created successfully. Expected result: 2.Error message :"Source Code repository could not be cloned: 'ftp://github.com/smarterclayton/drupal-example.git'. Please verify the repository is correct and contact support. " should be shown when created app. And the "Source Code" dialogue box should be highlighted. Will verify this bug when the code in #Comment 3 merged in.
Verify this bug with following steps: 1.Created a new PHP-5.3 app with git URL not valid: ftp://github.com/smarterclayton/drupal-example.git on devenv_2710. 2.Created a new drupal app with git URL not valid: ftp://github.com/smarterclayton/drupal-example.git on devenv_2710. Actual result: At step 1,2, both get error message: "Source Code repository could not be cloned: 'ftp://github.com/smarterclayton/drupal-example.git'. Please verify the repository is correct and contact support. "