Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 896418

Summary: engine [TEXT]: event log message when failed to delete a live migrate snapshot is not clear
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: ovirt-engineAssignee: Alissa <abonas>
Status: CLOSED CURRENTRELEASE QA Contact: Dafna Ron <dron>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.2.0CC: acathrow, amureini, dyasny, hateya, iheim, lpeer, Rhev-m-bugs, sgrinber, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.2.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: SF6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine log none

Description Dafna Ron 2013-01-17 09:30:51 UTC
Created attachment 680080 [details]
engine log

Description of problem:

the message is:

Failed to complete Snapshot Auto-generated for Live Storage Migration deletion on VM TEST.

it took me a second to realize that it just looks odd because the name of the snapshot is ' Auto-generated for Live Storage Migration'

We should either change the message to a simpler message (like failed to delete snapshot 'XXX' on VM 'XXX'
or we should add ' at the start of the name and at the end of it. 

Version-Release number of selected component (if applicable):

sf3

How reproducible:

100%

Steps to Reproduce:
1. create a failure in live migration (like restarting engine/vdsm) 
2. try to delete the snapshot
3.
  
Actual results:

error message is unclear

Expected results:

we should either simplify the error message  or add ' at the begging and end of the snapshot name which will clear the message a bit. 


Additional info:

Comment 1 Allon Mureinik 2013-01-23 09:59:50 UTC
devel-ack to adding quotes around the snapshot description.

Comment 2 Allon Mureinik 2013-01-27 12:21:05 UTC
devel-ack for rephrasing message too.

Comment 3 Alissa 2013-01-27 13:59:23 UTC
agreed with Allon to rephrase and add quotes around names as following:
Old version:
Failed to complete Snapshot ${SnapshotName} deletion on VM ${VmName}.

New version:
Failed to delete snapshot '${SnapshotName}' on VM '${VmName}'.

Also, will add quotes similarly to the symmetrical message of successful deletion for snasphot 
(current version: Snapshot ${SnapshotName} deletion on VM ${VmName} has been completed.)

Making reproduction scenario more accurate:
1. go to VMs tab -select a VM which is up
2. go to snapshot tab and create a snapshot
3. power off/shutdown VM
4. delete the snapshot and restart vdsm in the middle

Comment 4 Alissa 2013-01-27 16:19:25 UTC
the fix contains improving all 6 event log messages related to creation/deletion of snapshots.

Comment 5 Allon Mureinik 2013-01-27 16:21:02 UTC
(In reply to comment #4)
> the fix contains improving all 6 event log messages related to
> creation/deletion of snapshots.
What fix?
Is it possible that you forgot to attach an external-tracker to gerrit?

Comment 6 Alissa 2013-01-27 16:22:15 UTC
http://gerrit.ovirt.org/#/c/11439/

Comment 8 Alissa 2013-01-31 13:00:09 UTC
added target release = 3.2 based on rhevm‑3.2.0+

Comment 9 Dafna Ron 2013-02-07 16:13:06 UTC
verified on sf6

	
Failed to complete snapshot 'Auto-generated for Live Storage Migration' creation for VM 'Snap'.

Comment 10 Vered Volansky 2013-02-13 09:33:17 UTC
*** Bug 907148 has been marked as a duplicate of this bug. ***

Comment 11 Itamar Heim 2013-06-11 09:02:38 UTC
3.2 has been released

Comment 12 Itamar Heim 2013-06-11 09:02:40 UTC
3.2 has been released

Comment 13 Itamar Heim 2013-06-11 09:02:40 UTC
3.2 has been released

Comment 14 Itamar Heim 2013-06-11 09:03:27 UTC
3.2 has been released

Comment 15 Itamar Heim 2013-06-11 09:32:38 UTC
3.2 has been released