Description of problem: The view_server needs to have POOL_HISTORY_DIR defined or it will not work. The parameter defaults to $(LOCAL_DIR)/ViewHist. Currently, the plumage rpm creates and owns the ViewHist $(LOCAL_DIR)/ViewHist directory, but the view_server can be used w/o plumage. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Upstream documentation on this is different then what is in the code. -------------------------------------------------------- POOL_HISTORY_DIR This macro sets the name of the directory where the history files reside (if history logging is enabled). The default is the SPOOL directory. -------------------------------------------------------- view_server.cpp: tmp=param("POOL_HISTORY_DIR"); if (!tmp) { tmp=param("LOCAL_DIR"); if (!tmp) { EXCEPT("No POOL_HISTORY_DIR or LOCAL_DIR directory specified in config file\n"); } history_dir_buf.sprintf("%s/ViewHist",tmp); } else { history_dir_buf = tmp; } history_dir = history_dir_buf.Value(); free(tmp); dprintf(D_ALWAYS, "Configuration: SAMPLING_INTERVAL=%d, MAX_STORAGE=%d, MaxFileSize=%d, POOL_HISTORY_DIR=%s\n",HistoryInterval,MaxStorage,MaxFileSize,history_dir); if(!IsDirectory(history_dir)) { // TSTCLAIR: HERE IS WHERE IT FALLS APART. EXCEPT("POOL_HISTORY_DIR (%s) does not exist.\n",history_dir); } ---------------------------------------------------------- Maybe is makes sense to default to SPOOL as outlined in the documentation, I can't think of a reason not to. Or we can create the directory in the .spec, I have no strong feelings either way. Thoughts?
I don't really feel strongly either way. I was surprised to discover that the view_server needed a separate directory actually, so from that perspective SPOOL seems to make sense. Have any thoughts on that?
On second thought, the ViewServer creates a lot of files when keeping stat history. The ViewServer in the base-db is configured to keep stat history, so I think setting the default of POOL_HiSTORY_DIR to SPOOL may not be the way to go here. I think we should have the condor RPM own the POOL_HISTORY_DIR
MRG-Grid is in maintenance and only customer escalations will be considered. This issue can be reopened if a customer escalation associated with it occurs.