Spec URL: http://andyp.fedorapeople.org/iowatcher/iowatcher.spec SRPM URL: http://andyp.fedorapeople.org/iowatcher/iowatcher-0.0.0.git26d4e95-1.fc19.src.rpm Description: iowatcher generates graphs from blktrace runs to help visualize IO patterns and performance as SVG images or movies. It can plot multiple blktrace runs together, making it easy to compare the differences between different benchmark runs. iowatcher is similar to seekwatcher, which was written by the same author. Fedora Account System Username: andyp A note on the crazy package version: iowatcher is currently pre-release but it is nearing a 1.0 release so I wanted to get this review request filed preemptively so I rolled a tarball from the latest git (which I've tested). Once version 1.0 is released I intend to update the packaging to have a sensible version string.
Updated spec: http://andyp.fedorapeople.org/iowatcher/iowatcher.spec Updated SRPM: http://andyp.fedorapeople.org/iowatcher/iowatcher-0-0.1.git26d4e95.fc19.src.rpm I've fixed the version-release according to http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages There's only one valid rpmlint warning, "incorrect-fsf-address", and I've notified upstream about it.
Hi Andrew, You have plans to EL5? if not - %clean is not needed - BuildRoot is not needed - cleaning of buildroot in %install is not needed - %defattr is not needed Some initial issues: - You may not use your personal space as url of Source0, instead can do a comment on how the tarball was generated, e.g. # Sources from foo # git clone git://foo.com/foo.git # cd foo .... - In [1] can be read: "If the snapshot package is considered a "pre-release package", you should follow the guidelines listed in Pre-Release Packages for snapshot packages, using the %{checkout}..." You can use: %global checkout 26d4e95git Name: iotwatcher Version: 0.0 Release: 1.%{checkout}%{?dist} Source0: iowatcher-%{version}.%{checkout}.tar.gz - use DESTDIR to install [2] e.g. make install DESTDIR=%{buildroot} PREFIX=%{_prefix} instead of make prefix=%{buildroot}/usr install - in this line, preserve the timestamps: use install -p -m 0644 -D iowatcher.1 %{buildroot}%{_mandir}/man1/iowatcher.1 instead of install -m 0644 -D iowatcher.1 %{buildroot}%{_mandir}/man1/iowatcher.1 - Please review ownership of files and directories.[3] %{_bindir}/* %{_mandir}/man1/* - should honor compiler flags - Use %{?_smp_mflags} macro for the make command [1] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages [2] http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_section [3] https://fedoraproject.org/wiki/Packaging:UnownedDirectories Best Regards
I'm sorry, I made little mistake explaining the pre-release snapshot taking into account the date you made the snapshot, should be %global checkout 20130117git26d4e95 Name: iowatcher Version: 0.0 Release: 1.%{checkout}%{?dist} Source0: iowatcher-%{version}.%{checkout}.tar.gz
Hi Eduardo, many thanks for the review. I've addressed all of the points you've highlighted in this update: Spec: http://andyp.fedorapeople.org/iowatcher/iowatcher.spec SRPM: http://andyp.fedorapeople.org/iowatcher/iowatcher-0.0-1.20130117git26d4e95.fc19.src.rpm
Created attachment 682740 [details] Alternate spec
Hi again Andrew: Ooh, didn't turn out as it should, packaging pre-release snapshots and versioning must be treated with care and have to get used to used the correctly guidelines. As important thing here is to solve, I made a alternate spec with the following points. - Again improve the versioning.(sorry) - Honor build flags with %{optflags} - Improve the list in %files. I'll travel this weekend, unless someone beats me until Monday, I'll do the formal review :) Note: Please bump the release number and changelog, every time you make a change in the spec. Have a nice weekend!!
Ok, thanks a lot.
OK 1.0 has been released :) I've updated the package and added your changes to the spec file. It's rpmlint clean now that the incorrect-fsf-address has been fixed upstream. Spec: http://andyp.fedorapeople.org/iowatcher/iowatcher.spec SRPM: http://andyp.fedorapeople.org/iowatcher/iowatcher-1.0-1.fc19.src.rpm
Hi Andrew, the package looks good, I'll do the formal review - The spelling warnings can be ignored - The SourceX should be http, not https, please fix before importing - the wildcard in %{_bindir}/%{name}* is not necessary unless you have multiple files that begin with the same name, in this case it is not, at this point it does not matter, but consider the future, please consider fix before importing. Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. http://koji.fedoraproject.org/koji/taskinfo?taskID=4892462 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL". 1 files have unknown license. Detailed output of licensecheck in /home/makerpm/rpmbuild/io/896744-iowatcher/licensecheck.txt - I checked manually, GPLv2 OK (in COPYING file) [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX / PatchY prefixed with %{name}. [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. http://koji.fedoraproject.org/koji/taskinfo?taskID=4892462 http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=876831 http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=917487 http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=1380317 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: iowatcher-1.0-1.fc17.src.rpm iowatcher-1.0-1.fc17.x86_64.rpm iowatcher-debuginfo-1.0-1.fc17.x86_64.rpm iowatcher.src: W: spelling-error %description -l en_US blktrace -> traceable 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint iowatcher iowatcher-debuginfo 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- iowatcher-1.0-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): blktrace libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) sysstat theora-tools iowatcher-debuginfo-1.0-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): Provides -------- iowatcher-1.0-1.fc17.x86_64.rpm: iowatcher = 1.0-1.fc17 iowatcher(x86-64) = 1.0-1.fc17 iowatcher-debuginfo-1.0-1.fc17.x86_64.rpm: iowatcher-debuginfo = 1.0-1.fc17 iowatcher-debuginfo(x86-64) = 1.0-1.fc17 MD5-sum check ------------- https://www.kernel.org/pub/linux/kernel/people/mason/iowatcher/iowatcher-1.0.tar.bz2 : CHECKSUM(SHA256) this package : 99e11969fa075240115d459ff0134fee9ac531d4281b6679821e1f3812d9cf36 CHECKSUM(SHA256) upstream package : 99e11969fa075240115d459ff0134fee9ac531d4281b6679821e1f3812d9cf36 ---------------- PACKAGE APPROVED ----------------
Thanks Eduardo! New Package SCM Request ======================= Package Name: iowatcher Short Description: Utility for visualizing block layer I/O Owners: andyp Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
Thanks Jon. Package has been imported and built successfully. Closing this bz.
iowatcher-1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/iowatcher-1.0-1.fc18
iowatcher-1.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/iowatcher-1.0-1.fc17
iowatcher-1.0-1.fc17 has been pushed to the Fedora 17 stable repository.
iowatcher-1.0-1.fc18 has been pushed to the Fedora 18 stable repository.