Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 899145 (JBPAPP6-418)

Summary: Version in hsqldb.jar 1.8.0.8patch02 MANIFEST.MF gets overwritten by the AS version
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Jaroslaw Kijanowski <kijanowski>
Component: BuildAssignee: Fernando Nasser <fnasser>
Status: CLOSED WONTFIX QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: unspecifiedCC: weli
Target Milestone: ---   
Target Release: EAP 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/JBPAPP6-418
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-03-29 15:45:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
compute-jar-signature
none
hsqldb-eap.jar
none
hsqldb-seam.jar none

Description Jaroslaw Kijanowski 2009-09-18 12:18:46 UTC
Date of First Response: 2009-09-18 09:11:56
project_key: JBPAPP6

See https://jira.jboss.org/jira/browse/JBPAPP-2800?focusedCommentId=12485869#action_12485869 for details.

Usually the buildmagic AS build only fills the MANIFEST.MF version if there are no version in there.  In this case, however, there is a version:

Manifest-Version: 1.0

Ant-Version: Apache Ant 1.7.1

Created-By: 1.5.0_18-b02 (Sun Microsystems Inc.)

Specification-Title: HSQLDB

Specification-Version: 1.8.0.8

Specification-Vendor: The HSQLDB Development Group

Implementation-Title: Standard runtime

Implementation-Version: 1.8.0.8.patch02

Implementation-Vendor: mockbuild

Main-Class: org.hsqldb.util.SqlTool

Comment 1 Fernando Nasser 2009-09-18 13:11:56 UTC
Jaroslaw, please post both MANIFEST.MF (from Seam and from the AS) to make debugging easier.  Thanks.

Comment 2 Jaroslaw Kijanowski 2009-09-18 13:23:34 UTC
Ok, to sum it up, here are the manifests I have:
manifest from EAP:
++++++++++++++++++++
Manifest-Version: 1.0
Specification-Title: JBoss
Created-By: 14.1-b02 (Sun Microsystems Inc.)
Ant-Version: Apache Ant 1.7.1
Implementation-Title: JBoss [EAP]
Specification-Version: 5.0.0.FCS
Specification-Vendor: JBoss (http://www.jboss.org/)
Implementation-Vendor-Id: http://www.jboss.org/
Implementation-Version: 5.0.0.FCS (build: SVNTag=JBPAPP_5_0_0_FCS date=200909081955)
Implementation-Vendor: JBoss Inc.
Implementation-URL: http://www.jboss.org/
++++++++++++++++++++
and Seam:
++++++++++++++++++++
Manifest-Version: 1.0
Specification-Title: HSQLDB
Created-By: 1.5.0_18-b02 (Sun Microsystems Inc.)
Ant-Version: Apache Ant 1.7.1
Main-Class: org.hsqldb.util.SqlTool
Implementation-Title: Standard runtime
Specification-Vendor: The HSQLDB Development Group
Specification-Version: 1.8.0.8
Implementation-Version: 1.8.0.8.patch02
Implementation-Vendor: mockbuild
++++++++++++++++++++



Comment 3 Fernando Nasser 2009-09-18 13:34:46 UTC
Please run the attached script in both of the files and paste the result here.  Thanks again.

(it takes a single argument which is the JAR file)

Comment 4 Fernando Nasser 2009-09-18 13:34:46 UTC
Attachment: Added: compute-jar-signature


Comment 5 Jaroslaw Kijanowski 2009-09-18 14:19:52 UTC
eap:
$ ./s hsqldb.jar 
acd88612b1735fde19f59ab810ba0ea4  hsqldb.jar

seam:
$ ./s hsqldb.jar 
ac22476a0ffb7ffba2977ee1e575500b  hsqldb.jar

Comment 6 Jaroslaw Kijanowski 2009-09-18 14:21:46 UTC
Attachment: Added: hsqldb-eap.jar
Attachment: Added: hsqldb-seam.jar


Comment 7 Fernando Nasser 2009-09-18 16:34:21 UTC
OK, this is what happened: the hsqldb had to be rebuilt (exactly the same) to be in the proper set as required by the RCM folks.
Builds are now done with Java 5 (soon they will move to Java 6).

When this was first built and uploaded to the maven repo, Java 4 was used.  And we cannot re-upload a version that has already been shipped in the maven repository.

The AS gets it from the maven repository, the Java 4-compiled one.
Seam gets it from the most recent Brew build, Java 5-compaled (no code changes).

==> bytecodes differ

Due to the re-uploading restrictions, this cannot be easily solved.  One possibility would be to create a patch03 version (kind of a lie, as there is no code changes) and switch all to that one. I'd rather wait for Java 6 then, to avoid the same problem if a rebuild is done.

HOWEVER: this does not explain why the versions in the MANIFEST were overwritten.  It is of no consequence but I'd like to keep this JIRA around until we find out from someone that knows the depths of buildmagic why a MANIFEST that has both Specification and Implementation versions filled gets the AS build version in it at the end.


Comment 8 Fernando Nasser 2009-09-25 18:40:53 UTC
Link: Added: This issue related JBPAPP-811


Comment 9 Fernando Nasser 2010-03-04 23:35:56 UTC
These will be fixed in EAP 6 when Maven will be used to build and buildmagic will be phased out.
The cost of trying to investigate this further for EAP 5 is not justifiable.

Comment 10 Rajesh Rajasekaran 2012-03-29 15:45:40 UTC
Marking Won't Fix Issues closed. Nothing to verify here.