Bug 899534 (JBPAPP6-121)
| Summary: | JSF 1.2 slot is broken (for RichFaces 3.x support) | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Karel Piwko <kpiwko> | ||||||||||
| Component: | RichFaces | Assignee: | Fernando Nasser <fnasser> | ||||||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | |||||||||||
| Severity: | urgent | Docs Contact: | |||||||||||
| Priority: | urgent | ||||||||||||
| Version: | 6.0.0 | CC: | atangrin, bmaxwell, fnasser, kpiwko, maschmid, no-reply, ochaloup, ssilvert | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | EAP 6.0.0 | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| URL: | http://jira.jboss.org/jira/browse/JBPAPP6-121 | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2012-11-04 23:12:11 UTC | Type: | Bug | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Karel Piwko
2011-10-06 11:27:55 UTC
Link: Added: This issue is related to AS7-2025 I'm not sure why this was assigned to me. I don't know anything about changes in various versions of EAP and I certainly would have no knowledge of changes between DR3 and DR4. Possibly, the problem has something to do with this? 13:21:25,194 ERROR [org.hibernate.tool.hbm2ddl.SchemaExport] (MSC service thread 1-4) HHH00389:Unsuccessful: alter table Booking drop constraint FK6713A039A372CD94 13:21:25,194 ERROR [org.hibernate.tool.hbm2ddl.SchemaExport] (MSC service thread 1-4) Table "BOOKING" not found; SQL statement: alter table Booking drop constraint FK6713A039A372CD94 [42102-145] Is there anything more specific that you need from me? I can speak to how the JSF integration works, but as far as I know there haven't been any changes to JSF integration in community AS7 for quite some time. Hi Stan, I assigned this to you as you are JSF Integration Lead for AS7 and we QE process require all JBAPPP EAP6 issues to be assigned. Feel free to reassign to any person which can provide better knowledge of changes in JSF stack between 7.0.1 and 7.1.0. So is DR3 based on 7.0.1 and DR4 is based on 7.1.0? Have you looked into the Hibernate errors? Yes, DR4 is based on internal 7.1.0.Alpha4 tag and DR3 on 7.0.1.Final with some of the future fixes. I have raised a community issues as well, if you want to check it there (AS7-2025). I think Hibernate errors are not related. I can provide an example which manifests same error but it does not have Hibernate problems. Karel and Stan, this issue AFAIK is the same as we discussed when Brad did patch for JSF initialization (changing Class loader) and broke custom tag library loading. Link: Added: This issue is related to JBPAPP-6414 Bugzilla References: Added: https://bugzilla.redhat.com/show_bug.cgi?id=744854 Stan, Marek,
according to the direction Marek gave me, I modified to jboss-deployment-structure.xml to use JSF 1.2 distributed in WAR as
{code:xml}
<jboss-deployment-structure>
<deployment>
<exclusions>
<module name="javax.faces.api" slot="main" />
<module name="com.sun.jsf-impl" slot="main" />
<module name="javax.faces.api" slot="1.2" />
<module name="com.sun.jsf-impl" slot="1.2" />
</exclusions>
<dependencies>
<module name="org.apache.log4j" />
<module name="org.dom4j" />
<module name="org.apache.commons.logging" />
<module name="org.apache.commons.collections" />
</dependencies>
</deployment>
</jboss-deployment-structure>
{code}
This fixes the issue, so JSF 1.2 distributed with EAP6/AS7 must be broken.
Email from Brad
{panel}It looks like JBPAPP-7346 maybe using the JSF 1.2 patched jars I sent you which have a
bug, if that is the case, then we can assign the jira to me and I'll get them rebuilt.{panel}
Sorry I forgot to assign this to you earlier. Can you take a look at this and AS7-2025 to see if this is caused by the bug your are referring to?
Attachment: Added: jsf-impl.jar Attachment: Added: jsf-api.jar Attachment: Removed: jsf-api.jar Attachment: Removed: jsf-impl.jar Attachment: Added: jsf-api-1.2_15-jbossorg-2.jar Attachment: Added: jsf-api-1.2_15-jbossorg-2-sources.jar Attachment: Added: jsf-impl-1.2_15-jbossorg-2.jar Attachment: Added: jsf-impl-1.2_15-jbossorg-2-sources.jar I've rebuilt the jars, I'm seeing if Stan can upload them to the maven repo. 70faa4230a41b50ce85f4a1ea9b1e1d4 jsf-api-1.2_15-jbossorg-2.jar 1b6156a20b77dae7b97e68d0f5b2417d jsf-api-1.2_15-jbossorg-2-sources.jar f5b2d187aa2c4fc2d9f26c41bddf5a6f jsf-impl-1.2_15-jbossorg-2.jar 36a214e269313d927b66c68164e3ae15 jsf-impl-1.2_15-jbossorg-2-sources.jar Brad, do you consider this one fixed? Still broken in DR06 release, can this be scheduled into DR7? Bugzilla References: Removed: https://bugzilla.redhat.com/show_bug.cgi?id=744854 Added: https://bugzilla.redhat.com/show_bug.cgi?id=744854 >Brad, do you consider this one fixed?
Yes, this change has passed for EAP 5.1.2, and I tested the jars attached in an AS 7.1 Alpha2 build with a richfaces demo and all was well.
On testing example applications with EAP6 DR8 I have got the same exception. It seems still broken. This would be a nice to fix for the Alpha2 release based on DR10. Hence scheduling. Looks like the fix is already available upstream? Bugzilla References: Removed: https://bugzilla.redhat.com/show_bug.cgi?id=744854 Added: https://bugzilla.redhat.com/show_bug.cgi?id=744854 Bugzilla Update: Added: Perform Bugzilla References: Removed: https://bugzilla.redhat.com/show_bug.cgi?id=744854 Added: https://bugzilla.redhat.com/show_bug.cgi?id=744854 Bugzilla References: Removed: https://bugzilla.redhat.com/show_bug.cgi?id=744854 Added: https://bugzilla.redhat.com/show_bug.cgi?id=744854 Bugzilla References: Removed: https://bugzilla.redhat.com/show_bug.cgi?id=744854 Added: https://bugzilla.redhat.com/show_bug.cgi?id=744854 So, did it work by replacing the JSF JAR ? We are using the -redhat-1 version of the JAR now, which as all the patches that -jbossorg-2 has (pcheung has verified that). Marek Novotny <mnovotny> changed the Status of [bug 744854|https://bugzilla.redhat.com/show_bug.cgi?id=744854] from NEW to ON_QA JBoss JIRA Server <jira-update> made a comment on [bug 744854|https://bugzilla.redhat.com/show_bug.cgi?id=744854] Fernando Nasser <fnasser> made a comment on jira JBPAPP-7346 So, did it work by replacing the JSF JAR ? JBoss JIRA Server <jira-update> made a comment on [bug 744854|https://bugzilla.redhat.com/show_bug.cgi?id=744854] Fernando Nasser <fnasser> updated the status of jira JBPAPP-7346 to Resolved JBoss JIRA Server <jira-update> made a comment on [bug 744854|https://bugzilla.redhat.com/show_bug.cgi?id=744854] Fernando Nasser <fnasser> made a comment on jira JBPAPP-7346 We are using the -redhat-1 version of the JAR now, which as all the patches that -jbossorg-2 has (pcheung has verified that). Marek Novotny <mnovotny> made a comment on [bug 744854|https://bugzilla.redhat.com/show_bug.cgi?id=744854] Please, verify the issue for the latest release of EAP6 DR12 Karel Piwko <kpiwko> changed the Status of [bug 744854|https://bugzilla.redhat.com/show_bug.cgi?id=744854] from ON_QA to VERIFIED Karel Piwko <kpiwko> made a comment on [bug 744854|https://bugzilla.redhat.com/show_bug.cgi?id=744854] Verified with ER2. Verified with ER2. Docs QE Status: Removed: NEW Fixing Affects and Fix in Version |