Bug 899790 (JBPAPP6-1625)
| Summary: | CLONE - jython-standalone-2.5.2.jar contains jline classes, also contained in jline module | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Rostislav Svoboda <rsvoboda> | ||||
| Component: | unspecified | Assignee: | David Walluck <dwalluck> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | unspecified | CC: | dwalluck | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | http://jira.jboss.org/jira/browse/JBPAPP6-1625 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-05-04 19:07:26 UTC | Type: | Task | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 900190 | ||||||
| Attachments: |
|
||||||
|
Description
Rostislav Svoboda
2012-02-01 14:13:40 UTC
Link: Added: This issue Cloned from AS7-3389 Workflow: Removed: GIT Pull Request workflow Added: jira Security: Added: Public Docs QE Status: Added: NEW The repackaging of JLine classes is now documented in the community wiki: https://community.jboss.org/wiki/AS7DependenciesWithRepackagedClasses When checking this I noticed a lot of differences between the upstream Jython jar and our product build. David, can you review this build, and if you remove the JLine classes, or make other changes from upstream, just add a note to the EAP wiki: https://docspace.corp.redhat.com/docs/DOC-87781 Attachment: Added: jython-diff-jars.txt This jar violates productization practices by bundling third-party libraries. Moreover, it does not shade or relocate most classes. Certainly, it may duplicate libraries already included in EAP. Differences from upstream include harmless directory entries and extra classes (because the versions are different). Not included are com/ziclix/python/sql/handler/InformixDataHandler.class and com/ziclix/python/sql/handler/OracleDataHandler.class (proprietary), jffi native libs for Windows, etc., and jnr-netdb (no apparent code dependency here). I would need to check the inclusion of LICENSE.txt which is likely not from jython itself, and some patch backup files that are not filtered from inclusion (apparent bugs in the upstream build process). I tend to think that we should remove all of these dependencies and add them to the POM, but I don't know the effect that this will have on the AS. It's possible that all of these extra classes are not necessary. Details for ER1: http://hudson.qa.jboss.com/hudson/view/EAP6/view/EAP6-Miscellaneous/job/eap-60-tattletale/javadoc/multiplejars/index.html It depends how jython is used. For jline specifically, this should not be neede din on-interactive mode. But, the goal is to remove all third-party jars. Parent: Added: JBPAPP-8684 This will be fixed as part of JBPAPP-8684 Docs QE Status: Removed: NEW |