Bug 900033 (JBPAPP6-1621) - Specification / Implementation version in manifest doesn't reflect jar version, sometimes present multiple times or not present at all
Summary: Specification / Implementation version in manifest doesn't reflect jar versio...
Keywords:
Status: CLOSED EOL
Alias: JBPAPP6-1621
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Build
Version: 6.0.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ER2
: EAP 6.3.0
Assignee: Petr Sakař
QA Contact: Nikoleta Hlavickova
URL: http://jira.jboss.org/jira/browse/JBP...
Whiteboard:
Depends On: 960263
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-03-13 09:13 UTC by Rostislav Svoboda
Modified: 2019-08-19 12:48 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-19 12:48:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 927238 0 unspecified CLOSED Missing or invalid Implementation-Version item in META-INF/MANIFEST.MF 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1158428 0 unspecified CLOSED Missing specification version in manifest: hibernate jars 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1158429 0 unspecified CLOSED Missing specification and implementation version in manifest: resteasy jars 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1158430 0 unspecified CLOSED Missing specification version in manifest: ironjacamar jars 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1158438 0 unspecified CLOSED Missing specification version in manifest: jackson jars 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1158440 0 unspecified CLOSED Missing specification and implementation version in manifest: jbosstxbridge jars 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1158446 0 unspecified CLOSED Missing specification and implementation version in manifest: async-http-servlet jar 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1158447 0 unspecified CLOSED Missing specification version in manifest: asm jar 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1158449 0 unspecified CLOSED Missing specification version in manifest: jacorb jar 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1158450 0 unspecified CLOSED Missing specification version in manifest: jbossjts-integration jar 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1190664 0 unspecified CLOSED Implementation-version in the Manifest does not correspond to the JAR version - weld 2021-02-22 00:41:40 UTC
Red Hat Issue Tracker JBPAPP6-1621 0 Minor Closed Specification / Implementation version in manifest doesn't reflect jar version, sometimes present multiple times or not ... 2018-07-23 14:39:14 UTC


Description Rostislav Svoboda 2012-03-13 09:13:32 UTC
project_key: JBPAPP6

- jar version is not reflected in manifest
For example:
 ironjacamar-*jar
 jackson-*.jar

- multiple Specification / Implementation Version
For example:
 xercesImpl-2.9.1-redhat-1.jar
 xalan-2.7.1-redhat-1.jar
 serializer-2.7.1-redhat-1.jar


- Specification / Implementation Version not present at all
For example:
 cal10n-api-0.7.3-redhat-1-sources.jar
 jython-standalone-2.5.2-redhat-1.jar
 org.apache.felix.configadmin-1.2.8-redhat-1.jar
 jbossxts-*.jar

More details in http://hudson.qa.jboss.com/hudson/view/EAP6/view/EAP6-Repository/job/eap-60-repository-maven-check-manifest/lastSuccessfulBuild/artifact/test-output.txt

Comment 1 Fernando Nasser 2012-05-08 19:45:33 UTC
I ignored the ones missing just in the -sources.jar, and the ones in -todo versions and the ones that were osgi CRs  (and Bundle-Version is a legal Version)  and came up with a wish list of 23 rebuilds in:

http://ett.usersys.redhat.com/brew_tags/eap6-manifest-versions/packages

Most are third-party projects, but there are some JBoss projects as well, that did not care about filling the version in the MANIFEST.MF

Of course we cannot rebuild 23 packages at this stage, too risky, so we are moving this to EAP 6 Optional and will try and see if it is possible to fix these builds by patching whenever possible. 

Comment 2 Rostislav Svoboda 2012-05-21 08:24:25 UTC
Problematic jars for EAP 6.0.0 ER8

- jboss-eap-6.0.0.ER8-maven-repository/log4j/log4j/1.2.16-redhat-1/log4j-1.2.16-redhat-1.jar
- jboss-eap-6.0.0.ER8-maven-repository/org/jdom/jdom/1.1.2-redhat-1/jdom-1.1.2-redhat-1.jar
- jboss-eap-6.0.0.ER8-maven-repository/xalan/xalan/2.7.1-redhat-1/xalan-2.7.1-redhat-1-sources.jar
- jboss-eap-6.0.0.ER8-maven-repository/xalan/xalan/2.7.1-redhat-1/xalan-2.7.1-redhat-1.jar
- jboss-eap-6.0.0.ER8-maven-repository/xalan/serializer/2.7.1-redhat-1/serializer-2.7.1-redhat-1-sources.jar
- jboss-eap-6.0.0.ER8-maven-repository/xerces/xercesImpl/2.9.1-redhat-1/xercesImpl-2.9.1-redhat-1.jar
- jboss-eap-6.0.0.ER8-maven-repository/xom/xom/1.2.7-redhat-1/xom-1.2.7-redhat-1.jar


http://hudson.qa.jboss.com/hudson/view/EAP6/view/EAP6-Repository/job/eap-60-repository-maven-check-manifest/8/artifact/test-output.txt

Comment 3 Rostislav Svoboda 2012-06-01 11:15:29 UTC
The same list as for ER8 applies for CR1

Comment 4 Fernando Nasser 2012-06-01 15:25:57 UTC
Thanks.  The list in http://ett.usersys.redhat.com/brew_tags/eap6-manifest-versions/packages  is still correct then.

Need to be scheduled for fixing after GA.  Needs triage.

Comment 5 Rostislav Svoboda 2012-09-21 11:20:24 UTC
EAP 601 ER2:

Duplicated version info:
* jboss-eap-6.0.1.ER2-maven-repository/xerces/xercesImpl/2.9.1-redhat-3/xercesImpl-2.9.1-redhat-3.jar
* jboss-eap-6.0.1.ER2-maven-repository/xalan/xalan/2.7.1-redhat-3/xalan-2.7.1-redhat-3-sources.jar
* jboss-eap-6.0.1.ER2-maven-repository/xalan/xalan/2.7.1-redhat-3/xalan-2.7.1-redhat-3.jar
* jboss-eap-6.0.1.ER2-maven-repository/xalan/serializer/2.7.1-redhat-3/serializer-2.7.1-redhat-3-sources.jar
* jboss-eap-6.0.1.ER2-maven-repository/xalan/serializer/2.7.1-redhat-3/serializer-2.7.1-redhat-3.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jdom/jdom/1.1.2-redhat-2/jdom-1.1.2-redhat-2.jar


Missing version info:
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbosstxbridge/4.16.4.Final-redhat-2/jbosstxbridge-4.16.4.Final-redhat-2-sources.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbosstxbridge/4.16.4.Final-redhat-2/jbosstxbridge-4.16.4.Final-redhat-2.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbossjts-integration/4.16.4.Final-redhat-2/jbossjts-integration-4.16.4.Final-redhat-2.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbossjts-integration/4.16.4.Final-redhat-2/jbossjts-integration-4.16.4.Final-redhat-2-sources.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbossjts/4.16.4.Final-redhat-2/jbossjts-4.16.4.Final-redhat-2-sources.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbossjts/4.16.4.Final-redhat-2/jbossjts-4.16.4.Final-redhat-2.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbossxts-api/4.16.4.Final-redhat-2/jbossxts-api-4.16.4.Final-redhat-2.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbossxts-api/4.16.4.Final-redhat-2/jbossxts-api-4.16.4.Final-redhat-2-sources.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbossxts/4.16.4.Final-redhat-2/jbossxts-4.16.4.Final-redhat-2-sources.jar
* jboss-eap-6.0.1.ER2-maven-repository/org/jboss/jbossts/jbossxts/4.16.4.Final-redhat-2/jbossxts-4.16.4.Final-redhat-2.jar

http://hudson.qa.jboss.com/hudson/view/EAP6/view/EAP6-Repository/job/eap-60-repository-maven-check-manifest/11/artifact/test-output.txt

Comment 7 Fernando Nasser 2012-11-13 23:08:52 UTC
Docs QE Status: Removed: NEW 


Comment 9 Fernando Nasser 2012-12-03 15:33:53 UTC
Hi Rostislav, can you please check if the list in http://ett.usersys.redhat.com/brew_tags/eap6-manifest-versions/packages is still accurate?

After the release we'll go after the leads of any JBoss project in there and contact the ones where we have JBoss committers to try and get upstream fixes for this.

Thanks!

Comment 10 Rostislav Svoboda 2012-12-04 09:20:43 UTC
Hi Fernando, I went through the list and here is feedback:
{code}
antlr-eap6 		Open 	- 	FIX NEEDED
apache-cxf-xjc-utils 	Open 	- 	NOT IN REPORT
atinject 		Open 	- 	FIX NEEDED - javax/inject/javax.inject/1-redhat-2
gnu-getopt	 	Open 	- 	FIX NEEDED
h2database 		Open 	- 	FIX NEEDED
hibernate4 		Open 	- 	VERSION FIXED
jacorb-jboss 		Open 	- 	VERSION FIXED
javassist-eap6	 	Open 	- 	VERSION FIXED
jcip-annotations 	Open 	- 	FIX NEEDED
jdom-eap6 		Open 	- 	FIX NEEDED
jline-eap6 		Open 	- 	VERSION FIXED
jython-eap6 		Open 	- 	VERSION FIXED
log4j-eap6 		Open 	- 	VERSION FIXED
netty 			Open 	- 	VERSION FIXED
relaxngDatatype 	Open 	- 	FIX NEEDED
rhq-pluginAnnotations 	Open 	- 	VERSION FIXED
ws-commons-neethi 	Open 	- 	VERSION FIXED
ws-commons-XmlSchema 	Open 	- 	VERSION FIXED
wss4j		 	Open 	- 	VERSION FIXED
xalan-j2-eap6 		Open 	- 	FIX NEEDED
xerces-j2-eap6	 	Open 	- 	FIX NEEDED
xml-commons-resolver 	Open 	- 	FIX NEEDED
jboss-as-console 	Compl 	- 	VERSION FIXED
jbossweb 		Compl 	- 	FIX NEEDED - jbossweb-7.0.17.Final-redhat-1.jar, jasper-jdt-7.0.17.Final-redhat-1.jar
{code}

I noticed there are *artifacts which are NOT included in the list* - 10 org/jboss/jbossts jars - 5 x jar + 5 x sources.jar

Comment 12 Rostislav Svoboda 2013-03-08 09:05:42 UTC
EAP 6.1.0 ER2 results - https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/EAP6/view/EAP6-Repository/job/eap-60-repository-maven-check-manifest/21/artifact/test-output.txt

I haven't notice any progress in this area since EAP 6.0.1.

Comment 16 Rostislav Svoboda 2013-05-06 14:07:47 UTC
EAP 6.1.0 ER6
https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/EAP6/view/EAP6-Repository/job/eap-60-repository-maven-check-manifest/26/artifact/test-output.txt

No Implementation-Version:
-- jboss-eap-6.1.0.GA-maven-repository/com/h2database/h2/1.3.168-redhat-2/h2-1.3.168-redhat-2-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/antlr/antlr/2.7.7-redhat-2/antlr-2.7.7-redhat-2.jar
-- jboss-eap-6.1.0.GA-maven-repository/net/jcip/jcip-annotations/1.0-redhat-3/jcip-annotations-1.0-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/xml-resolver/xml-resolver/1.2-redhat-3/xml-resolver-1.2-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/gnu-getopt/getopt/1.0.13-redhat-2/getopt-1.0.13-redhat-2.jar
-- jboss-eap-6.1.0.GA-maven-repository/javax/inject/javax.inject/1-redhat-3/javax.inject-1-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/javax/inject/javax.inject/1-redhat-3/javax.inject-1-redhat-3-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/wsdl4j/wsdl4j/1.6.2-redhat-4/wsdl4j-1.6.2-redhat-4-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/hibernate/hibernate-entitymanager/4.2.0.Final-redhat-1/hibernate-entitymanager-4.2.0.Final-redhat-1-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/hibernate/hibernate-envers/4.2.0.Final-redhat-1/hibernate-envers-4.2.0.Final-redhat-1-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/osgi/org.osgi.enterprise/4.2.0-redhat-3/org.osgi.enterprise-4.2.0-redhat-3-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/osgi/org.osgi.enterprise/4.2.0-redhat-3/org.osgi.enterprise-4.2.0-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/osgi/org.osgi.core/4.2.0-redhat-3/org.osgi.core-4.2.0-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/osgi/org.osgi.core/4.2.0-redhat-3/org.osgi.core-4.2.0-redhat-3-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/codehaus/woodstox/woodstox-core-asl/4.2.0-redhat-1/woodstox-core-asl-4.2.0-redhat-1-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/codehaus/woodstox/stax2-api/3.1.1-redhat-2/stax2-api-3.1.1-redhat-2-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/codehaus/jackson/jackson-mapper-asl/1.9.9-redhat-2/jackson-mapper-asl-1.9.9-redhat-2-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/codehaus/jackson/jackson-xc/1.9.9-redhat-2/jackson-xc-1.9.9-redhat-2-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/codehaus/jackson/jackson-jaxrs/1.9.9-redhat-2/jackson-jaxrs-1.9.9-redhat-2-sources.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/codehaus/jackson/jackson-core-asl/1.9.9-redhat-2/jackson-core-asl-1.9.9-redhat-2-sources.jar


Multiple but incorrect Implementation-Version:
-- jboss-eap-6.1.0.GA-maven-repository/xom/xom/1.2.7-redhat-3/xom-1.2.7-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/opensaml/xmltooling/1.3.2-redhat-2/xmltooling-1.3.2-redhat-2.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/opensaml/xmltooling/1.3.2-redhat-4/xmltooling-1.3.2-redhat-4.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/opensaml/opensaml/2.5.1-redhat-1/opensaml-2.5.1-redhat-1.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/opensaml/openws/1.4.2-redhat-2/openws-1.4.2-redhat-2.jar
 These manifests should look like jboss-eap-6.1.0.GA-maven-repository/xalan/xalan/2.7.1-redhat-3/xalan-2.7.1-redhat-3.jar for example.

Comment 17 Fernando Nasser 2013-05-06 19:51:32 UTC
First list w/o source JARs:

-- jboss-eap-6.1.0.GA-maven-repository/antlr/antlr/2.7.7-redhat-2/antlr-2.7.7-redhat-2.jar
-- jboss-eap-6.1.0.GA-maven-repository/net/jcip/jcip-annotations/1.0-redhat-3/jcip-annotations-1.0-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/xml-resolver/xml-resolver/1.2-redhat-3/xml-resolver-1.2-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/gnu-getopt/getopt/1.0.13-redhat-2/getopt-1.0.13-redhat-2.jar
-- jboss-eap-6.1.0.GA-maven-repository/javax/inject/javax.inject/1-redhat-3/javax.inject-1-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/osgi/org.osgi.enterprise/4.2.0-redhat-3/org.osgi.enterprise-4.2.0-redhat-3.jar
-- jboss-eap-6.1.0.GA-maven-repository/org/osgi/org.osgi.core/4.2.0-redhat-3/org.osgi.core-4.2.0-redhat-3.jar

Comment 18 Fernando Nasser 2013-05-06 19:53:31 UTC
For xml-resolver see BZ#959965

Comment 19 Rostislav Svoboda 2013-05-13 08:48:54 UTC
The same results in EAP 6.1.0 ER8 as in ER6.

Comment 20 Fernando Nasser 2013-05-13 14:12:23 UTC
For jcip-annotations see BZ#960263

Comment 22 Fernando Nasser 2013-07-24 14:04:30 UTC
The vast majority (if not all) of these cases have been fixed.  If any is found in 6.1.1, please open a new bug so we can try and look into them for 6.2.0.  Thanks.

Comment 23 Nikoleta Hlavickova 2013-08-05 11:22:09 UTC
These issues does not seem fixed in EAP 6.1.1 ER4:
https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/EAP6/view/EAP6-Repository/job/eap-60-repository-maven-check-manifest/36/artifact/test-output.txt

Lists without *-sources.jar files:

No Implementation-Version:
jboss-eap-6.1.1.GA-maven-repository/net/jcip/jcip-annotations/1.0-redhat-3/jcip-annotations-1.0-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/net/jcip/jcip-annotations/1.0-redhat-4/jcip-annotations-1.0-redhat-4.jar
jboss-eap-6.1.1.GA-maven-repository/javax/inject/javax.inject/1-redhat-3/javax.inject-1-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/antlr/antlr/2.7.7-redhat-2/antlr-2.7.7-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/osgi/org.osgi.core/4.2.0-redhat-3/org.osgi.core-4.2.0-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/org/osgi/org.osgi.enterprise/4.2.0-redhat-3/org.osgi.enterprise-4.2.0-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/gnu-getopt/getopt/1.0.13-redhat-2/getopt-1.0.13-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/xml-resolver/xml-resolver/1.2-redhat-3/xml-resolver-1.2-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/xml-resolver/xml-resolver/1.2-redhat-2/xml-resolver-1.2-redhat-2.jar

Multiple Implementation-Version:
jboss-eap-6.1.1.GA-maven-repository/xom/xom/1.2.7-redhat-3/xom-1.2.7-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/org/jdom/jdom/1.1.2-redhat-2/jdom-1.1.2-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/openws/1.4.2-redhat-2/openws-1.4.2-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/openws/1.4.2-redhat-3/openws-1.4.2-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/opensaml/2.5.1-redhat-1/opensaml-2.5.1-redhat-1.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/xmltooling/1.3.2-redhat-4/xmltooling-1.3.2-redhat-4.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/xmltooling/1.3.2-redhat-2/xmltooling-1.3.2-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/xerces/xercesImpl/2.9.1-redhat-4/xercesImpl-2.9.1-redhat-4.jar
jboss-eap-6.1.1.GA-maven-repository/xalan/serializer/2.7.1-redhat-3/serializer-2.7.1-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/xalan/xalan/2.7.1-redhat-3/xalan-2.7.1-redhat-3.jar

No Specification-Version:
jboss-eap-6.1.1.GA-maven-repository/asm/asm/3.3.1-redhat-4/asm-3.3.1-redhat-4.jar
jboss-eap-6.1.1.GA-maven-repository/net/jcip/jcip-annotations/1.0-redhat-3/jcip-annotations-1.0-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/net/jcip/jcip-annotations/1.0-redhat-4/jcip-annotations-1.0-redhat-4.jar
jboss-eap-6.1.1.GA-maven-repository/javax/inject/javax.inject/1-redhat-3/javax.inject-1-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/antlr/antlr/2.7.7-redhat-2/antlr-2.7.7-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/jacorb/jacorb/2.3.2-redhat-4/jacorb-2.3.2-redhat-4.jar
jboss-eap-6.1.1.GA-maven-repository/org/osgi/org.osgi.core/4.2.0-redhat-3/org.osgi.core-4.2.0-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/org/osgi/org.osgi.enterprise/4.2.0-redhat-3/org.osgi.enterprise-4.2.0-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/org/hibernate/hibernate-core/4.2.0.SP1-redhat-1/hibernate-core-4.2.0.SP1-redhat-1.jar
jboss-eap-6.1.1.GA-maven-repository/org/hibernate/hibernate-entitymanager/4.2.0.SP1-redhat-1/hibernate-entitymanager-4.2.0.SP1-redhat-1.jar
jboss-eap-6.1.1.GA-maven-repository/org/hibernate/hibernate-infinispan/4.2.0.SP1-redhat-1/hibernate-infinispan-4.2.0.SP1-redhat-1.jar
jboss-eap-6.1.1.GA-maven-repository/org/hibernate/hibernate-envers/4.2.0.SP1-redhat-1/hibernate-envers-4.2.0.SP1-redhat-1.jar
jboss-eap-6.1.1.GA-maven-repository/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.19.Final-redhat-2/ironjacamar-deployers-common-1.0.19.Final-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/jboss/ironjacamar/ironjacamar-core-api/1.0.19.Final-redhat-2/ironjacamar-core-api-1.0.19.Final-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/jboss/ironjacamar/ironjacamar-common-impl/1.0.19.Final-redhat-2/ironjacamar-common-impl-1.0.19.Final-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/jboss/ironjacamar/ironjacamar-spec-api/1.0.19.Final-redhat-2/ironjacamar-spec-api-1.0.19.Final-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/jboss/ironjacamar/ironjacamar-jdbc/1.0.19.Final-redhat-2/ironjacamar-jdbc-1.0.19.Final-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/jboss/ironjacamar/ironjacamar-common-spi/1.0.19.Final-redhat-2/ironjacamar-common-spi-1.0.19.Final-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/jboss/ironjacamar/ironjacamar-common-api/1.0.19.Final-redhat-2/ironjacamar-common-api-1.0.19.Final-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/jboss/ironjacamar/ironjacamar-core-impl/1.0.19.Final-redhat-2/ironjacamar-core-impl-1.0.19.Final-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/jboss/ironjacamar/ironjacamar-validator/1.0.19.Final-redhat-2/ironjacamar-validator-1.0.19.Final-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/apache/velocity/velocity/1.7-redhat-2/velocity-1.7-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/codehaus/jackson/jackson-jaxrs/1.9.9-redhat-2/jackson-jaxrs-1.9.9-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/codehaus/jackson/jackson-mapper-asl/1.9.9-redhat-2/jackson-mapper-asl-1.9.9-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/codehaus/jackson/jackson-xc/1.9.9-redhat-2/jackson-xc-1.9.9-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/gnu-getopt/getopt/1.0.13-redhat-2/getopt-1.0.13-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/com/h2database/h2/1.3.168-redhat-2/h2-1.3.168-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/xml-resolver/xml-resolver/1.2-redhat-3/xml-resolver-1.2-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/xml-resolver/xml-resolver/1.2-redhat-2/xml-resolver-1.2-redhat-2.jar

Multiple Specification-Version:
jboss-eap-6.1.1.GA-maven-repository/org/jdom/jdom/1.1.2-redhat-2/jdom-1.1.2-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/openws/1.4.2-redhat-2/openws-1.4.2-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/openws/1.4.2-redhat-3/openws-1.4.2-redhat-3.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/opensaml/2.5.1-redhat-1/opensaml-2.5.1-redhat-1.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/xmltooling/1.3.2-redhat-4/xmltooling-1.3.2-redhat-4.jar
jboss-eap-6.1.1.GA-maven-repository/org/opensaml/xmltooling/1.3.2-redhat-2/xmltooling-1.3.2-redhat-2.jar
jboss-eap-6.1.1.GA-maven-repository/xerces/xercesImpl/2.9.1-redhat-4/xercesImpl-2.9.1-redhat-4.jar
jboss-eap-6.1.1.GA-maven-repository/xalan/xalan/2.7.1-redhat-3/xalan-2.7.1-redhat-3.jar

Comment 25 Nikoleta Hlavickova 2013-10-17 11:07:29 UTC
Hi Fernando, 
I have checked this for EAP 6.2.0 ER6. There are still several issues left. 

Multiple Implementation-Version:
jdom-1.1.2-redhat-2.jar
serializer-2.7.1-redhat-3.jar
xalan-2.7.1-redhat-3.jar
xml-resolver-1.2.redhat-9.jar
xercesImpl-2.9.1-redhat-4.jar
xmltooling-1.3.4.redhat-1.jar
openws-1.4.4.redhat-2.jar
opensaml-2.5.3.redhat-2.jar
xom-1.2.7-redhat-3.jar

Multiple Specification-Version:
jdom-1.1.2-redhat-2.jar
xalan-2.7.1-redhat-3.jar
xercesImpl-2.9.1-redhat-4.jar
xmltooling-1.3.4.redhat-1.jar
openws-1.4.4.redhat-2.jar
opensaml-2.5.3.redhat-2.jar

Missing Implementation-Version:
-

Missing Specification-Version:
jackson-xc-1.9.9-redhat-2.jar
jackson-mapper-asl-1.9.9-redhat-2.jar
jackson-jaxrs-1.9.9-redhat-2.jar
ironjacamar-jdbc-1.0.21.Final-redhat-1.jar
ironjacamar-validator-1.0.21.Final-redhat-1.jar
ironjacamar-core-impl-1.0.21.Final-redhat-1.jar
ironjacamar-deployers-common-1.0.21.Final-redhat-1.jar
ironjacamar-common-impl-1.0.21.Final-redhat-1.jar
ironjacamar-core-api-1.0.21.Final-redhat-1.jar
ironjacamar-common-api-1.0.21.Final-redhat-1.jar
ironjacamar-common-spi-1.0.21.Final-redhat-1.jar
jacorb-2.3.2-redhat-4.jar
velocity-1.7-redhat-2.jar
hibernate-envers-4.2.6.Final-redhat-1.jar
hibernate-core-4.2.6.Final-redhat-1.jar
hibernate-infinispan-4.2.6.Final-redhat-1.jar
hibernate-entitymanager-4.2.6.Final-redhat-1.jar
h2-1.3.168-redhat-2.jar
asm-3.3.1-redhat-4.jar

See https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/EAP6/view/EAP6-Repository/job/eap-60-as-check-manifest/62/artifact/test-output.txt

Comment 26 David Walluck 2013-10-17 14:54:47 UTC
(In reply to Nikoleta Ziakova from comment #25)
> Multiple Implementation-Version:

Having more than one header with the same name is legal as they are unique per section. You need to update your test to take this into account. It would seem to me that you only want to check the main section, as the subsections could potentially use a separate version number.

Comment 27 David Walluck 2013-10-17 15:16:59 UTC
In the serializer jar, there are no versions listed in the main (unnamed) section, but there are version listed in each of its two subsections. One of the sections has only an Implementation-Version and not a Specification-Version. But notice, too, that the Specification-Version is 1.0 and not 2.7.1-redhat-3. This is because in an actual API these generally wouldn't be auto-added by Maven and are instead hardcoded by upstream. Thus, I wonder about the utility of adding extra ones which are just set to ${pom.version}.

Manifest-Version: 1.0^M
Ant-Version: Apache Ant 1.8.4-redhat-1^M
Created-By: 1.6.0_24 (Sun Microsystems Inc.)^M
Main-Class: org.apache.xml.serializer.Version^M
Class-Path: xml-apis.jar^M
^M
Name: org/apache/xml/serializer/^M
Comment: Serializer to write out XML, HTML etc. as a stream of charact^M
 ers from an input DOM or from input SAX events.^M
Specification-Title: XSL Transformations (XSLT), at http://www.w3.org/^M
 TR/xslt^M
Specification-Vendor: W3C Recommendation 16 November 1999^M
Specification-Version: 1.0^M
Implementation-Title: org.apache.xml.serializer^M
Implementation-Version: 2.7.1-redhat-3^M
Implementation-Vendor: Apache Software Foundation^M
Implementation-URL: http://xml.apache.org/xalan-j/usagepatterns.html^M
^M
Name: org/apache/xml/serializer/utils/^M
Comment: Utilities used internally by the Serializer. Not for external^M
  use.^M
Implementation-Title: org.apache.xml.serializer.utils^M
Implementation-Version: 2.7.1-redhat-3^M
Implementation-Vendor: Apache Software Foundation^M
^M

Comment 28 Rostislav Svoboda 2013-10-18 12:49:25 UTC
> Thus, I wonder about the utility of adding extra ones which are just set to ${pom.version}.

this could work

Comment 29 Fernando Nasser 2013-10-18 13:38:23 UTC
Hi Rosta, what do you mean by "this could work"?

Adding a Specification-Version for something that does not define a supported API and assign an API version number would be plainly wrong -- a lie of a sort.  We'd be introducing an erroneous informaton.

You should only check for Specification-Version for thins like JSF (1.2 or 2.1), ws-metadata, things like that.  You'd need to have a list of APIs to check Specification-Version in just those.

Furthermore, the build process generally does not introduce or remove these versions from the MANIFEST.MF, these are set by the upstream developers to what they think the values should be. Changing these is like changing the code: a fork.  If we think they are wrong we need individual BZs and file upstream bugs that can be referenced from those BZs.

Ironjacamar, Hibernate and even JacORB are under Red Hat people though.  If you file a Bug for each of those components we can assign to our own people so they can fix in their source tree.

Comment 30 Nikoleta Hlavickova 2013-10-21 12:40:36 UTC
(In reply to David Walluck from comment #26)
> Having more than one header with the same name is legal as they are unique
> per section. You need to update your test to take this into account. It
> would seem to me that you only want to check the main section, as the
> subsections could potentially use a separate version number.

I have checked the main section in jars that have multiple specification and/or implementation version. Some of these are correct:
xml-resolver-1.2.redhat-9.jar
xmltooling-1.3.4.redhat-1.jar
openws-1.4.4.redhat-2.jar
opensaml-2.5.3.redhat-2.jar
xom-1.2.7-redhat-3.jar

Missing Specification-Version and/or Implementation-Version in the main section:
jdom-1.1.2-redhat-2.jar
serializer-2.7.1-redhat-3.jar
xalan-2.7.1-redhat-3.jar
xercesImpl-2.9.1-redhat-4.jar

Comment 31 Rostislav Svoboda 2013-10-21 14:22:41 UTC
(In reply to Fernando Nasser from comment #29)
> Hi Rosta, what do you mean by "this could work"?

I was expecting this tool to check if Implementation-Version is present. If not then it would add line referring to -redhat- version, e.g. Implementation-Version: 2.7.1-redhat-3.

> Adding a Specification-Version for something that does not define a
> supported API and assign an API version number would be plainly wrong -- a
> lie of a sort.  We'd be introducing an erroneous informaton.

No changes to Specification-Version.

> Furthermore, the build process generally does not introduce or remove these
> versions from the MANIFEST.MF, these are set by the upstream developers to
> what they think the values should be. Changing these is like changing the
> code: a fork.  If we think they are wrong we need individual BZs and file
> upstream bugs that can be referenced from those BZs.

I think we can add/modify Implementation-Version to reflect RH based version. 
David's proposal for utility for adding/modifying Implementation-Version would be great - I like automated tools. And we would have all our jars "RedHat branded".

Comment 32 David Walluck 2014-03-21 22:02:45 UTC
New builds intended for EAP 6.3 have been produced for the four jars mentioned in comment #30, if you can please recheck them:

jdom-1.1.2.redhat-4.jar
serializer-2.7.1.redhat-5.jar
xalan-2.7.1.redhat-5.jar
xercesImpl-2.9.1-redhat-5.jar

Comment 33 Kabir Khan 2014-04-08 14:32:13 UTC
https://github.com/jbossas/jboss-eap/pull/1189

Comment 34 Nikoleta Hlavickova 2014-04-22 13:11:09 UTC
Jars in comment #32 are OK.
There are some new failures:

Missing both Implementation-Version and Specification-Version:
org/jboss/resteasy/**
  resteasy-atom-provider-2.3.8.Final-redhat-3.jar
  resteasy-jaxb-provider-2.3.8.Final-redhat-3.jar
  resteasy-jackson-provider-2.3.8.Final-redhat-3.jar
  async-http-servlet-3.0-2.3.8.Final-redhat-3.jar
  resteasy-jaxrs-2.3.8.Final-redhat-3.jar
  resteasy-hibernatevalidator-provider-2.3.8.Final-redhat-3.jar
  resteasy-multipart-provider-2.3.8.Final-redhat-3.jar
  resteasy-cdi-2.3.8.Final-redhat-3.jar
  resteasy-jettison-provider-2.3.8.Final-redhat-3.jar
  resteasy-jsapi-2.3.8.Final-redhat-3.jar
  resteasy-spring.jar
  resteasy-yaml-provider-2.3.8.Final-redhat-3.jar

Missing Specification-Version:
org/hibernate/**
  hibernate-infinispan-4.2.12.Final-redhat-1.jar
  hibernate-entitymanager-4.2.12.Final-redhat-1.jar
  hibernate-core-4.2.12.Final-redhat-1.jar
  hibernate-envers-4.2.12.Final-redhat-1.jar

org/jboss/ironjacamar/**
  ironjacamar-jdbc-1.0.26.Final-redhat-1.jar
  ironjacamar-common-impl-1.0.26.Final-redhat-1.jar
  ironjacamar-validator-1.0.26.Final-redhat-1.jar
  ironjacamar-deployers-common-1.0.26.Final-redhat-1.jar
  ironjacamar-core-impl-1.0.26.Final-redhat-1.jar
  ironjacamar-core-api-1.0.26.Final-redhat-1.jar
  ironjacamar-common-api-1.0.26.Final-redhat-1.jar
  ironjacamar-common-spi-1.0.26.Final-redhat-1.jar

org/codehaus/jackson
  jackson-xc-1.9.9-redhat-2.jar
  jackson-mapper-asl-1.9.9-redhat-2.jar
  jackson-jaxrs-1.9.9-redhat-2.jar

Comment 35 Fernando Nasser 2014-10-27 13:06:06 UTC
Can you please split this in 4 BZs?  Each one has to be handled by a completely different person so it is impossible to coordinate with just one BZ.


Note You need to log in before you can comment on or make changes to this bug.