Bug 900455 (JBPAPP6-842)

Attached files contain the list of affected jars in both dist zip and maven repo zip.

Attachment: Added: digested-jars-eap-er8-dist
Attachment: Added: digested-jars-eap-er8-repo

The unsign script [1] had worked slowly but properly before the perl multiline regex was applied instead of the bash/sed routine [2]. The perl multiline regex works but not for every cases.

[1] http://git.app.eng.bos.redhat.com/?p=jboss-eap/maven-repository-testsuite.git;a=blob;f=src/scripts/unsign-mvn-repo;h=d3dc21dc9faeb57ef83e9b77ca888b6d1388a739;hb=570b91079ec978289a2a38057f6250972ead541e
[2] http://git.app.eng.bos.redhat.com/?p=jboss-eap/maven-repository-testsuite.git;a=commitdiff;h=5d87d7aa51784d89d66c46384716db413ce78193

The unsigning script is now fixed in [git|http://git.app.eng.bos.redhat.com/?p=jboss-eap/maven-repository-testsuite.git;a=commitdiff;h=e41f7a51fcb985be4a2650d4f8b12f193fd104cd].

The JBoss EAP distribution zip contains 5 jars containing Manifest file with some rest of digests:

{code}
./modules/nu/xom/main/xom-1.2.7-redhat-1.jar
./modules/org/apache/xalan/main/serializer-2.7.1-redhat-1.jar
./modules/org/apache/xalan/main/xalan-2.7.1-redhat-1.jar
./modules/org/apache/xerces/main/xercesImpl-2.9.1-redhat-1.jar
./modules/org/jdom/main/jdom-1.1.2-redhat-1.jar
{code}

And the Maven repository zip contains 7 jars containing Manifest file some rest of digests:
{code}
./org/jdom/jdom/1.1.2-redhat-1/jdom-1.1.2-redhat-1.jar
./xalan/serializer/2.7.1-redhat-1/serializer-2.7.1-redhat-1.jar
./xalan/serializer/2.7.1-redhat-1/serializer-2.7.1-redhat-1-sources.jar
./xalan/xalan/2.7.1-redhat-1/xalan-2.7.1-redhat-1.jar
./xalan/xalan/2.7.1-redhat-1/xalan-2.7.1-redhat-1-sources.jar
./xerces/xercesImpl/2.9.1-redhat-1/xercesImpl-2.9.1-redhat-1.jar
./xom/xom/1.2.7-redhat-1/xom-1.2.7-redhat-1.jar
{code}

For each of these remaining jars, all of the class file digests were removed.  However these jars contain directory specific configuration and it appears that the signing process added digest information for these directories.  The number of remaining digests is relatively small (<10) for each of these jars vs hundreds of entries in the original signed jar, so performance should be fine, but I'll look into whether we can reliably remove the remaining digests without affecting the valid directory configuration.

Added another perl regex to remove any remaining SHA1-Digest lines ([21e3ba41|http://git.app.eng.bos.redhat.com/?p=jboss-eap/maven-repository-testsuite.git;a=commitdiff;h=21e3ba419067d9cb04353acfe4a638828918b666]).

Vladimir, can you add your test script to the eap smoke tests?  It should be run against both the EAP zip and Maven repo zip.

The checking script added to [git repo|http://git.app.eng.bos.redhat.com/?p=jboss-eap/maven-repository-testsuite.git;a=commitdiff;h=8b9d6992dc822e8a71401b033187b58e106b87f8].

Usage:
{code}
check-digests jboss-eap-6.0 > eap-60-handoff-jars-with-digests-eap-dist.txt
check-digests jboss-eap-6.0.0.ERX-maven-repository > eap-60-handoff-jars-with-digests-maven-repo.txt
{code}

Created Jenkins job to check digests during smoke tests:
https://hudson.qa.jboss.com/hudson/job/eap-60-handoff-check-manifest-digests/

Added to the smoke tests trigger:
https://hudson.qa.jboss.com/hudson/view/EAP-CI/view/EAP6-CI/job/JBoss-EAP-6.0.x-smoke-test-trigger/

Link: Added: This issue depends JBPAPP-9121

Link: Removed: This issue depends JBPAPP-9121 

Link: Added: This issue is duplicated by JBPAPP-9135

Release Notes Docs Status: Added: Not Required

Verified on EAP 6.0.0 CR1.

ZIP files for EAP and maven repo do not contain jars with digests.

Release Notes Docs Status: Removed: Not Required 
Docs QE Status: Removed: NEW