Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 900491 (JBPAPP6-930)

Summary: Error message when deploying -service.xml doesn't list what component has the error
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: dereed
Component: Microcontainer and DeployersAssignee: Eduardo Martins <emartins.redhat>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0.0CC: brian.stansberry, dereed, emartins.redhat, jason.greene, rhatlapa, twells, vrastsel
Target Milestone: ---   
Target Release: EAP 6.0.1   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/JBPAPP6-930
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-20 08:44:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
test.ear none

Description dereed 2012-05-21 18:07:30 UTC
Help Desk Ticket Reference: https://c.na7.visual.force.com/apex/Case_View?id=500A000000927H4
project_key: JBPAPP6

Deploying an .ear that contains a -service.xml MBean (which worked in previous EAP releases, but is not supported in EAP 6) throws an error during deployment that doesn't contain any information on what component is causing the error.

Expected: a useful error message that tells that it was trying to deploy the -service.xml module, and got an error because it cannot deploy standalone .xml files.

Actual:
   - no mention of the actual component that caused the error (test-service.xml).  Only: children for EAR ["/content/test2.ear"]
   - only a vague error message "java.util.zip.ZipException: error in opening zip file"

12:58:39,259 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-7) JBAS015876: Starting deployment of "test2.ear"
12:58:39,269 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-7) MSC000001: Failed to start service jboss.deployment.unit."test2.ear".STRUCTURE: org.jboss.msc.service.StartException in service jboss.deployment.unit."test2.ear".STRUCTURE: JBAS018733: Failed to process phase STRUCTURE of deployment "test2.ear"
        at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:120) [jboss-as-server-7.1.1.Final-redhat-1.jar:7.1.1.Final-redhat-1]
        at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.2.GA-redhat-1.jar:1.0.2.GA-redhat-1]
        at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.2.GA-redhat-1.jar:1.0.2.GA-redhat-1]
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [rt.jar:1.6.0_24]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [rt.jar:1.6.0_24]
        at java.lang.Thread.run(Thread.java:662) [rt.jar:1.6.0_24]
Caused by: org.jboss.as.server.deployment.DeploymentUnitProcessingException: JBAS011060: Failed to process children for EAR ["/content/test2.ear"]
        at org.jboss.as.ee.structure.EarStructureProcessor.deploy(EarStructureProcessor.java:218)
        at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:114) [jboss-as-server-7.1.1.Final-redhat-1.jar:7.1.1.Final-redhat-1]
        ... 5 more
Caused by: java.util.zip.ZipException: error in opening zip file
        at java.util.zip.ZipFile.open(Native Method) [rt.jar:1.6.0_24]
        at java.util.zip.ZipFile.<init>(ZipFile.java:127) [rt.jar:1.6.0_24]
        at java.util.jar.JarFile.<init>(JarFile.java:135) [rt.jar:1.6.0_24]
        at java.util.jar.JarFile.<init>(JarFile.java:99) [rt.jar:1.6.0_24]
        at org.jboss.vfs.spi.JavaZipFileSystem.<init>(JavaZipFileSystem.java:97) [jboss-vfs-3.1.0.Final-redhat-1.jar:3.1.0.Final-redhat-1]
        at org.jboss.vfs.spi.JavaZipFileSystem.<init>(JavaZipFileSystem.java:83) [jboss-vfs-3.1.0.Final-redhat-1.jar:3.1.0.Final-redhat-1]
        at org.jboss.vfs.VFS.mountZip(VFS.java:408) [jboss-vfs-3.1.0.Final-redhat-1.jar:3.1.0.Final-redhat-1]
        at org.jboss.vfs.VFS.mountZip(VFS.java:434) [jboss-vfs-3.1.0.Final-redhat-1.jar:3.1.0.Final-redhat-1]
        at org.jboss.as.ee.structure.EarStructureProcessor.mount(EarStructureProcessor.java:223)
        at org.jboss.as.ee.structure.EarStructureProcessor.createResourceRoot(EarStructureProcessor.java:242)
        at org.jboss.as.ee.structure.EarStructureProcessor.deploy(EarStructureProcessor.java:176)
        ... 6 more

Comment 1 Jason Greene 2012-07-31 18:42:58 UTC
Hi Eduardo can you take a look at this?

Comment 2 Eduardo Martins 2012-08-01 10:49:38 UTC
sure

Comment 3 Eduardo Martins 2012-08-01 18:07:51 UTC
Dennis, are you able to attach the test ear you used?

Comment 4 Eduardo Martins 2012-08-02 15:20:47 UTC
I get no deployment error when bundling a test-service.xml in an EAR, without application.xml. Perhaps this is already fixed in 7.1 branch, or there is a specific EAR setup that raises the issue, waiting for Dennis clarification about the EAR used.

Comment 5 dereed 2012-08-02 16:36:00 UTC
Attachment: Added: test.ear


Comment 6 dereed 2012-08-02 16:37:46 UTC
Attached test.ear.
It contains just a test-service.xml, which it tries to deploy from jboss-app.xml (which worked in previous EAP versions but is no longer supported in EAP 6).

Note that the ear isn't valid, as application.xml must contain at least one module, but this one doesn't.
But it still triggers the issue this JIRA is about, so I didn't bother adding a dummy module to it.


Comment 7 Eduardo Martins 2012-08-03 08:26:02 UTC
Git Pull Request: Added: https://github.com/jbossas/jboss-as/pull/2791


Comment 8 Eduardo Martins 2012-08-03 10:12:56 UTC
The linked PR changes the behaviour of the deployer, there is no deployment error, instead it ignores any module which type is not supported, such as the legacy service, and display a warning log message.

Comment 9 Eduardo Martins 2012-08-07 10:11:47 UTC
After discussion with Kabir and Stuart, I'm changing PRs to throw error, instead of ignore.



Comment 10 Eduardo Martins 2012-08-10 11:10:48 UTC
PRs merged by Brian

Comment 11 Vladimir Rastseluev 2012-09-26 15:37:49 UTC
Verified on EAP 6.0.1 ER2

Comment 12 Tom WELLS 2012-11-05 05:46:19 UTC
Updated release notes fields

Comment 13 Tom WELLS 2012-11-05 05:46:19 UTC
Release Notes Docs Status: Added: Not Yet Documented
Writer: Added: sgilda


Comment 14 Anne-Louise Tangring 2012-11-13 20:07:50 UTC
Release Notes Docs Status: Removed: Not Yet Documented 
Writer: Removed: sgilda 
Docs QE Status: Removed: NEW 


Comment 15 Radim Hatlapatka 2012-11-20 08:44:24 UTC
Verified for eap 6.0.1-ER3