Bug 900752 (JBPAPP6-1099)
| Summary: | EAP 6 RPM - /etc/init.d/jbossas-domain script should allow a host config file to specified | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Farah Juma <fjuma> | ||||||||
| Component: | Build | Assignee: | Permaine Cheung <pcheung> | ||||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | |||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 6.0.0 | CC: | dpospisi, fjuma, pcheung | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | EAP 6.0.1 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| URL: | http://jira.jboss.org/jira/browse/JBPAPP6-1099 | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2012-11-20 10:56:22 UTC | Type: | Feature Request | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Farah Juma
2012-08-01 18:56:06 UTC
I've attached a patch for /etc/init.d/jbossas-domain that allows a host config file to be specified via a new JBOSS_HOST_CONFIG variable in /etc/sysconfig/jbossas-domain. For example, a user could specify the following in /etc/sysconfig/jbossas-domain: JBOSS_HOST_CONFIG="host-slave.xml" Attachment: Added: init.d-jbossas-domain.patch Attachment: Added: sysconfig-jbossas-domain.patch Thanks for the patch Farah, will put this in 6.0.1. Fix committed, will be in EAP 6.0.1 ER2. Permaine, when testing the jbossas-domain init script with ER2, I noticed that the "CMD_START" variable didn't get updated to include the --host-config option. I've attached a patch (jbossas-domain.patch) to fix this (the patch just makes sure that the --host-config option gets appended to JBOSSSH before CMD_START variable is created). jbossas-domain.patch needs to be applied to the /etc/init.d/jbossas-domain script. Attachment: Added: jbossas-domain.patch As we discussed, the only change is that the JBOSS_HOST_CONFIG if statement needs to be above the JBOSS_SERVER_CONFIG if statement in the jbossas-domain init script as shown below:
...
{code}
if [ ! -z $JBOSS_HOST_CONFIG ]; then
JBOSSSH="$JBOSSSH --host-config=$JBOSS_HOST_CONFIG"
fi
if [ ! -z $JBOSS_SERVER_CONFIG ]; then
CMD_START="cd $JBOSS_HOME/bin; $JBOSSSH -c $JBOSS_SERVER_CONFIG"
else
CMD_START="cd $JBOSS_HOME/bin; $JBOSSSH"
fi
{code}
...
Fix committed into distgit for both jbossas-{standalone,domain}, will be in the next ER handoff.
As a side note, it would be helpful to provide context diff rather than plain diff to see where the patch should be applied exactly.
Thanks, Permaine! I'll be sure to give a context diff in the future. Note that the JBOSS_HOST_CONFIG option is only relevant when running in domain mode. Added fix to get rid of JBOSS_HOST_CONFIG in jbossas-standalone during install section so that we can still keep the sysconfig file and init script in sync for both jbossas-{standalone,domain}.
Release Notes Docs Status: Added: Not Yet Documented Release Notes Docs Status: Removed: Not Yet Documented Docs QE Status: Removed: NEW Verified (ER3). |