Bug 900866 (JBPAPP6-1031) - HHH-7568 Add JPA1.0 compound key compatability when orm descriptor file used to override annotations.
Summary: HHH-7568 Add JPA1.0 compound key compatability when orm descriptor file used ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: JBPAPP6-1031
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Hibernate
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: EAP 6.0.1
Assignee: Strong Liu
QA Contact:
URL: http://jira.jboss.org/jira/browse/JBP...
Whiteboard:
Depends On:
Blocks: JBPAPP6-1082
TreeView+ depends on / blocked
 
Reported: 2012-09-08 08:39 UTC by Jeremy Whiting
Modified: 2014-05-27 01:28 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
EAP 6.0.0 GA
Last Closed: 2012-10-25 14:25:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker JBPAPP6-1031 0 Major Closed HHH-7568 Add JPA1.0 compound key compatability when orm descriptor file used to override annotations. 2013-04-23 13:21:19 UTC

Description Jeremy Whiting 2012-09-08 08:39:41 UTC
Affects: Release Notes
Complexity: Low
project_key: JBPAPP6

https://hibernate.onjira.com/browse/HHH-7568

Comment 1 Strong Liu 2012-09-12 03:21:59 UTC
Brett, is this fixed?

Comment 2 Strong Liu 2012-09-12 03:22:32 UTC
Link: Added: This issue is a dependency of JBPAPP-9721


Comment 3 Jeremy Whiting 2012-09-20 10:20:25 UTC
I have been given a cut of ER2 and it does not include Hibernate 4.1.7


Comment 4 Jeremy Whiting 2012-09-20 10:21:51 UTC
A cut of ER2 passed onto me does not include Hibernate 4.1.7.

Comment 5 Strong Liu 2012-09-20 10:24:46 UTC
No, EAP 6.0.1 won't have Hibernate ORM 4.1.7 but 4.1.6.

but this issue IS fixed in EAP 6.0.1 ER2, check it out, and if it didn't, then reopen this again, please do not reopen a issue w/o checking :D

Comment 6 Zbyněk Roubalík 2012-10-02 15:09:00 UTC
Fix is not present in ER2

Comment 7 Strong Liu 2012-10-03 11:55:28 UTC
Zbynek, could you show me the failing test that saying "fix is not present in ER2"?

Comment 8 Brett Meyer 2012-10-03 16:02:24 UTC
This was included as a patch.  Strong accidentally named it 9859, instead of 9858.

Comment 9 Zbyněk Roubalík 2012-10-04 07:42:53 UTC
Sorry for the confusion:) I tested it on ER2 and verified that it is fixed.

Comment 10 Jeremy Whiting 2012-10-09 13:17:08 UTC
Strong, re your message 20/Sep/12 6:24 AM, your right I should have checked first with you. I had been told it was going to be in 4.1.7 but that is no excuse for not getting in contact first.

Comment 12 Dana Mison 2012-10-16 02:34:59 UTC
Release Notes Docs Status: Removed: Not Required 


Comment 13 Dana Mison 2012-10-16 02:35:57 UTC
Release Notes Docs Status: Added: Needs More Info
Writer: Added: Darrin


Comment 14 Zbyněk Roubalík 2012-10-16 16:10:40 UTC
fixed in ER2

Comment 15 Dana Mison 2012-10-19 04:22:52 UTC
Affects: Added: Release Notes


Comment 16 Dana Mison 2012-10-23 04:02:31 UTC
Hi Strong, 

Couple of questions about this JIRA before I can document it in the release notes for EAP6.0.1

Referring back to the description of HHH-7568:

It seems like there are two issues being described:

1 - JPA 1.0 syntax was only supported with annotations, not in orm.xml.  
2 - There was a problem with annotation override from orm.xml with JoinColumn & JoinColumns.

The way that the test cases are mentioned in the description suggests to me that one of the items is only mentioned because the test cases for the other also test for this?

Which is "the" issue that should be documented as being resolved by this JIRA?  Can you please supply some more details about that the problem was, how it might have been experienced by a user/developer and how it has been fixed?

Thanks.

Comment 17 Strong Liu 2012-10-23 06:17:32 UTC
[~brmeyer] could you help on this release note? thanks

Comment 18 Brett Meyer 2012-10-25 14:19:18 UTC
[~Darrin], the code commits look like both #1 & #2 were completed.  I'm adding a rough release note pulled from HHH-7568 -- feel free to edit as necessary.  Thanks for the help!

Comment 19 Brett Meyer 2012-10-25 14:24:59 UTC
Release Notes Docs Status: Removed: Needs More Info Added: Documented as Resolved Issue
Writer: Removed: Darrin Added: brmeyer
Release Notes Text: Added: Property definitions to support applications using JPA1.0 syntax is only supported with annotations.
When the annotations were used in conjunction with overriding orm descriptor files, the annotated compound keys were lost.  Added support to keep the annotation-based compound keys, even if overriding orm descriptor files were used.

Also, annotation definitions are currently applied to individual JoinColumn annotations. But the JPA overridden annotation reader does present individual JoinColumn annotation definitions. It groups them together using the JoinColumns annotation descriptor.  Updated to allow the group annotation in addition to an individual annotation.


Comment 20 Anne-Louise Tangring 2012-11-13 20:12:04 UTC
Release Notes Docs Status: Removed: Documented as Resolved Issue 
Writer: Removed: brmeyer 
Release Notes Text: Removed: Property definitions to support applications using JPA1.0 syntax is only supported with annotations.
When the annotations were used in conjunction with overriding orm descriptor files, the annotated compound keys were lost.  Added support to keep the annotation-based compound keys, even if overriding orm descriptor files were used.

Also, annotation definitions are currently applied to individual JoinColumn annotations. But the JPA overridden annotation reader does present individual JoinColumn annotation definitions. It groups them together using the JoinColumns annotation descriptor.  Updated to allow the group annotation in addition to an individual annotation. 
Docs QE Status: Removed: NEW 



Note You need to log in before you can comment on or make changes to this bug.