Bug 900875 (JBPAPP6-1043)
| Summary: | log4j-jboss-logmanager 1.0.1.Final-redhat-1 depends on jUnit 4.10-redhat-1, should be ~2 | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Ondřej Žižka <ozizka> |
| Component: | Build | Assignee: | Paul Gier <pgier> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 6.0.0 | CC: | fnasser, jason.greene, ozizka, pgier |
| Target Milestone: | --- | ||
| Target Release: | EAP 6.0.1 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://jira.jboss.org/jira/browse/JBPAPP6-1043 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-11-19 13:12:30 UTC | Type: | Feature Request |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 900871 | ||
Link: Added: This issue is a dependency of JBPAPP-9865 This problem was caused by the shade plugin. The shade plugin generates a reduced pom which removes dependencies that were shaded into the jar. So this dependency reduced pom was installed to the mead repo instead of the pom used for the build. I configured the shade plugin to skip creation of the dependency reduced pom. http://pkgs.devel.redhat.com/cgit/rpms/log4j-jboss-logmanager/commit/?h=jb-eap-6-rhel-6&id=66b172d76c8c769774fe3b3ea7e8b9689c1de989 The new build is here: https://brewweb.devel.redhat.com/buildinfo?buildID=233073 If possible the upstream build should be changed to not use the shade plugin. Jason, can you make this change? At least incorporate Paul's patch? I'm not sure whether it makes sense to apply this patch upstream. The upstream project is using the shade plugin correctly, and my patch is really a workaround to shade's behaviour in our build system. When the shade plugin creates the dependency reduced pom the dependency versions get hard-coded into that pom. This is desirable behaviour upstream where old versions of dependencies never disappear. However, it doesn't work for us because we are continuously replacing old builds with new ones in the Maven repo. If log4j-jboss-logmanager can be changed to not shade any classes, and instead rely on the external log4j dependency, then that would allow our build to be the same as upstream. But I don't know the technical issues related to why it was necessary to package it this way. I added a note about this project to our wiki page of projects with repackaged stuff (https://community.jboss.org/wiki/AS7DependenciesWithRepackagedClasses). Closing this issue because I think the workaround of making the log4j dependency optional is fine for now. Longer term, the wiki page keeps track of builds that we had to modify for upstream, so those can be addressed upstream at some point if necessary. Release Notes Docs Status: Added: Not Yet Documented Release Notes Docs Status: Removed: Not Yet Documented Docs QE Status: Removed: NEW Verified during EAP-6.0.1-ER3 test cycle, fixed, closing... |
project_key: JBPAPP6 {code} ./local-repo-eap/org/jboss/logmanager/log4j-jboss-logmanager/1.0.1.Final-redhat-1/log4j-jboss-logmanager-1.0.1.Final-redhat-1.pom: <version>4.10-redhat-1</version> {code}