Bug 900878 (JBPAPP6-1139)
| Summary: | Wrong dep versions in various artifacts of EAP 6.0.1.ER1 | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Ondřej Žižka <ozizka> |
| Component: | Build | Assignee: | Vladimir Dosoudil <dosoudil> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 6.0.0 | CC: | dosoudil, fnasser, ozizka, pgier, rsvoboda |
| Target Milestone: | --- | ||
| Target Release: | EAP 6.0.1 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://jira.jboss.org/jira/browse/JBPAPP6-1139 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-10-30 11:43:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 900856 | ||
{quote}
(11:52:45 PM) ozizka-ntb: pgier: Have a minute?
(11:52:47 PM) ozizka-ntb: https://issues.jboss.org/browse/JBPAPP-9877
(11:55:41 PM) pgier: ozizka-ntb, is the javadoc plugin accessing all these dependencies?
(11:56:21 PM) pgier: most of those seem to be stuff that we don't ship
(11:56:40 PM) ozizka-ntb: pgier: Yes
(11:57:01 PM) ozizka-ntb: pgier: I'm not sure how to make it skip them.
(11:57:03 PM) ozizka-ntb: Any idea?
(11:57:30 PM) ozizka-ntb: pgier: The thing is, that it doesn't continue with producing javadoc
(11:57:32 PM) ozizka-ntb: just stops.
(11:57:38 PM) pgier: ozizka-ntb, they probably need to be excluded from whatever pom is bringing them in
(11:57:54 PM) pgier: or marked optional in whatever pom is using them
(11:58:01 PM) ozizka-ntb: pgier, that would be work for quite a long time.
(11:58:12 PM) ozizka-ntb: But I can try
(11:58:27 PM) ozizka-ntb: pgier, anyway - wouldn't it be worth it fixing the versions?
(11:58:41 PM) ozizka-ntb: i expect this to make troubles in other use cases too
(11:59:57 PM) pgier: ozizka-ntb, yes we should fix the builds that have the bad poms, we just also need to make sure that when we fix the bad poms they are configured with optional or some other non-transitive dep
(09/11/2012 12:00:12 AM) pgier: that way they won't even be accessed from your javadoc build
(12:01:07 AM) ozizka-ntb: ok
(12:01:47 AM) ozizka-ntb: pgier, last question - do you expect this to be fixed for EAP 6.0.1 ? Asking to know whether I should start working on workaround
(12:02:25 AM) ozizka-ntb: Otherwise I'd generate it from upstream source, just according to EAP's list of modules
(12:02:47 AM) pgier: ozizka-ntb, yes, hopefully it should be fixed for 6.0.1
(12:03:01 AM) ozizka-ntb: Great, thanks.
{quote}
Link: Added: This issue is a dependency of JBPAPP-9838 Paul, you cannot make these dependencies optional because you will break every single build that relies on the dependencies transitively. "provided" could be a workaround but we would have to manually change these third-party software and redo that at every upgrade (and I don't think vman can make assumptions about the class of a dependency). So the right fix for this is indeed to add exclusions like the AS7 does for anything that is not wanted. Ondrej are you copying over the AS7 exclusions? You need at least those to start with. Link: Added: This issue relates to JBPAPP-9801 Link: Added: This issue relates to JBPAPP-9799 {quote}So the right fix for this is indeed to add exclusions like the AS7 does for anything that is not wanted. Ondrej are you copying over the AS7 exclusions? You need at least those to start with.{quote}
These shouldn't have to be excluded in the EAP AS7 build if they are not excluded in the upstream AS7 build. The fact that these are appearing means that we probably have a different transitive dependency configuration in some of these builds than what the upstream poms have. The correct fix, IMO, is to change these poms to match the upstream dependency configuration. But I have to look at them individually to determine the actual cause.
John Casey's Repo Validator: http://github.com/jdcasey/repository-validator Please exclude all upstream versions (without -redhat-0-todo or -redhat-N suffixes) from javadoc processing, they're optional and not necessary in MEAD Maven repository because they're transitive only as building dependencies for EAP/AS components. And the imported ones (-redhat-0-todo) are not in the repository any more. Not seeing this problem with ER3. Resolving. Closing based on Ondra's comment. Docs QE Status: Removed: NEW |
project_key: JBPAPP6 When trying to create a javadoc using {code} mvn javadoc:aggregate -PjavadocDist -Djavadoc.branding='JBoss Enterprise Application Platform 6.0.1.GA' -Dmaven.repo.local=../local-repo-eap -s ../tools/maven/conf/settings.xml {code} , these errors are printed: {code} [INFO] --- maven-javadoc-plugin:2.8-redhat-1:aggregate-jar (javadocs-dist) @ jboss-as-build --- [WARNING] Missing POM for junit:junit:jar:4.8.2-redhat-1 [WARNING] Missing POM for emma:emma:jar:2.0.5312 [WARNING] Missing POM for emma:emma_ant:jar:2.0.5312 [WARNING] Missing POM for tanukisoft:wrapper:jar:3.2.3 [WARNING] Missing POM for org.jboss.integration:jboss-corba-ots-spi:jar:6.0.0.CR1 [WARNING] Missing POM for org.jboss.jbossas:jboss-server-manager:jar:1.0.4.Final [WARNING] Missing POM for org.jboss.logmanager:jboss-logmanager:jar:1.3.2.Final-redhat-0-todo [WARNING] Missing POM for org.apache.maven.wagon:wagon-provider-api:jar:1.0 [WARNING] Missing POM for org.jboss.netty:netty:jar:3.2.5.Final [WARNING] Missing POM for org.slf4j:slf4j-api:jar:1.6.2 [WARNING] Missing POM for org.codehaus.plexus:plexus-utils:jar:2.0.7 [WARNING] Missing POM for org.jboss.modules:jboss-modules:jar:1.1.3.GA-redhat-0-todo [WARNING] Missing POM for junit:junit:jar:4.8.2-redhat-2 [WARNING] Missing POM for org.apache.aries.blueprint:org.apache.aries.blueprint.core:jar:0.3-redhat-1 [WARNING] Missing POM for org.apache.aries.blueprint:org.apache.aries.blueprint.api:jar:0.3-redhat-1 [WARNING] Missing POM for org.apache.santuario:xmlsec:jar:1.5.1-redhat-2 [WARNING] Missing POM for org.apache.santuario:xmlsec:jar:1.5.1-redhat-2 [WARNING] Missing POM for werken-xpath:werken-xpath:jar:0.9.4 [WARNING] Missing POM for sun.jdk:jconsole:jar:javadoc-resources:jdk [WARNING] Missing POM for system:jdk-tools:jar:javadoc-resources:jdk [WARNING] Missing POM for com.gwtplatform:gwtp-mvp-client:jar:0.6-redhat-1 [WARNING] Missing POM for com.gwtplatform:gwtp-mvp-client:jar:0.6-redhat-1 [WARNING] Missing POM for jboss.web:jbossweb:jar:2.1.11.GA [WARNING] Missing POM for jboss.web:servlet-api:jar:2.1.11.GA [WARNING] Missing POM for cglib:cglib-nodep:jar:2.2 [WARNING] Missing POM for org.objenesis:objenesis:jar:1.2 [WARNING] Missing POM for org.jboss.logging:jboss-logging:jar:3.1.1.GA-redhat-2 [WARNING] Missing POM for org.jboss.logmanager:jboss-logmanager:jar:1.3.1.Final-redhat-2 [WARNING] Missing POM for org.jboss.ws:jbossws-spi:jar:2.0.3.GA-redhat-2 [WARNING] Missing POM for org.jboss:jboss-common-core:jar:2.2.12.GA {code} These versions are wrong, e.g. jUnit should be 4.10-redhat-2. Looking further, these versions occur at various dependencies. For example, jUnit: {code} local-repo-eap$ grep -r 4.8.2-redhat-1 . ./xmlunit/xmlunit/1.3-redhat-1/xmlunit-1.3-redhat-1.pom: <version>4.8.2-redhat-1</version> ./org/apache/ant/ant-junit/1.8.3-redhat-1/ant-junit-1.8.3-redhat-1.pom: <version>4.8.2-redhat-1</version> ./org/apache/ant/ant-parent/1.8.3-redhat-1/ant-parent-1.8.3-redhat-1.pom: <version>4.8.2-redhat-1</version> ondra@lenovo:~/work/AS7/ozizka-git/local-repo-eap$ grep -r 4.8.2-redhat-2 . ./commons-lang/commons-lang/2.6-redhat-2/commons-lang-2.6-redhat-2.pom: <version>4.8.2-redhat-2</version> ./commons-collections/commons-collections/3.2.1-redhat-2/commons-collections-3.2.1-redhat-2.pom: <version>4.8.2-redhat-2</version> ./commons-pool/commons-pool/1.5.6-redhat-2/commons-pool-1.5.6-redhat-2.pom: <version>4.8.2-redhat-2</version> ./commons-codec/commons-codec/1.4-redhat-2/commons-codec-1.4-redhat-2.pom: <!--<version>4.8.2-redhat-2</version>--> {code} This EAP version should use jUnit 4.10-redhat-2. Another example, `org.jboss:jboss-common-core:jar:2.2.12.GA`, should use `2.2.17.GA-redhat-2`. {code} ./org/jboss/jboss-reflect/2.0.3.GA/jboss-reflect-2.0.3.GA.pom: <version.jboss.common.core>2.2.12.GA</version.jboss.common.core> {code} Also, some poms are really missing. E.g. jboss.web:servlet-api really isn't there: http://download.lab.bos.redhat.com/brewroot/repos/jb-eap-6-rhel-6-build/latest/maven/jboss/