Bug 901324 – AroundInvokeAnnotationParsingProcessor should fail when more methods with @AroundInvoke annotation are found in the class

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 901324 - (JBPAPP6-1792) AroundInvokeAnnotationParsingProcessor should fail when more methods with @AroundInvoke annotation are found in the class

Summary:	AroundInvokeAnnotationParsingProcessor should fail when more methods with @Ar...

Status:	CLOSED CURRENTRELEASE

Aliases:	JBPAPP6-1792

Product:	JBoss Enterprise Application Platform 6
Classification:	JBoss
Component:	EJB (Show other bugs)
Sub Component:
Version:	6.0.1
Hardware:	Unspecified Unspecified

Priority	high Severity high
Target Milestone:	ER2
Target Release:	EAP 6.3.0
Assigned To:	Stuart Douglas
QA Contact:	Jan Martiska
Docs Contact:	Russell Dickenson

URL:	http://jira.jboss.org/jira/browse/JBP...
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2013-01-16 09:53 EST by Josef Cacek
Modified:	2014-07-17 00:31 EDT (History)
CC List:	7 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	In previous versions of JBoss EAP 6, classes were not checked for multiple @AroundInvoke methods. As a result, the first one discovered would be used, and any others would be ignored. In this release of the product, the deployment fails if there are multiple @AroundInvoke methods, alerting the developer to the problem.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2014-06-28 11:40:24 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
JBoss Issue Tracker	JBPAPP6-1792	Major	Closed	AroundInvokeAnnotationParsingProcessor should fail when more methods with @AroundInvoke annotation are found in the clas...	2014-07-24 03:23:55 EDT
JBoss Issue Tracker	WFLY-3192	Major	Resolved	AroundInvokeAnnotationParsingProcessor should fail when more methods with @AroundInvoke annotation are found in the clas...	2014-07-24 03:23:55 EDT

Groups: None (edit)

Description Josef Cacek 2013-01-16 09:53:01 EST

project_key: JBPAPP6

AroundInvokeAnnotationParsingProcessor should fail when more methods with @AroundInvoke annotation is found in the class.
[The specification|http://docs.oracle.com/javaee/6/api/javax/interceptor/AroundInvoke.html] says:
{panel}
A class must not declare more than one AroundInvoke method.
{panel}

The JBoss AS allows more such methods and then it chooses one of them which is used as the interceptor.

It becomes even more important to check the interceptor validity now with the new feature introduced by AS7-5897 (server side non-EE interceptors for EE invocations).

Comment 1 Josef Cacek 2013-01-16 09:54:09 EST

Link: Added: This issue is related to AS7-5897

Comment 2 Josef Cacek 2013-01-17 09:14:06 EST

Test (ignored for now) added in https://github.com/jbossas/jboss-as/pull/3892 

{{org.jboss.as.test.integration.ejb.container.interceptor.ContainerInterceptorsTestCase}}
{code}
@Deployment(name = "incorrect-deployment")
@ShouldThrowException(Exception.class)
public static JavaArchive createIncorrectDeployment() {
{code}

Comment 5 Emmanuel Hugonnet (ehsavoie) 2014-03-31 09:37:41 EDT

Upstream PR : https://github.com/wildfly/wildfly/pull/6104
PR : https://github.com/jbossas/jboss-eap/pull/1164

Comment 6 Josef Cacek 2014-05-05 05:04:06 EDT

Verified in 630ER2.

The regression test passes. (e.g. http://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/EAP6/view/EAP6-AS-Testsuite/job/eap-6x-as-testsuite-RHEL-matrix-openJDK6/116/jdk=openjdk-1.6.0-local,label_exp=RHEL5%26%26x86_64/testReport/org.jboss.as.test.integration.ejb.container.interceptor/ContainerInterceptorsTestCase/testMultipleAnnotatedInovkeAroundClass/)

Note You need to log in before you can comment on or make changes to this bug.