Spec URL: http://bochecha.fedorapeople.org/packages/perl-Email-Received.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Email-Received-1.00-1.fc18.noarch.rpm Description: This module is a Perl Email Project rewrite of SpamAssassin's email header parser. We did this so that the great work they did in analysing pretty much every possible Received header format could be used in applications other than SpamAssassin itself. Fedora Account System Username: bochecha
Taking the review.
The SRPM URL seems incorrect (and there's no other RPM file for this package in that directory). Please, (re)upload it.
(In reply to comment #2) > The SRPM URL seems incorrect (and there's no other RPM file for this package > in that directory). Please, (re)upload it. Gah, I recently deleted some old packages from that folder (packages which had been reviewed already). It seems I deleted this one, as well as perl-ParseUtil-Domain... Reuploaded, sorry about that.
Ok, using http://bochecha.fedorapeople.org/packages/perl-Email-Received-1.00-1.fc18.src.rpm :) As usually, missing BRs :) perl(base) perl(constant) perl(Exporter) perl(Test) perl(Test::More) You can substitute the %{__perl} macro with simple 'perl'. (lines 17 and 31; optional) Also, Fedora Guidelines recommend using US English in Summary and Description. Consider replacing 'analysing' with 'analyzing'. Switch from PERL_INSTALL_ROOT to DESTDIR unless you have your reasons not to. The rest is okay. No other issues.
(In reply to comment #4) > Ok, using > http://bochecha.fedorapeople.org/packages/perl-Email-Received-1.00-1.fc18. > src.rpm :) > > As usually, missing BRs :) > perl(base) > perl(constant) > perl(Exporter) > perl(Test) > perl(Test::More) Added. > You can substitute the %{__perl} macro with simple 'perl'. (lines 17 and 31; > optional) Substituted. > Also, Fedora Guidelines recommend using US English in Summary and > Description. Consider replacing 'analysing' with 'analyzing'. Replaced. /me wasn't even aware the word had a different spelling in en_GB and en_US :) > Switch from PERL_INSTALL_ROOT to DESTDIR unless you have your reasons not to. Switched. > The rest is okay. No other issues. Here's the new package. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Email-Received.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Email-Received-1.00-2.fc18.noarch.rpm
(In reply to comment #5) > (In reply to comment #4) > > Also, Fedora Guidelines recommend using US English in Summary and > > Description. Consider replacing 'analysing' with 'analyzing'. > > Replaced. > > /me wasn't even aware the word had a different spelling in en_GB and en_US :) I often wouldn't know either; fortunatelly we have hunspell-en-US ;) All fixed, approving.
Thanks for the review Petr! New Package SCM Request ======================= Package Name: bochecha Short Description: Parse an email Received: header Owners: bochecha Branches: devel InitialCC: perl-sig
Requested package name bochecha doesn't match bug summary perl-Email-Received, please fix.
Oops, sorry about that. New Package SCM Request ======================= Package Name: perl-Email-Received Short Description: Parse an email Received: header Owners: bochecha Branches: devel InitialCC: perl-sig
Git done (by process-git-requests).
Thanks Jon for the Git process! Package built in Rawhide, closing.