Spec URL: http://odysseus.x-tnd.be/fedora/php-password_compat/php-password_compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password_compat/php-password_compat-1.0.0-1.git58151cf.trashy.src.rpm Description: PHP password_* function for 5.3 and 5.4 Fedora Account System Username: trasher
I did not pay attention I mixed "-" and "_" in the package name. Here are new URLs: Spec URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat-1.0.0-1.git58151cf.fc18.src.rpm
Created attachment 684250 [details] phpci.log
Created attachment 684251 [details] php-password-compat-review.txt
[!]: Run phpci static analyze on all php files. phpci reports REQUIRED PHP 5.5.0-dev (MIN) which is, of course a false positive. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the Could be droped as other EL-5 stuff not present [!]: Description "PHP password_* function for 5.3 and 5.4" probably "PHP" missing" [!]: Comment in %check (not version 1.4.4) OK (30 tests, 30 assertions) [!]: test in PHP include_path Please move to /usr/share/tests/%{name} NB: need to own /usr/share/tests or require php-pear Only the latest seems a blocker (for me, nothing in Guidelines about this)
AS this packages requires php version 5.3.7, you could not target EPEL. So, it will be cleaner to use, instead of php-common: Requires: php(language) >= 5.3.7
Thank you for the comments :) Here is a new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat-1.0.0-2.git58151cf.fc18.src.rpm I should have fixed all mentioned points.
Gasp, I've missed licence modification... Here the new build: Spec URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat-1.0.0-3.git58151cf.fc18.src.rpm
Ooooooh. Sorry, I've made a mistake with another review I'm working on; this one did not have license issue :-/
You need to own /usr/share/tests (or require php-pear)
New version : MIT license is back, test directory is now owned. Here the new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-password-compat/php-password-compat-1.0.0-4.git58151cf.fc18.src.rpm
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the [x]: Description "PHP password_* function for 5.3 and 5.4" [x]: Comment in %check (not version 1.4.4) [x]: test in PHP include_path [x]: Requires: php(language) >= 5.3.7 All issues fixed No blocker == APPROVED ===
New Package SCM Request ======================= Package Name: php-password-compat Short Description: PHP password_* function for PHP 5.3 and 5.4 Owners: trasher Branches: f17 f18 el6 InitialCC:
Hum... PHP in EL-6 is 5.3.3 (5.3.7 is required), so please do not create that branch. The modified SCM request: New Package SCM Request ======================= Package Name: php-password-compat Short Description: PHP password_* function for PHP 5.3 and 5.4 Owners: trasher Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
php-password-compat-1.0.0-4.git58151cf.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-password-compat-1.0.0-4.git58151cf.fc17
php-password-compat-1.0.0-4.git58151cf.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-password-compat-1.0.0-4.git58151cf.fc18
php-password-compat-1.0.0-4.git58151cf.fc17 has been pushed to the Fedora 17 testing repository.
php-password-compat-1.0.0-4.git58151cf.fc17 has been pushed to the Fedora 17 stable repository.
php-password-compat-1.0.0-4.git58151cf.fc18 has been pushed to the Fedora 18 stable repository.
Package Change Request ====================== Package Name: php-password-compat New Branches: el6 Owners: trasher