Spec URL: http://dlehman.fedorapeople.org/blivet/blivet.spec SRPM URL: http://dlehman.fedorapeople.org/blivet/blivet-0.3-1.fc18.src.rpm Description: The blivet package is a python module for system storage configuration Fedora Account System Username: dlehman
Updated rpm package name to python-blivet in accordance with guidelines: Spec URL: http://dlehman.fedorapeople.org/python-blivet/python-blivet.spec SRPM URL: http://dlehman.fedorapeople.org/python-blivet/python-blivet-0.4-1.fc18.src.rpm
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. bcl The COPYING file is old. Their new address is in Boston. http://www.gnu.org/licenses/old-licenses/gpl-2.0.html I think License should be GPLv2+ since the source files are GPL2 or later [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required bcl The rm is not needed, the buildroot is already cleaned before %install [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License field in the package spec file matches the actual license. bcl tests/* files should probably have license headers on them [x]: The spec file handles locales properly. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [!]: Package contains BR: python2-devel or python3-devel bcl Should use python2-devel instead of python-devel [-]: Binary eggs must be removed in %prep [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required bcl No need for clean or BuildRoot in F13 and later [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: SourceX / PatchY prefixed with %{name}. [-]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. Note: %define realname blivet %define fcoeutilsver 1.0.12-3.20100323git %define iscsiver 6.2.0.870-3 bcl define is fine. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python-blivet-0.4-1.fc18.noarch.rpm python-blivet-0.4-1.fc18.src.rpm python-blivet.noarch: W: unexpanded-macro dependency device-mapper >= %{dmver} %{dmver} python-blivet.noarch: W: unexpanded-macro dependency e2fsprogs >= %{e2fsver} %{e2fsver} python-blivet.noarch: W: unexpanded-macro dependency parted >= %{partedver} %{partedver} python-blivet.noarch: W: unexpanded-macro dependency pyparted >= %{pypartedver} %{pypartedver} python-blivet.noarch: W: unexpanded-macro dependency python-cryptsetup >= %{pythoncryptsetupver} %{pythoncryptsetupver} python-blivet.noarch: W: unexpanded-macro dependency python-pyblock >= %{pythonpyblockver} %{pythonpyblockver} python-blivet.noarch: W: unexpanded-macro dependency util-linux >= %{utillinuxver} %{utillinuxver} python-blivet.noarch: E: description-line-too-long C The python-blivet package is a full-featured python module for examining and modifying storage configuration. python-blivet.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/blivet/tsort.py 0644L /usr/bin/python python-blivet.noarch: E: incorrect-fsf-address /usr/share/doc/python-blivet-0.4/COPYING python-blivet.src: E: description-line-too-long C The python-blivet package is a full-featured python module for examining and modifying storage configuration. python-blivet.src: W: invalid-url Source0: blivet-0.4.tar.gz 2 packages and 0 specfiles checked; 4 errors, 8 warnings. bcl: Looks like we are missing most of the version numbers used in the Requires tsort.py has #!/usr/bin/python at the top, so should be executable, or remove that and the __main__ section. Rpmlint (installed packages) ---------------------------- # rpmlint python-blivet python-blivet.noarch: W: unexpanded-macro dependency device-mapper >= %{dmver} %{dmver} python-blivet.noarch: W: unexpanded-macro dependency e2fsprogs >= %{e2fsver} %{e2fsver} python-blivet.noarch: W: unexpanded-macro dependency parted >= %{partedver} %{partedver} python-blivet.noarch: W: unexpanded-macro dependency pyparted >= %{pypartedver} %{pypartedver} python-blivet.noarch: W: unexpanded-macro dependency python-cryptsetup >= %{pythoncryptsetupver} %{pythoncryptsetupver} python-blivet.noarch: W: unexpanded-macro dependency python-pyblock >= %{pythonpyblockver} %{pythonpyblockver} python-blivet.noarch: W: unexpanded-macro dependency util-linux >= %{utillinuxver} %{utillinuxver} python-blivet.noarch: E: description-line-too-long C The python-blivet package is a full-featured python module for examining and modifying storage configuration. python-blivet.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/blivet/tsort.py 0644L /usr/bin/python python-blivet.noarch: E: incorrect-fsf-address /usr/share/doc/python-blivet-0.4/COPYING 1 packages and 0 specfiles checked; 3 errors, 7 warnings. # echo 'rpmlint-done:' Requires -------- python-blivet-0.4-1.fc18.noarch.rpm (rpmlib, GLIBC filtered): anaconda btrfs-progs cryptsetup-luks device-mapper >= %{dmver} device-mapper-multipath dosfstools e2fsprogs >= %{e2fsver} fcoe-utils >= 1.0.12-3.20100323git hfsplus-tools iscsi-initiator-utils >= 6.2.0.870-3 lvm2 mdadm parted >= %{partedver} pyparted >= %{pypartedver} python python(abi) = 2.7 python-cryptsetup >= %{pythoncryptsetupver} python-pyblock >= %{pythonpyblockver} util-linux >= %{utillinuxver} Provides -------- python-blivet-0.4-1.fc18.noarch.rpm: python-blivet = 0.4-1.fc18 MD5-sum check ------------- Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-18-x86_64 Command line :/bin/fedora-review -b 901729
Added missing dependency version macros, updated COPYING file, removed #! line from tsort.py. Spec URL: http://dlehman.fedorapeople.org/python-blivet/python-blivet.spec SRPM URL: http://dlehman.fedorapeople.org/python-blivet/python-blivet-0.4-2.fc18.src.rpm
Looks good!
New Package SCM Request ======================= Package Name: python-blivet Short Description: python module for system storage configuration Owners: dlehman bcl Branches: InitialCC: anaconda-maint
Git done (by process-git-requests).
From the .spec file: # This is a Red Hat maintained package which is specific to # our distribution. Thus the source is only available from # within this srpm. I understand it's annoying to keep some 'upstream' page with releases etc. and it's probably the last item on your TODO list, but the above message is something I personally would not like to see in Fedora. IMHO we want not to hide it in Red Hat, *any* community is welcome here. Please use at least Source0: http://git.fedorahosted.org/cgit/blivet.git/snapshot/blivet-0.4-1.tar.gz