Bug 901949 - Site Sanity Check tests are failing
Summary: Site Sanity Check tests are failing
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Website
Version: 2.x
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: Fabiano Franz
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-20 05:51 UTC by Dan McPherson
Modified: 2015-05-15 01:17 UTC (History)
2 users (show)

Fixed In Version: devenv_2710
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-13 22:56:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Comment (108.52 KB, text/plain)
2013-01-20 05:51 UTC, Dan McPherson
no flags Details

Description Dan McPherson 2013-01-20 05:51:47 UTC
Created attachment 915658 [details]
Comment

(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).

Comment 1 Clayton Coleman 2013-01-21 00:07:02 UTC
Was introduced by the twitter changes - not sure how it made it through the pull queue if this was failing.

Comment 2 Clayton Coleman 2013-01-21 00:08:40 UTC
Fabiano, note that dan is running this from a different cloned location than you may be running in your devenv (he's running as the tests do, in a copy of site repo installed to ~/openshift-test/site vs. /var/www/openshift/site).

Comment 3 Fabiano Franz 2013-01-21 14:28:05 UTC
It's still passing locally with bundle exec rake test:sanity, but I confirmed it fails on a devenv no matter if running in ~/openshift-test/site or /var/www/openshift/site. Working on a fix.

Comment 4 openshift-github-bot 2013-01-22 16:01:57 UTC
Commits pushed to master at https://github.com/openshift/li

https://github.com/openshift/li/commit/bdbd98f9c2f5e680b60972cccbe8f865127f2ce3
Fix bug 901949, now mocking oauth timestamp and nonce instead of oauth itself to provide better tests

https://github.com/openshift/li/commit/5aa79a3fdc5c3e6ce6383a2782a0f31194710e69
Ref bug 901949, Twitter tests removed to make sanity pass

Comment 5 openshift-github-bot 2013-01-23 01:14:08 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/de5b014914d182906ea264b4c2e06a71b5bd66cd
Bug 901949 - setting Accept header on OAuth to workaround a bug in some versions of ActiveSupport

Comment 6 openshift-github-bot 2013-01-23 02:13:38 UTC
Commit pushed to master at https://github.com/openshift/li

https://github.com/openshift/li/commit/26e258b3068f56751c21fc88b001d0f500f810dd
Bug 901949 - improved Twitter tests, now just mocking nonce and timestamp instead of the whole OAuth

Comment 7 Fabiano Franz 2013-01-23 02:15:40 UTC
Fixed in devenv_2710.

Comment 8 Yujie Zhang 2013-01-23 09:44:53 UTC
(In reply to comment #7)
Tested on devenv_2710, tried "rake test:sanity" in /var/www/openshift/site/ directioy, it can pass without error, details as following, so verify this bug.


[root@ip-10-36-122-55 site]# rake test:sanity
Loaded suite /opt/rh/ruby193/root/usr/share/gems/gems/rake-0.9.2.2/lib/rake/rake_test_loader
Started
DEPRECATION WARNING: Passing a template handler in the template name is deprecated. You can simply remove the handler name or pass render :handlers => [:haml] instead. (called from realtime at /opt/rh/ruby193/root/usr/share/ruby/benchmark.rb:295)
DEPRECATION WARNING: Passing a template handler in the template name is deprecated. You can simply remove the handler name or pass render :handlers => [:haml] instead. (called from realtime at /opt/rh/ruby193/root/usr/share/ruby/benchmark.rb:295)
DEPRECATION WARNING: Passing a template handler in the template name is deprecated. You can simply remove the handler name or pass render :handlers => [:haml] instead. (called from realtime at /opt/rh/ruby193/root/usr/share/ruby/benchmark.rb:295)
DEPRECATION WARNING: Passing a template handler in the template name is deprecated. You can simply remove the handler name or pass render :handlers => [:haml] instead. (called from realtime at /opt/rh/ruby193/root/usr/share/ruby/benchmark.rb:295)


Finished in 290.398496987 seconds.

449 tests, 1881 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
0% passed

1.55 tests/s, 6.48 assertions/s
Coverage report generated for Site tests to /var/www/openshift/site/test/coverage/. 1656 / 2275 LOC (72.79%) covered.


Note You need to log in before you can comment on or make changes to this bug.