Bug 902218 - Probing an invalid host causes glusterd to crash
Probing an invalid host causes glusterd to crash
Status: CLOSED ERRATA
Product: Red Hat Gluster Storage
Classification: Red Hat
Component: glusterd (Show other bugs)
2.0
Unspecified Unspecified
medium Severity high
: ---
: ---
Assigned To: krishnan parthasarathi
Sachidananda Urs
:
Depends On: 893851
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-21 02:37 EST by Vidya Sakar
Modified: 2015-11-03 18:05 EST (History)
9 users (show)

See Also:
Fixed In Version: glusterfs-3.4.0qa8
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 893851
Environment:
Last Closed: 2013-09-23 18:39:25 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Vidya Sakar 2013-01-21 02:37:35 EST
+++ This bug was initially created as a clone of Bug #893851 +++

This is causing regression tests to fail most of the time at step 12 of bug-879490.t and is also readily reproducible in isolation.  The problem is that we're adding the new peer to our peer list *after* calling glusterd_friend_rpc_create.  Unfortunately, by that time the disconnect-notify callback associated with our new  RPC object might already have been invoked, removing *and freeing* the new peer.  Thus, we add it after freeing it, leading to a corrupt list and a likely future crash - most often in glusterd_op_ac_send_lock while deleting the volume.  The test fails because glusterd disconnects and dies in mid-operation.

The fix is to change the order of addition to and deletion from the peer list.  In the process, the general control flow of glusterd_friend_add was simplified so that it's not only correct but more readily verified to be so.

--- Additional comment from Jeff Darcy on 2013-01-09 22:36:32 EST ---

http://review.gluster.org/#change,4372

--- Additional comment from Vijay Bellur on 2013-01-10 04:29:59 EST ---

CHANGE: http://review.gluster.org/4372 (glusterd: fix memory corruption when probe fails) merged in master by Vijay Bellur (vbellur@redhat.com)
Comment 2 Amar Tumballi 2013-02-01 01:20:33 EST
valid only for rhs-2.1.0... is now committed.
Comment 4 Scott Haines 2013-04-11 12:36:30 EDT
Per 04-10-2013 Storage bug triage meeting, targeting for Big Bend.
Comment 5 Sachidananda Urs 2013-08-01 03:21:43 EDT
Verified on: glusterfs 3.4.0.14rhs built on Jul 30 2013 09:09:36

Crash is not seen.
Comment 6 Scott Haines 2013-09-23 18:39:25 EDT
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. 

For information on the advisory, and where to find the updated files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1262.html
Comment 7 Scott Haines 2013-09-23 18:43:44 EDT
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. 

For information on the advisory, and where to find the updated files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1262.html

Note You need to log in before you can comment on or make changes to this bug.