Spec File: http://rrix.fedorapeople.org/beefsay/cowsay-beefymiracle.spec SRPM: http://rrix.fedorapeople.org/beefsay/cowsay-beefymiracle-1.0-1.fc18.src.rpm _________________________________________ / Provides a cowsay file for His Holiness \ | the Beefy Miracle. It can be invoked | | using cowsay -f beefymiracle, or | \ aliased appropriately. / ----------------------------------------- \ .---. __ , / \ \ |||| \\\\ |O___O | | \\|||| \ // | \_/ | | \ / '--/----/| / | |-' // // / -----' // \\ / / // // / / // \\ / / // // / / /| ' / / //\___/ / // ||\ / \\_ || '---' /' / \\ .- / / --| | '-' | | '-' rrix@hobbes:rpmbuild () $ find . -name cowsay*rpm |xargs rpmlint cowsay-beefymiracle.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
_______________________________________ / The package builds and runs properly, \ | as shown here. I will do a full | | checklist in a bit. | | | | You should add a %check section which | | runs "echo Installation successful | | | cowsay -f beefymiracle"; if the cow | | file doesn't install properly it'll | \ fail with a non-zero return code. / --------------------------------------- \ .---. __ , / \ \ |||| \\\\ |O___O | | \\|||| \ // | \_/ | | \ / '--/----/| / | |-' // // / -----' // \\ / / // // / / // \\ / / // // / / /| ' / / //\___/ / // ||\ / \\_ || '---' /' / \\_.- / / --| | '-' | | '-'
_________________________________________ / I have updated the spec and SRPM \ | accordingly; the URL is the same as the | \ previous / ----------------------------------------- \ .---. __ , / \ \ |||| \\\\ |O___O | | \\|||| \ // | \_/ | | \ / '--/----/| / | |-' // // / -----' // \\ / / // // / / // \\ / / // // / / /| ' / / //\___/ / // ||\ / \\_ || '---' /' / \\_.- / / --| | '-' | | '-'
________________________________________________________________ / In the future you should always bump the release number in the \ | specfile even if posting a new URL ruins a joke. | | | | Using the checklist available at: | | http://fedoraproject.org/wiki/Packaging:ReviewGuidelines | | | | [OK] rpmlint must be run: cowsay-beefymiracle.noarch: W: | | no-documentation | | | | [OK] follow Package Naming Guidelines | | | | [OK] spec filename matches %{name} | | | | [OK] meets Packaging Guidelines | | | | [OK] license is Fedora-approved | | | | [OK] license matches actual license | | | | [NA] license file included in %doc | | | | [OK] spec written in en_US | | | | [OK] spec legible unlike this review | | | | [OK] source sha256sums match (see below His Beefiness) | | | | [OK] package compiles on at least one arch | | | | [NA] ExcludeArches filed in BZ | | | | [OK] BuildRequires are good | | | | [NA] locales are not horrible | | | | [NA] ldconfig in %post and %postun | | | | [OK] no bundling | | | | [NA] something about relocatability | | | | [NA] owns directories it creates | | | | [OK] no %files duplicates | | | | [OK] permissions are a'ight | | | | [NA] macros are consistent | | | | [OK] contains code or permissable content | | | | [NA] large docs go in -doc | | | | [NA] %doc doesn't affect runtime | | | | [NA] static in -static | | | | [NA] devel in -devel | | | | [NA] -devel has fully-versioned dependency | | | | [OK] no libtool crap | | | | [NA] GUI has .desktop files | | | | [OK] doesn't own files from other packages | | | | [OK] filenames are UTF-8 | | | \ This package is APPROVED / ---------------------------------------------------------------- \ .---. __ , / \ \ |||| \\\\ |O___O | | \\|||| \ // | \_/ | | \ / '--/----/| / | |-' // // / -----' // \\ / / // // / / // \\ / / // // / / /| ' / / //\___/ / // ||\ / \\_ || '---' /' / \\_.- / / --| | '-' | | '-' 211dd37622d1629c6c6b82522bdc20c22f62a179888d72353c4e0fe193c4a454 beefymiracle.cow 211dd37622d1629c6c6b82522bdc20c22f62a179888d72353c4e0fe193c4a454 cowsay-beefymiracle-1.0-1.fc18.src/beefymiracle.cow Remember that the SCM admin request cannot be in cowsay because scripts
New Package SCM Request ======================= Package Name: cowsay-beefymiracle Short Description: Cowsay file for the Beefy Miracle Owners: rrix Branches: fc17 fc18 InitialCC:
Git done (by process-git-requests).
cowsay-beefymiracle-1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/cowsay-beefymiracle-1.0-1.fc18
cowsay-beefymiracle-1.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/cowsay-beefymiracle-1.0-1.fc17
cowsay-beefymiracle-1.0-1.fc18 has been pushed to the Fedora 18 testing repository.
cowsay-beefymiracle-1.0-1.fc18 has been pushed to the Fedora 18 stable repository.