Description of problem:
The iscsi initiator name is being modified during a RHEV-H upgrade, i.e. the '/etc/iscsi/initiatorname.iscsi' file is being rewritten with a new value.

The 'ovirt-config-iscsi' script does the following;

function set_initiator {
    if [ -z "$1" ]; then
        INITIATOR_NAME=$(iscsi-iname)
    else
        INITIATOR_NAME=$1
    fi

    echo "InitiatorName=$INITIATOR_NAME" > $INITIATOR_FILE
    ovirt_store_config $INITIATOR_FILE
    rc=$?
    if [ $rc = 0 ]; then
        printf "Initiator name set as: $INITIATOR_NAME\n"
    else
        printf "Setting initiator name failed\n"
    fi
}

# AUTO for auto-install
if [ "$1" = "AUTO" ]; then
    set_initiator $OVIRT_ISCSI_NAME
else
    printf "\n\n iSCSI Initiator Configuration\n\n"
    prompt_user
fi


It would seem that a conditional check for an upgrade could be added above. I had assumed that checking for OVIRT_UPGRADE being set would suffice, but I didn't see this being set during my upgrade attempt. 

I then noticed BZ 513456, for an older release. That bug appeared to address this very issue (refer to comments 6,7,8) by modifying 'ovirt-config-boot' to check to see if the '/etc/iscsi/initiatorname.iscsi' file had already been persisted or not. However, at some later time, it appears that (at least) the iscsi-related code was removed from 'ovirt-config-boot' in deference to 'ovirt-config-iscsi'. However, the code added to not modify the iscsi initiator name during an upgrade appears to be have omitted.

So, maybe adding a similar check for persistency as existed previously in 'ovirt-config-boot' might be the way to go ?


Version-Release number of selected component (if applicable):
RHEV Hypervisor 6.3 (20121212.0.el6_3).


How reproducible:
It occurred the one time that I performed a RHEV-H upgrade and eight times for the customer. The specific upgrade in each case was from 20121012.0 to 20121212.0.


Steps to Reproduce:
1.  'cat /etc/iscsi/initiatorname.iscsi'.
2.  Upgrade RHEV-H.
3.  'cat /etc/iscsi/initiatorname.iscsi', the initiator name will have changed.
  

Actual results:
The iscsi initiator name is being modified during a RHEV-H upgrade.

Expected results:
The iscsi initiator name should remain unchanged as a result of a RHEV-H upgrade.

Additional info:
The customer in question had to manually modify the targets on the server with the new initiator name. However, when I tried an upgrade here, the new initiator name was propagated to the target server. Regardless, the point is that the initiator name is being modified during an upgrade, but it's still of value to note that this caused the customer in question some inconvenience.

Any questions, please let me know. 
Thanks, GFW.