Spec URL: http://jjames.fedorapeople.org/lfsc/lfsc.spec SRPM URL: http://jjames.fedorapeople.org/lfsc/lfsc-0.20120321-1.fc19.src.rpm Description: This package contains an SMT proof checker. It is used by CVC4, which I am preparing to submit for review. Fedora Account System Username: jjames
The package is quite simple so I do not expect to find any major issues, at first my considerations are: I see you made the manual page based on http://clc.cs.uiowa.edu/lfsc/readme-lfsc.txt I suggest adding it to sources, no need to install as %doc, to work as a kind of reminder to validate the manual page is up to dade when updating the package. [!]: %check is present and all tests pass. Please add a simple %check section with a basic validation that the package works as expected. Full fedora-review text follows: ---%<--- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/pcpa/903428-lfsc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 1 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: lfsc-0.20120321-1.fc19.x86_64.rpm lfsc-devel-0.20120321-1.fc19.x86_64.rpm lfsc-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint lfsc lfsc-devel lfsc-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- lfsc (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) lfsc-devel (rpmlib, GLIBC filtered): gmp-devel(x86-64) lfsc(x86-64) Provides -------- lfsc: lfsc lfsc(x86-64) lfsc-devel: lfsc-devel lfsc-devel(x86-64) MD5-sum check ------------- http://clc.cs.uiowa.edu/lfsc/lfsc_src.zip : CHECKSUM(SHA256) this package : 227052f074c9eca8128ca622b95cff7fdcf24ee7138e34a434fbbaf9e5c746cb CHECKSUM(SHA256) upstream package : 227052f074c9eca8128ca622b95cff7fdcf24ee7138e34a434fbbaf9e5c746cb http://clc.cs.uiowa.edu/lfsc/license.txt : CHECKSUM(SHA256) this package : ad924249ea7b28a0b2ce6b46f6fc072a09425a0080708bc67116c0971fa75f51 CHECKSUM(SHA256) upstream package : ad924249ea7b28a0b2ce6b46f6fc072a09425a0080708bc67116c0971fa75f51 Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -v -b 903428 ---%<---
I have added the source text file as a reminder to update the man page on updates. I have also added a simple %check script. The tool returns non-zero if a proof fails to check. New URLs: Spec URL: http://jjames.fedorapeople.org/lfsc/lfsc.spec SRPM URL: http://jjames.fedorapeople.org/lfsc/lfsc-0.20120321-2.fc19.src.rpm
The srpm url is wrong, but I guessed it right and run fedora-review on the srpm: s/fc19/fc20/. The package is APPROVED.
Oops. How did I do that??? Thanks for the review.
New Package SCM Request ======================= Package Name: lfsc Short Description: SMT proof checker Owners: jjames Branches: f18 InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: lfsc New Branches: f19 Owners: jjames InitialCC: Sigh. I shouldn't try to do anything when I'm sick. I now have an F-18 branch and an F-20 branch, but no F-19 branch. This change request fixes the problem.
lfsc-0.20120321-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lfsc-0.20120321-2.fc19
lfsc-0.20120321-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lfsc-0.20120321-2.fc18
lfsc-0.20120321-2.fc19 has been pushed to the Fedora 19 testing repository.
lfsc-0.20120321-3.fc19 has been pushed to the Fedora 19 stable repository.
lfsc-0.20120321-3.fc18 has been pushed to the Fedora 18 stable repository.