openstack puppet recipes will override whatever we put in *dist.conf, with its own version in /etc/*.conf, we'll have to make sure 1. these values match up with what the distro default should be 2. the bug is fixed that causes it to blow up if it doesn't see values its expecting
(In reply to comment #0) > 2. the bug is fixed that causes it to blow up if it doesn't see values its > expecting this was filed as bug 903719
I went through the conf files for nova, glance and cinder (keystone isn't done yet) to compare the values packstack puts in /etc/*/*conf that conflict with the values that are put in *dist.conf below are the values that stood out nova.conf differences (openstack-nova-common-2012.2.3-1.el6ost) rhos : dhcpbridge_flagfile = /usr/share/nova/nova-dist.conf ps : dhcpbridge_flagfile=/etc/nova/nova.conf rhos : force_dhcp_release = True ps : force_dhcp_release=false rhos : rpc_backend = nova.openstack.common.rpc.impl_qpid ps : rpc_backend=nova.rpc.impl_qpid glance-api : openstack-glance-2012.2.3-1.el6ost # not set in RHOS, but maybe worth mentioning ? ps : workers = 2 there are many others that packstack sets but they either match whats in the dist.conf files or set values needed by the deployment (e.g. sql credentials), which of these should be changed in packstack ?
(In reply to comment #2) > I went through the conf files for nova, glance and cinder (keystone isn't > done yet) to compare the values packstack puts in /etc/*/*conf that conflict > with the values that are put in *dist.conf below are the values that stood > out > > nova.conf differences (openstack-nova-common-2012.2.3-1.el6ost) > > rhos : dhcpbridge_flagfile = /usr/share/nova/nova-dist.conf > ps : dhcpbridge_flagfile=/etc/nova/nova.conf Yikes ... this actually exposes a bug with our nova-dist.conf approach. There is no way to get the nova-dhcpbridge binary to read both config files. I've filed a bug here: https://bugzilla.redhat.com/show_bug.cgi?id=914759 As for packstack, it's sort of tricky ... in the case of RHOS, you shouldn't set it at all. You should let the default in nova-dist.conf stand (to be set to both nova-dist.conf and nova.conf once the above bug is fixed). In the non-RHOS case, you probably *do* want to set it, and set it to /etc/nova/nova.conf. The default is /etc/nova/nova-dhcpbridge.conf, which isn't going to exist. So ... I see a couple of options. You could check for the existence of nova-dist.conf, and not set the option if it's there. The other option would be to install a nova-dhcpbridge.conf that is a symlink to nova.conf. That way if the installed version of nova doesn't set this option, the default value will work by going to nova.conf. Messy. > rhos : force_dhcp_release = True > ps : force_dhcp_release=false The upstream default is False. This seems like a good option to set to True, though. I would set it to True. > rhos : rpc_backend = nova.openstack.common.rpc.impl_qpid > ps : rpc_backend=nova.rpc.impl_qpid Both will work. The RHOS version is more correct. The ps version is supported for backwards compatibility. I would change it to match RHOS. > glance-api : openstack-glance-2012.2.3-1.el6ost > # not set in RHOS, but maybe worth mentioning ? > ps : workers = 2 > > > there are many others that packstack sets but they either match whats in the > dist.conf files or set values needed by the deployment (e.g. sql > credentials), which of these should be changed in packstack ?
Created attachment 702398 [details] dhcp patch Removes the line that sets dhcpbridge_flagfile and force_dhcp_release in packstack so that the default in /usr/share/nova.... will be used
(In reply to comment #3) > (In reply to comment #2) > > I went through the conf files for nova, glance and cinder (keystone isn't > > done yet) to compare the values packstack puts in /etc/*/*conf that conflict > > with the values that are put in *dist.conf below are the values that stood > > out > > > > nova.conf differences (openstack-nova-common-2012.2.3-1.el6ost) > > > > rhos : dhcpbridge_flagfile = /usr/share/nova/nova-dist.conf > > ps : dhcpbridge_flagfile=/etc/nova/nova.conf > > Yikes ... this actually exposes a bug with our nova-dist.conf approach. > There is no way to get the nova-dhcpbridge binary to read both config files. > I've filed a bug here: > > https://bugzilla.redhat.com/show_bug.cgi?id=914759 > > As for packstack, it's sort of tricky ... in the case of RHOS, you shouldn't > set it at all. You should let the default in nova-dist.conf stand (to be > set to both nova-dist.conf and nova.conf once the above bug is fixed). In > the non-RHOS case, you probably *do* want to set it, and set it to > /etc/nova/nova.conf. The default is /etc/nova/nova-dhcpbridge.conf, which > isn't going to exist. > > So ... I see a couple of options. You could check for the existence of > nova-dist.conf, and not set the option if it's there. The other option > would be to install a nova-dhcpbridge.conf that is a symlink to nova.conf. > That way if the installed version of nova doesn't set this option, the > default value will work by going to nova.conf. > > Messy. > > > rhos : force_dhcp_release = True > > ps : force_dhcp_release=false > > The upstream default is False. This seems like a good option to set to > True, though. I would set it to True. patch attached to handle both changes above, RHOS will have to carry these changes since they wont work with EPEL > > > rhos : rpc_backend = nova.openstack.common.rpc.impl_qpid > > ps : rpc_backend=nova.rpc.impl_qpid > > Both will work. The RHOS version is more correct. The ps version is > supported for backwards compatibility. I would change it to match RHOS. changed to match RHOS > > > glance-api : openstack-glance-2012.2.3-1.el6ost > > # not set in RHOS, but maybe worth mentioning ? > > ps : workers = 2 > > > > > > there are many others that packstack sets but they either match whats in the > > dist.conf files or set values needed by the deployment (e.g. sql > > credentials), which of these should be changed in packstack ?
*** Bug 904712 has been marked as a duplicate of this bug. ***
After running packstack you can check the following in nova.conf to verify dhcpbridge_flagfile : should not be present ad its being set in nova-dist.conf force_dhcp_release : should not be present ad its being set in nova-dist.conf rpc_backend : nova.openstack.common.rpc.impl_qpid (not nova.rpc.impl_qpid)
Correction to comment 11 force_dhcp_release : this should be set to true so it doesn't conflict with whats in nova-dist.conf
(In reply to comment #11) > After running packstack you can check the following in nova.conf to verify > > dhcpbridge_flagfile : should not be present ad its being set in > nova-dist.conf Tested OK. # grep dhcpbridge_flagfile nova.conf #dhcpbridge_flagfile=/etc/nova/nova.conf > force_dhcp_release : should not be present ad its being set in > nova-dist.conf Ignored due to Comment #12 Correction > rpc_backend : nova.openstack.common.rpc.impl_qpid (not > nova.rpc.impl_qpid) Tested OK. # grep rpc_backend nova.conf #rpc_backend=nova.openstack.common.rpc.impl_qpid rpc_backend=nova.openstack.common.rpc.impl_qpid --- (In reply to comment #12) > Correction to comment 11 > > force_dhcp_release : this should be set to true so it doesn't conflict with > whats in nova-dist.conf Tested OK. # grep force_dhcp_release nova.conf #force_dhcp_release=True force_dhcp_release=true Kashyap, IMHO the bug can be marked as Verified.
Supplementary to Comment #13 Verified NVR: openstack-packstack-2012.2.3-0.7.dev475.el6ost.noarch
Verified with openstack-packstack-2012.2.3-0.1.dev454.el6ost. /etc/nova/nova.conf contains: [DEFAULT] #dhcpbridge_flagfile=/etc/nova/nova.conf #force_dhcp_release=True force_dhcp_release=true #rpc_backend=nova.openstack.common.rpc.impl_qpid rpc_backend=nova.openstack.common.rpc.impl_qpid /usr/share/nova/nova-dist.conf contains: [DEFAULT] dhcpbridge_flagfile = /usr/share/nova/nova-dist.conf dhcpbridge_flagfile = /etc/nova/nova.conf force_dhcp_release = True rpc_backend = nova.openstack.common.rpc.impl_qpid So no conflicting options present: - dhcpbridge_flagfile is not set by packstack - force_dhcp_release is set by packstack but to 'true' (not original 'false') - rpc_backend set by packstack also matches the default one for RHOS
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2013-0671.html