Bug 903624 - Review Request: perl-Module-Pluggable - Automatically give your module the ability to have plugins
Summary: Review Request: perl-Module-Pluggable - Automatically give your module the ab...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-24 12:32 UTC by Petr Pisar
Modified: 2013-01-29 18:18 UTC (History)
2 users (show)

Fixed In Version: perl-Module-Pluggable-4.6-1.fc19
Clone Of:
Environment:
Last Closed: 2013-01-29 18:18:03 UTC
Type: ---
Embargoed:
psabata: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2013-01-24 12:32:13 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-Module-Pluggable/perl-Module-Pluggable.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Module-Pluggable/perl-Module-Pluggable-4.6-1.fc19.src.rpm
Description:
This package provides a simple but, hopefully, extensible way of having
'plugins' for your module. Essentially all it does is export a method into
your name space that looks through a search path for .pm files and turn those
into class names. Optionally it instantiates those classes for you.

Fedora Account System Username: ppisar

-----
This review is to reborn died package (bug #189039, bug #561866). It's intended for rawhide only and it will replace perl's sub-package. This is needed because CPAN version is newer than perl's one, and because this package will have been removed by upstream after releasing perl 5.19.

Comment 1 Petr Šabata 2013-01-24 14:49:18 UTC
Taking the review...

Comment 2 Petr Šabata 2013-01-24 15:50:03 UTC
The explicit runtime dependency of File::Basename seems redundant.  My rpmbuild picks it up...

No issues here.  Approving.

Comment 3 Petr Pisar 2013-01-24 17:19:51 UTC
Package Change Request
======================
Package Name: perl-Module-Pluggable
Short Description: Automatically give your module the ability to have plugins
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Please revitalize master branch for once deprecated package as specified above and unblock the package in koji for rawhide.

Comment 4 Gwyn Ciesla 2013-01-24 18:14:06 UTC
No branches requested.

Comment 5 Petr Pisar 2013-01-25 07:38:30 UTC
What's identifier for master/rawhide/now-f19 for SCM request Branches request?

The package has been deprecated and I need to reassign it to people specified in Owners with InitalCC. This operation can be done only by rel-engs.

Comment 6 Petr Pisar 2013-01-25 07:41:09 UTC
Official documentation <https://fedoraproject.org/wiki/Package_SCM_admin_requests> is silent on this topic and various Fedora tools use various identifiers.

Comment 7 Petr Pisar 2013-01-25 10:08:31 UTC
Package Change Request
======================
Package Name: perl-Module-Pluggable
Short Description: Automatically give your module the ability to have plugins
Owners: ppisar jplesnik psabata
Branches: devel
InitialCC: perl-sig

Please revitalize master branch for once deprecated package as specified above and unblock the package in koji for rawhide.

Comment 8 Gwyn Ciesla 2013-01-25 13:27:55 UTC
I've unretired the package, you'll need to file a trac with rel-eng for
unblocking.  You can take ownership in pkgdb.  The reason the SCM doc is
silent is that the devel branch is automatic.

Comment 9 Petr Pisar 2013-01-25 13:49:24 UTC
Waiting on unblocking <https://fedorahosted.org/rel-eng/ticket/5458>.

Comment 10 Petr Pisar 2013-01-29 18:18:03 UTC
Thank you for the review and the unretirement of this package.


Note You need to log in before you can comment on or make changes to this bug.