Bug 903757 - Fedora-specific FindPostgreSQL.cmake patch does not set PostgreSQL_LIBRARY
Summary: Fedora-specific FindPostgreSQL.cmake patch does not set PostgreSQL_LIBRARY
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: cmake
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL: http://public.kitware.com/Bug/view.ph...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-24 19:10 UTC by Ben Boeckel
Modified: 2013-02-03 13:42 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-02-03 13:42:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ben Boeckel 2013-01-24 19:10:11 UTC
Description of problem:
The patch to FindPostgreSQL.cmake (from Bug #828467 AFAICT) does not set the PostgreSQL_LIBRARY variable. Instead, it sets the PostgreSQL_LIBRARY_FOUND variable, which is wrong (and incompatible).

Version-Release number of selected component (if applicable):
cmake-2.8.10.2-1.fc18.x86_64

Comment 1 Orion Poplawski 2013-01-25 04:31:17 UTC
Actually, the module says that it will define PostgreSQL_LIBRARIES, PostgreSQL_LIBRARY vs PostgreSQL_LIBRARY_FOUND being something of an implementation detail.  That said, it seems reasonable to keep using PostgreSQL_LIBRARY.

Comment 2 Fedora Update System 2013-01-25 20:05:26 UTC
cmake-2.8.10.2-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/cmake-2.8.10.2-3.fc18

Comment 3 Fedora Update System 2013-01-26 16:01:06 UTC
Package cmake-2.8.10.2-3.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing cmake-2.8.10.2-3.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-1541/cmake-2.8.10.2-3.fc18
then log in and leave karma (feedback).

Comment 4 Ben Boeckel 2013-01-30 22:55:22 UTC
I agree that the docs say it's an internal thing, but it's likely to have been used in confusion elsewhere (as it was here). Thanks!

As a side note, the "fail_if" and "run_pg_config" macros should be functions (so that CMake's stack trace is useful) and namespaced with find_pgsql_ (or similar) prefixes (so that they don't overwrite something).

Comment 5 Orion Poplawski 2013-01-30 22:59:38 UTC
Please make suggestions like this in the upstream bug report.  Thanks.

Comment 6 Fedora Update System 2013-02-03 13:42:34 UTC
cmake-2.8.10.2-3.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.