Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
+++ This bug was initially created as a clone of Bug #892274 +++
Description of problem:
scrub-freespace didn't fill any free space, scrub-device, scrub-file work correctly, see below,
><fs> scrub-freespace /scrub
libguestfs: trace: scrub_freespace "/scrub"
libguestfs: send_to_daemon: 56 bytes: 00 00 00 34 | 20 00 f5 f5 | 00 00 00 04 | 00 00 00 74 | 00 00 00 0
0 | ...
guestfsd: main_loop: new request, len 0x34
scrub -X /sysroot/scrub
scrub: created directory /sysroot/scrub
scrub: unlinked /sysroot/scrub/scrub.000
scrub: removed /sysroot/scrub
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
gueslibguestfs: recv_from_daemon: 40 bytes: 20 00 f5 f5 | 00 00 00 04 | 00 00 00 74 | 00 00 00 01 | 00 1
2 34 15 | ...
libguestfs: trace: scrub_freespace = 0
><fs> df
libguestfs: trace: df
libguestfs: send_to_daemon: 44 bytes: 00 00 00 28 | 20 00 f5 f5 | 00 00 00 04 | 00 00 00 7d | 00 00 00 0
0 | ...
tfsd: main_loop: proc 116 (scrub_freespace) took 1.59 seconds
guestfsd: main_loop: new request, len 0x28
df
libguestfs: recv_from_daemon: 208 bytes: 20 00 f5 f5 | 00 00 00 04 | 00 00 00 7d | 00 00 00 01 | 00 12 3
4 16 | ...
libguestfs: trace: df = "Filesystem 1K-blocks Used Available Use% Mounted on\n/dev 243
680 0 243680 0% /dev\n/dev/sda1 99035 1551 92371 2% /sysroot\n"
Filesystem 1K-blocks Used Available Use% Mounted on
/dev 243680 0 243680 0% /dev
/dev/sda1 99035 1551 92371 2% /sysroot
Version-Release number of selected component (if applicable):
libguestfs-1.20.1-4.el7.x86_64
How reproducible:
always
Steps to Reproduce:
1,guestfish -x -v -N fs mount /dev/sda1 / : scrub-freespace /scrub : df
Actual results:
Expected results:
Additional info:
--- Additional comment from Richard W.M. Jones on 2013-01-21 05:51:14 EST ---
moli: What exactly are you expecting here?
--- Additional comment from Mohua Li on 2013-01-22 01:14:58 EST ---
(In reply to comment #1)
> moli: What exactly are you expecting here?
ok, i admit, i'm a little confuse,according to the help
" This command creates the directory "dir" and then fills it with files
until the filesystem is full, and scrubs the files as for "scrub_file",
and deletes them. The intention is to scrub any free space on the
partition containing "dir".
"
in rhel6, it will fill the free space with scrub.*** file, and the filesystem is 100% full, but in rhel7, no scrub.*** file, and the filesystem have nothing changed, but in the help got "delete them" keyword, but from what scrub did, i think the behvaiour in rhel7 is a bug,
><fs> scrub-freespace /scrub
libguestfs: trace: scrub_freespace "/scrub"
libguestfs: send_to_daemon: 56 bytes: 00 00 00 34 | 20 00 f5 f5 | 00 00 00 04 | 00 00 00 74 | 00 00 00 00 | ...
guestfsd: main_loop: proc 1 (mount) took 0.05 seconds
guestfsd: main_loop: new request, len 0x34
scrub -X /sysroot/scrub
libguestfs: recv_from_daemon: 40 bytes: 20 00 f5 f5 | 00 00 00 04 | 00 00 00 74 | 00 00 00 01 | 00 12 34 03 | ...
libguestfs: trace: scrub_freespace = 0
><fs> ls /scrub
libguestfs: trace: ls "/scrub"
libguestfs: send_to_daemon: 56 bytes: 00 00 00 34 | 20 00 f5 f5 | 00 00 00 04 | 00 00 00 06 | 00 00 00 00 | ...
guestfsd: main_loop: proc 116 (scrub_freespace) took 6.68 seconds
guestfsd: main_loop: new request, len 0x34
guestfsd: main_loop: proc 6 (ls) took 0.00 seconds
libguestfs: recv_from_daemon: 60 bytes: 20 00 f5 f5 | 00 00 00 04 | 00 00 00 06 | 00 00 00 01 | 00 12 34 04 | ...
libguestfs: trace: ls = ["scrub.000"]
scrub.000
><fs> df
libguestfs: trace: df
libguestfs: send_to_daemon: 44 bytes: 00 00 00 28 | 20 00 f5 f5 | 00 00 00 04 | 00 00 00 7d | 00 00 00 00 | ...
guestfsd: main_loop: new request, len 0x28
df
[ 40.662316] df used greatest stack depth: 3056 bytes left
guestfsd: main_loop: proc 125 (df) took 0.00 seconds
libguestfs: recv_from_daemon: 240 bytes: 20 00 f5 f5 | 00 00 00 04 | 00 00 00 7d | 00 00 00 01 | 00 12 34 05 | ...
libguestfs: trace: df = "Filesystem 1K-blocks Used Available Use% Mounted on\n/dev 232704 132 232572 1% /dev\n/dev/vda1 99035 99034 0 100% /sysroot\n"
Filesystem 1K-blocks Used Available Use% Mounted on
/dev 232704 132 232572 1% /dev
/dev/vda1 99035 99034 0 100% /sysroot
--- Additional comment from Richard W.M. Jones on 2013-01-22 08:38:10 EST ---
My test for this is:
$ guestfish -v -N fs -m /dev/sda1 scrub-freespace /scrub
For me this produces the output:
[...]
scrub -X /sysroot/scrub
scrub: created directory /sysroot/scrub
scrub: unlinked /sysroot/scrub/scrub.000
scrub: removed /sysroot/scrub
[...]
Also the disk image file is fully allocated after the scrub,
which indicates that data (scrubbing patterns) were written
all the way through to the block device:
$ du -sh test1.img
99M test1.img
I tried this out on Fedora 18 and RHEL 7 with the same results.
moli: Do you agree that my test indicates that this is not a bug?
I do not believe the output of 'df' inside the guest is relevant,
since scrub removes the scrubbed file afterwards, so disk free space
should be substantially the same before and after the test.
--- Additional comment from Mohua Li on 2013-01-22 21:54:25 EST ---
(In reply to comment #3)
> My test for this is:
>
> $ guestfish -v -N fs -m /dev/sda1 scrub-freespace /scrub
>
> For me this produces the output:
>
> [...]
> scrub -X /sysroot/scrub
> scrub: created directory /sysroot/scrub
> scrub: unlinked /sysroot/scrub/scrub.000
> scrub: removed /sysroot/scrub
> [...]
>
> Also the disk image file is fully allocated after the scrub,
> which indicates that data (scrubbing patterns) were written
> all the way through to the block device:
>
> $ du -sh test1.img
> 99M test1.img
>
> I tried this out on Fedora 18 and RHEL 7 with the same results.
>
> moli: Do you agree that my test indicates that this is not a bug?
>
> I do not believe the output of 'df' inside the guest is relevant,
> since scrub removes the scrubbed file afterwards, so disk free space
> should be substantially the same before and after the test.
Hi Rich,
That's what i confuse, if it's not a bug in rhel7, then there is a bug in rhel6, as it didn't remove the scrub file, as what imply in the help it do
need to remove the scrub file, any thought?
--- Additional comment from Richard W.M. Jones on 2013-01-23 05:25:02 EST ---
Yes I agree, this does seem to be a bug on RHEL 6.
$ guestfish -v -N fs -m /dev/sda1 scrub-freespace /scrub : df-h
[...]
scrub -X /sysroot/scrub
[...]
Filesystem Size Used Avail Use% Mounted on
/dev 237M 132K 237M 1% /dev
/dev/vda1 97M 97M 0 100% /sysroot
On RHEL 6.3 the scrub directory is not removed and so it
ends up filling the disk to 100%.
This is a bug in RHEL 6 scrub:
http://code.google.com/p/diskscrub/issues/detail?id=9
which was fixed upstream:
http://code.google.com/p/diskscrub/source/detail?r=98d36b4836d741c7cb7664cbd21b3ae1c138881e
This fix needs to be backported to RHEL 6 scrub (NB:
it's a bug in scrub, not in libguestfs).
Comment 2Richard W.M. Jones
2013-01-25 08:43:27 UTC
Not a chance we can fix this for RHEL 6.4! Moving to 6.5 ..
Comment 6Richard W.M. Jones
2013-06-28 11:09:04 UTC
Comment 7RHEL Program Management
2013-10-14 00:02:20 UTC
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unable to address this
request at this time.
Red Hat invites you to ask your support representative to
propose this request, if appropriate, in the next release of
Red Hat Enterprise Linux.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
http://rhn.redhat.com/errata/RHBA-2014-1493.html