Bug 903975
| Summary: | [RHEL7] suspend test fail due to not checking log message in RHEL7 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Hardware Certification Program | Reporter: | Caspar Zhang <czhang> | ||||
| Component: | Test Suite (tests) | Assignee: | Caspar Zhang <czhang> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Red Hat Kernel QE team <kernel-qe> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 1.6.4 | CC: | bbrock, czhang, gnichols, qcai, rlandry | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | v7-1.7.0-R2 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-03-28 06:21:11 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 904887 | ||||||
| Attachments: |
|
||||||
One more thing: if systemd is running, when pressing Function keys to suspend/hibernate, the following message will display: Jan 25 15:58:52 localhost v7/runtests[2798]: v7/runtests[2798]: suspend-FunctionKey-mem: begin Jan 25 15:58:57 localhost systemd-logind[563]: Suspend key pressed. Jan 25 15:58:57 localhost systemd-logind[563]: Suspending... Jan 25 15:58:57 localhost systemd[1]: SELinux Got Sender :1.1 Jan 25 15:58:57 localhost systemd[1]: Starting Sleep. Jan 25 15:58:57 localhost systemd[1]: Reached target Sleep. Jan 25 15:58:57 localhost systemd[1]: Starting Suspend... Jan 25 15:58:57 localhost systemd-sleep[3454]: Suspending system... systemd should be enabled by default in RHEL7, should we consider to use this message to check funtionkey suspending/resuming: Suspend key pressed. ? Created attachment 687305 [details]
suspend: checking correct log message
Is attachment 687305 [details] a complete fix, or do some issues remain?
We should remove RHEL version checking where ever we can, as 1.7 code will only be used on RHEL7 and beyond. It looks as though your patch does that.
committed attachment 687305 [details] to R2
|
Description of problem: if source == Constants.OSCommand or RedHatRelease().getVersion() == 6: suspendMessage = "Disabling non-boot CPUs" if not suspendMessage in log: print "Error: could not verify suspend" return False # otherwise print "Verified suspend" resumeMessage = "Resuming computer" if source == Constants.OSCommand or RedHatRelease().getVersion() == 6: resumeMessage = "Enabling non-boot CPUs" if not resumeMessage in log: print "Error: could not verify resume" return False There are two fixes: 1) change RedHatRelease().getVersion() == 6 to >=6; 2) remove version check, i.e. RedHatRelease().getVersion() == 6 (since we're separting hwcert-client into different RHEL releases) which one is better? Version-Release number of selected component (if applicable): 1.6.4 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: