Bug 904654 - Pungi does not verify downloaded packages
Summary: Pungi does not verify downloaded packages
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: pungi
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-26 20:53 UTC by Marek Marczykowski
Modified: 2014-02-05 18:32 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-05 18:32:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed patch - enable gpgcheck option for repos with given gpgkey location (2.63 KB, patch)
2013-01-26 21:13 UTC, Marek Marczykowski
no flags Details | Diff

Description Marek Marczykowski 2013-01-26 20:53:59 UTC
Description of problem:
Pungi setup yum object with gpg signatures checking disabled. Then this object is passed to lorax, which download and install some packages (for installer image). This means installer system contains unverified files, which could be downloaded from hijacked or malicious mirror.

Version-Release number of selected component (if applicable):
pungi-2.13-1.fc18.noarch
pykickstart-1.99.22-1.fc18.noarch

How reproducible:
100%

Steps to Reproduce:
1. Add repository with unsigned packages to kickstart file (I've tested using "anaconda" empty package with Epoch:100 to be sure it will be chosen)
2. Run pungi
3. Observe its fail because of broken package
  
Actual results:
Unsigned malicious package downloaded and installed.

Expected results:
Package rejected because of lack/wrong signature.

Additional info:

Comment 1 Marek Marczykowski 2013-01-26 21:13:50 UTC
Created attachment 688168 [details]
Proposed patch - enable gpgcheck option for repos with given gpgkey location

This depends on another patch - for pykickstart - to support gpgkey option for "repo" command. See bug 904657

Comment 2 Fedora End Of Life 2013-12-21 10:52:10 UTC
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2014-02-05 18:32:40 UTC
Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.