Red Hat Bugzilla – Bug 905013
NSPR pthread_key_t leak and memory corruption
Last modified: 2014-06-11 11:28:44 EDT
Created attachment 784716 [details]
Patch made from what I picked up from the upstream bug
I refreshed my memory by rereading... the upstream bug.
The good news is:
Upstream has applied a basic fix, and that fix has been contained
in NSPR since version 4.9.3
I believe that RHEL 6.4 has already been updated to NSPR 4.9.5, and therefore the basic fix should already be available.
I'd like to ask that you please repeat the testing of the server issue, to check that it has been sufficiently fixed.
However, more details: Bob had identified another scenario where we might still leak. There has been disagreements and stalling upstream which would be the correct approach to fix the remaining issue.
The patch that Elio has attached in comment 3 was my proposal to fix the remaining issue at upstream. That patch already god some reviewing from Bob, but not yet a final review.
In other words, here's my recommandation:
(A) Please test if existing NSPR 4.9.5 is sufficient to fix the issue.
If it is, we should mark this bug a resolved and wait for upstream
to complete and pick up remaining fixes later.
(B) If your testing with NSPR 4.9.5 shows we still have this bug,
we will provide a scratch RPM with the suggested remaining fix.
Created attachment 786613 [details]
The original bug reproducer attached to Bug 633519
Created attachment 786615 [details]
Log file produced by executing the test
Produce by follwing the instructions at the top of the source file:
$ make tsdleak CFLAGS="-Wall -O2 -I/usr/include/nspr4" LDFLAGS="-ldl -lpthread"
cc -Wall -O2 -I/usr/include/nspr4 -ldl -lpthread tsdleak.c -o tsdleak
$ MALLOC_CHECK_=2 ./tsdleak 1> tsdleak.log 2>&1
$ grep fail tsdleak.log
Neither of printf's with 'dlopen failed:' or 'dlsym failed: were hit.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.