RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 905585 - xfsrestore does not preserve file capabilities
Summary: xfsrestore does not preserve file capabilities
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: xfsdump
Version: 6.4
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Eric Sandeen
QA Contact: Eryu Guan
URL:
Whiteboard:
Depends On: 905584
Blocks: 1013345
TreeView+ depends on / blocked
 
Reported: 2013-01-29 17:35 UTC by Eric Sandeen
Modified: 2014-10-14 07:50 UTC (History)
3 users (show)

Fixed In Version: xfsdump-3.0.4-4.el6
Doc Type: Bug Fix
Doc Text:
Clone Of: 905584
: 1013345 (view as bug list)
Environment:
Last Closed: 2014-10-14 07:50:00 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:1565 0 normal SHIPPED_LIVE xfsdump bug fix update 2014-10-14 01:27:43 UTC

Description Eric Sandeen 2013-01-29 17:35:42 UTC 
+++ This bug was initially created as a clone of Bug #905584 +++

Description of problem:

xfsdump & xfsrestore fails to preserve unix capabilities.

Version-Release number of selected component (if applicable):

Current upstream

How reproducible:

Every time


Additional info:

While xfsdump/restore does save & re-write file capabilities, it does a chown after capabilities are restored, which causes the kernel to clear all capabilities again.

Presumably simply changing the order of chown & capability restore will do the trick.
Comment 2 RHEL Program Management 2013-02-02 06:48:21 UTC 
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.
Comment 3 Eric Sandeen 2013-05-13 17:02:46 UTC 
This is not yet fixed upstream.
Comment 4 Eric Sandeen 2014-02-17 17:03:26 UTC 
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/cmds/xfsdump.git;a=commitdiff;h=a88c49071dde2539cce6d502effc27501416983a

From a88c49071dde2539cce6d502effc27501416983a Mon Sep 17 00:00:00 2001
From: Dave Chinner <dchinner>
Date: Thu, 6 Feb 2014 16:48:39 +1100
Subject: [PATCH] restore: don't trash file capabilities

xfsrestore fails to restore file capabilities correctly because it
sets the owner on the file after it has restored the capability
attributes. This results in the kernel stripping the capabilities
when changing the owner of the file and hence the restored file is
not complete.

Fix this by changing the owner of the file when it is created rather
than after it has been fully restored. This ensures we don't kill
the caps as they are restored after the owner it appropriately set.
This fixes the xfs/296 failure.

Signed-off-by: Dave Chinner <dchinner>
Reviewed-by: Brian Foster <bfoster>
Signed-off-by: Dave Chinner <david>
---
Comment 7 Eryu Guan 2014-07-11 07:22:30 UTC 
Verified with kernel-2.6.32-488.el6 and xfsdump-3.0.4-4.el6, xfs/296 passed.

Set to VERIFIED.
Comment 9 errata-xmlrpc 2014-10-14 07:50:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1565.html
Note You need to log in before you can comment on or make changes to this bug.