Red Hat Bugzilla – Bug 905656
[broker-util] oo-accept-broker doesn't summarize errors and set return code
Last modified: 2017-03-08 12:34 EST
Description of problem: oo-accept-broker is supposed to give a summary of the number of errors and set a return code equal to the number of errors. It used to. Somewhere along the way it stopped doing that. Just prints the errors. Version-Release number of selected component (if applicable): openshift-origin-broker-util-1.0.14-1.el6op.noarch Steps to Reproduce: 1. Run oo-accept-broker on a system with something wrong with it (e.g. stop activemq) Actual results: # oo-accept-broker FAIL: Did not get expected HTTP 200 response from https://localhost/broker/rest/cartridges # echo $? 0 Expected results: # oo-accept-broker FAIL: Did not get expected HTTP 200 response from https://localhost/broker/rest/cartridges 1 ERRORS # echo $? 1 Additional info: Probably something I did.
Fixed with openshift-origin-broker-util-1.0.15-1 and in origin as well - https://github.com/openshift/origin-server/pull/1308
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/ab4ccb050969fdf1d9c21334a04ffe8336d93be3 <oo-accept-broker> fix bug 905656 - exit message and status
Wait new puddle to test; For the puddle: http://buildvm-devops.usersys.redhat.com/puddle/build/OpenShiftEnterprise/1.1.z/2013-02-04.1/ [root@broker ~]# rpm -qa | grep openshift-origin-broker-util openshift-origin-broker-util-1.0.12-1.el6op.noarch
Version: http://buildvm-devops.usersys.redhat.com/puddle/build/OpenShiftEnterprise/1.1.z/2013-02-06.2/ openshift-origin-broker-util-1.0.15-1.el6op.noarch Verify: [root@broker ~]# service mongod status mongod is stopped [root@broker ~]# oo-accept-broker FAIL: LOCAL: mongod service not running exception: connect failed FAIL: error logging into mongo db: localhost:27017/openshift_broker --username openshift, exit code: 1 FAIL: Did not get expected HTTP 200 response from https://localhost/broker/rest/application_templates 3 ERRORS [root@broker ~]# echo $? 3 [root@broker ~]# service mongod start Starting mongod: [ OK ] [root@broker ~]# oo-accept-broker PASS [root@broker ~]# echo $? 0
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2013-0582.html