Bug 906442 - Review Request: gimp-normalmap - Plugin that enabled the creation of normal maps
Summary: Review Request: gimp-normalmap - Plugin that enabled the creation of normal maps
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Wouters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 821423 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-31 16:17 UTC by Patrick Uiterwijk
Modified: 2013-04-11 10:08 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-04-11 10:04:31 UTC
Type: ---
Embargoed:
pwouters: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Patrick Uiterwijk 2013-01-31 16:17:22 UTC
Spec URL: http://puiterwijk.fedorapeople.org/packages/gimp-normalmap/gimp-normalmap-1.spec
SRPM URL: http://kojipkgs.fedoraproject.org//work/tasks/7723/4917723/gimp-normalmap-1.2.3-1.fc18.src.rpm
Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=4917722
Fedora Account System Username: puiterwijk

Description:
A plugin for Gimp that enables the creation of normal maps
that you can use to achieve a number of lighting effects in pixel-based artwork.

Comment 1 Paul Wouters 2013-01-31 21:38:20 UTC
Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
[!]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
     Note: gimp-normalmap-1.spec should be gimp-normalmap.spec
See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later) (with incorrect FSF address)". 1 files have unknown
     license. Detailed output of licensecheck in /home/paul/906442-gimp-
     normalmap-1/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[!]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
     Note: gimp-normalmap-1.spec should be gimp-normalmap.spec
[ ]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[ ]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 30720 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[ ]: If the source package does not include license text(s) as a separate file
     from upstream, the pa[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: gimp-normalmap-1.2.3-1.fc18.x86_64.rpm
          gimp-normalmap-1.2.3-1.fc18.src.rpm
          gimp-normalmap-debuginfo-1.2.3-1.fc18.x86_64.rpm
gimp-normalmap.x86_64: E: incorrect-fsf-address /usr/share/doc/gimp-normalmap-1.2.3/COPYING
gimp-normalmap-debuginfo.x86_64: E: debuginfo-without-sources
3 packages and 0 specfiles checked; 2 errors, 0 warnings.


Rpmlint (installed packages)
----------------------------
# rpmlint gimp-normalmap-debuginfo gimp-normalmap
gimp-normalmap-debuginfo.x86_64: E: debuginfo-without-sources
gimp-normalmap.x86_64: E: incorrect-fsf-address /usr/share/doc/gimp-normalmap-1.2.3/COPYING
2 packages and 0 specfiles checked; 2 errors, 0 warnings.
# echo 'rpmlint-done:'

Requires
--------
gimp-normalmap-1.2.3-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered):

    libGL.so.1()(64bit)
    libGLEW.so.1.7()(64bit)
    libGLU.so.1()(64bit)
    libICE.so.6()(64bit)
    libSM.so.6()(64bit)
    libX11.so.6()(64bit)
    libXmu.so.6()(64bit)
    libXt.so.6()(64bit)
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgdkglext-x11-1.0.so.0()(64bit)
    libgimp-2.0.so.0()(64bit)
    libgimpbase-2.0.so.0()(64bit)
    libgimpcolor-2.0.so.0()(64bit)
    libgimpconfig-2.0.so.0()(64bit)
    libgimpmath-2.0.so.0()(64bit)
    libgimpmodule-2.0.so.0()(64bit)
    libgimpui-2.0.so.0()(64bit)
    libgimpwidgets-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libgtkglext-x11-1.0.so.0()(64bit)
    libm.so.6()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpangox-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    librt.so.1()(64bit)
    rtld(GNU_HASH)

gimp-normalmap-debuginfo-1.2.3-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered):




Provides
--------
gimp-normalmap-1.2.3-1.fc18.x86_64.rpm:

    gimp-normalmap = 1.2.3-1.fc18
    gimp-normalmap(x86-64) = 1.2.3-1.fc18

gimp-normalmap-debuginfo-1.2.3-1.fc18.x86_64.rpm:

    gimp-normalmap-debuginfo = 1.2.3-1.fc18
    gimp-normalmap-debuginfo(x86-64) = 1.2.3-1.fc18



MD5-sum check
-------------
http://gimp-normalmap.googlecode.com/files/gimp-normalmap-1.2.3.tar.bz2 :
  CHECKSUM(SHA256) this package     : 1787716459d836cf61f0ea2aa441df1723339edd303d6f1c0ae2c0a483fbd593
  CHECKSUM(SHA256) upstream package : 1787716459d836cf61f0ea2aa441df1723339edd303d6f1c0ae2c0a483fbd593


Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-18-x86_64
Command line :/usr/bin/fedora-review -b 906442



PASSED, and packager commited to fixing:

- spec file name
- add Requires: gimp

Comment 2 Patrick Uiterwijk 2013-01-31 23:44:47 UTC
New Package SCM Request
=======================
Package Name: gimp-normalmap
Short Description: Plugin that enables the creation of normal maps
Owners: puiterwijk
Branches: f17 f18
InitialCC:

Comment 3 Gwyn Ciesla 2013-02-01 13:46:39 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2013-02-02 06:30:34 UTC
gimp-normalmap-1.2.3-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gimp-normalmap-1.2.3-2.fc18

Comment 5 Fedora Update System 2013-02-02 06:30:46 UTC
gimp-normalmap-1.2.3-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gimp-normalmap-1.2.3-2.fc17

Comment 6 Fedora Update System 2013-02-03 13:25:23 UTC
gimp-normalmap-1.2.3-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 7 Ville Skyttä 2013-02-05 21:31:52 UTC
(In reply to comment #1)
> [x]: %build honors applicable compiler flags or justifies otherwise.

Careful there, reviewer: it doesn't use $RPM_OPT_FLAGS or $RPM_LD_FLAGS, and provides no justification for those omissions, see bug 908099.

Comment 8 Ville Skyttä 2013-02-05 21:34:13 UTC
*** Bug 821423 has been marked as a duplicate of this bug. ***

Comment 9 Fedora Update System 2013-02-07 07:06:46 UTC
gimp-normalmap-1.2.3-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gimp-normalmap-1.2.3-3.fc17

Comment 10 Fedora Update System 2013-02-07 07:07:05 UTC
gimp-normalmap-1.2.3-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gimp-normalmap-1.2.3-3.fc18

Comment 11 Fedora Update System 2013-03-23 09:13:19 UTC
gimp-normalmap-1.2.3-4.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gimp-normalmap-1.2.3-4.fc17

Comment 12 Fedora Update System 2013-03-23 09:13:39 UTC
gimp-normalmap-1.2.3-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gimp-normalmap-1.2.3-4.fc18

Comment 13 Fedora Update System 2013-04-11 10:04:32 UTC
gimp-normalmap-1.2.3-4.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2013-04-11 10:08:10 UTC
gimp-normalmap-1.2.3-4.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.