Bug 907703 - Use DESTDIR instead of PERL_INSTALL_ROOT
Summary: Use DESTDIR instead of PERL_INSTALL_ROOT
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: cpanspec
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Steven Pritchard
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-05 03:32 UTC by Mathieu Bridon
Modified: 2014-02-05 18:52 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-05 18:52:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Mathieu Bridon 2013-02-05 03:32:20 UTC
Description of problem:
In all my recent perl-related package submissions, the reviewer has suggested to me to use DESTDIR instead of PERL_INSTALL_ROOT.

For example:
 %install
-make pure_install PERL_INSTALL_ROOT=%{buildroot}
+make pure_install DESTDIR=%{buildroot}

Now, of course I'll try to pay more attention to it, or else reviewers will be tired of always repeating the same thing. :)

However, it would be very helpful if cpanspec could create specfiles which directly respect our experts' recommendations, so that we don't have to change it for every package.

This is with:
cpanspec-1.78-12.fc18.noarch

Comment 1 Steven Roberts 2013-02-05 04:49:40 UTC
I did some searching.  found this:
https://bugzilla.redhat.com/show_bug.cgi?id=562316#c2

so looks like that is why PERL_INSTALL_ROOT was the old default.

I'm working with the cpanspec upstream.  And actually this change looks to be in a set a user has submitted for the next version.

Comment 2 Ralf Corsepius 2013-02-05 06:35:20 UTC
(In reply to comment #0)
> Description of problem:
> In all my recent perl-related package submissions, the reviewer has
> suggested to me to use DESTDIR instead of PERL_INSTALL_ROOT.

Whether to use DESTDIR or PERL_INSTALL_ROOT is not of importance.
 
The only thing that matters is "things are working". In most cases, both DESTDIR or PERL_INSTALL_ROOT both are working correctly.

Comment 3 Fedora End Of Life 2013-12-21 11:09:24 UTC
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Fedora End Of Life 2014-02-05 18:52:45 UTC
Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.