Note that this review is for a renamed package febootstrap
(http://pkgs.fedoraproject.org/cgit/febootstrap.git/).

Unlike an ordinary package rename, I have *deliberately* not
added Obsoletes/Provides.  The reason is that the new package
doesn't precisely obsolete nor provide the old package, and
indeed it's quite possible to parallel-install both.  Client
programs will have to be changed over time to use the new
tools 'supermin' and 'supermin-helper' as replacements for
the old tools 'febootstrap' and 'febootstrap-supermin-helper'.

rpmlint says:

supermin.src: W: name-repeated-in-summary C supermin

 - this seems fine to me, not sure what rpmlint is complaining about

supermin.src:27: W: unversioned-explicit-provides bundled(gnulib)

 - bug in rpmlint, gnulib doesn't have versions and I don't think that
   'bundled' needs version numbers either

supermin.x86_64: E: incorrect-fsf-address /usr/share/doc/supermin-4.1.0/COPYING

 - I will fix this upstream, and the fix will appear in the next version

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[-]: Package contains no static executables.

  Package does build a static 'init'. This is required to build a bootable
  image.

[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[!]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package
     helper

  supermin-helper doesn't require supermin, but the reverse is true. The reverse
  dependency is versioned, but doesn't constrain architecture. It probably
  should.

[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated",
     "BSD (3 clause) GPL (v3 or later)", "GPL (v2 or later) (with incorrect
     FSF address)". 6 files have unknown license. Detailed output of
     licensecheck in /home/mbooth/tmp/review-supermin/licensecheck.txt

  The licence, GPLv2+ is fine, and accurate in this particular environment.
  However, the sources do contain a GPLv3+ file: openat.c from gnulib. This file
  isn't built on recent Fedora as it isn't required, so doesn't affect the
  license. For the avoidance of doubt, I suggest that this file should be
  deleted upstream, or at least in %prep.

[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[!]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.

  The package should Obsolete febootstrap, but as discussed, it doesn't Provide
  it. This will require an update to the libguestfs package.

[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 61440 bytes in 3 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: supermin-4.1.0-1.fc18.x86_64.rpm
          supermin-helper-4.1.0-1.fc18.x86_64.rpm
          supermin-debuginfo-4.1.0-1.fc18.x86_64.rpm
          supermin-4.1.0-1.fc18.src.rpm
supermin.x86_64: W: name-repeated-in-summary C supermin

  No problem.

supermin.x86_64: E: incorrect-fsf-address /usr/share/doc/supermin-4.1.0/COPYING

  Fixed upstream.

supermin-helper.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment
supermin-helper.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment

  Spelling of runtime is fine.

supermin-helper.x86_64: E: incorrect-fsf-address /usr/share/doc/supermin-helper-4.1.0/COPYING
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/ext2.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/kernel.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/ext2internal.h
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/utils.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/main.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/ext2initrd.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/cpio.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/ext2cpio.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/appliance.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/helper.h
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/checksum.c

  Fixed upstream.

supermin.src: W: name-repeated-in-summary C supermin

  No problem.

supermin.src:27: W: unversioned-explicit-provides bundled(gnulib)

  Version doesn't make sense in this case.




Rpmlint (installed packages)
----------------------------
# rpmlint supermin-debuginfo supermin-helper supermin
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/ext2.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/kernel.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/ext2internal.h
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/utils.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/main.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/ext2initrd.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/cpio.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/ext2cpio.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/appliance.c
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/helper.h
supermin-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/supermin-4.1.0/helper/checksum.c
supermin-helper.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment
supermin-helper.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
supermin-helper.x86_64: E: incorrect-fsf-address /usr/share/doc/supermin-helper-4.1.0/COPYING
supermin.x86_64: W: name-repeated-in-summary C supermin
supermin.x86_64: E: incorrect-fsf-address /usr/share/doc/supermin-4.1.0/COPYING
3 packages and 0 specfiles checked; 13 errors, 3 warnings.
# echo 'rpmlint-done:'

  See above.


Requires
--------
supermin-4.1.0-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered):

    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libm.so.6()(64bit)
    rtld(GNU_HASH)
    supermin-helper = 4.1.0-1.fc18
    yum >= 3.2
    yum-utils

supermin-helper-4.1.0-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered):

    /usr/sbin/mke2fs
    cpio
    e2fsprogs-libs >= 1.42
    libc.so.6()(64bit)
    libcom_err.so.2()(64bit)
    libext2fs.so.2()(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)
    util-linux-ng

supermin-debuginfo-4.1.0-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered):




Provides
--------
supermin-4.1.0-1.fc18.x86_64.rpm:

    bundled(gnulib)
    supermin = 4.1.0-1.fc18
    supermin(x86-64) = 4.1.0-1.fc18

supermin-helper-4.1.0-1.fc18.x86_64.rpm:

    supermin-helper = 4.1.0-1.fc18
    supermin-helper(x86-64) = 4.1.0-1.fc18

supermin-debuginfo-4.1.0-1.fc18.x86_64.rpm:

    supermin-debuginfo = 4.1.0-1.fc18
    supermin-debuginfo(x86-64) = 4.1.0-1.fc18



MD5-sum check
-------------
http://libguestfs.org/download/supermin/supermin-4.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : acab109868b364f9c8e84358b3e6008cd8b773ca9de00d621a1e665644fed617
  CHECKSUM(SHA256) upstream package : acab109868b364f9c8e84358b3e6008cd8b773ca9de00d621a1e665644fed617


Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-18-x86_64
Command line :/usr/bin/fedora-review -n supermin-4.1.0-1.fc18 -r

All the above issues have been addressed in the latest spec file:

http://git.annexia.org/?p=fedora-specs.git;a=blob;f=supermin.spec;h=414db1b8c6f8bbaf7d5efd976035e65afd3c9e65;hb=HEAD

ACK.

Thanks -- I will go with 4.1.1 which will include the FSF address
fix as well.

New Package SCM Request
=======================
Package Name: supermin
Short Description: Tool for creating supermin appliances
Owners: rjones
Branches: f18
InitialCC:

Git done (by process-git-requests).

supermin-4.1.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/supermin-4.1.1-1.fc18

supermin-4.1.1-1.fc18 has been pushed to the Fedora 18 testing repository.

supermin-4.1.1-1.fc18 has been pushed to the Fedora 18 stable repository.

Package Change Request
======================
Package Name: supermin
New Branches: f17
Owners:

Git done (by process-git-requests).

Thanks, built for F17 here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=5233368