Bug 908164 - Duplicate error message when normal users try to create more than 3 applications.
Summary: Duplicate error message when normal users try to create more than 3 applicati...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Website
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Wei Sun
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-06 03:35 UTC by Yujie Zhang
Modified: 2015-05-15 01:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-14 00:48:20 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
duplicate error message (51.23 KB, image/png)
2013-02-06 03:35 UTC, Yujie Zhang
no flags Details
fixed (35.17 KB, image/png)
2013-02-08 04:29 UTC, Wei Sun
no flags Details

Description Yujie Zhang 2013-02-06 03:35:31 UTC
Created attachment 693666 [details]
duplicate error message

Description of problem:

Tried to create the 4th application using freeshift, then the error message of reminding user is duplicate, details see in the attachment.

Version-Release number of selected component (if applicable):

INT(devenv_2778)

How reproducible:
Always

Steps to Reproduce:
1.Create 3 applications
2.Try to create the 4 application
3.
  
Actual results:

The error message is duplicate.Details see in attachment.

Expected results:

The error message should not be correct.

Additional info:

Comment 1 Yujie Zhang 2013-02-06 03:38:09 UTC
Expected results:

The error message should not be duplicate.

Sorry for the mistake.

Comment 2 Clayton Coleman 2013-02-06 15:30:25 UTC
If we're adding this error in the controller (I think we might be) then we need to only do so if there are no other errors.  Also, the "Base <user>" part looks funny, that might be because the full message coming from the broker doesn't start with capitals.  Rails ActiveModel::Errors.full_messages I think prefixes on the error attribute if the message isn't capitalized.  We should probably get the broker error message to change to not put email first (since it may not be capitalized).

Comment 3 Fotios Lindiakos 2013-02-06 19:07:50 UTC
Should be fixed in this PR:
https://github.com/openshift/origin-server/pull/1327

Comment 4 openshift-github-bot 2013-02-06 21:35:41 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/1d574fe48066d9e18bcdb33d748ec9e8c19775df
Merge pull request #1327 from fotioslindiakos/max_gears_errors

Bug 908164

Comment 5 Yujie Zhang 2013-02-07 05:45:25 UTC
Tested on devenv-stage_282, the duplicate error message has been corrected, I will verify this bug after it is ON_QA.

Comment 6 Wei Sun 2013-02-08 04:29:20 UTC
Created attachment 694931 [details]
fixed

Verified on stage(devenv-stage_283)
Tested on stage(devenv-stage_283),this bug is fixed.So mark it as VERIFIED.


Note You need to log in before you can comment on or make changes to this bug.