Spec URL: http://www.matthias-runge.de/fedora/python-django-discover-runner.spec SRPM URL: http://www.matthias-runge.de/fedora/python-django-discover-runner-0.3-1.fc18.src.rpm Description: An alternative Django TEST_RUNNER which uses the unittest2 test discovery from a base path specified in the settings, or any other module or package specified to the test management command -- including app tests. Fedora Account System Username: mrunge rpmlint SPECS/python-django-discover-runner.spec RPMS/noarch/python-django-discover-runner-0.3-1.fc18.noarch.rpm SRPMS/python-django-discover-runner-0.3-1.fc18.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Koji scratchbuild is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=4934166
Hi Matthias, please add the LICENSE [1] file, to proceed to the formal review [1] https://raw.github.com/jezdez/django-discover-runner/master/LICENSE
Eduardo, thank you for your remark. SPEC: http://www.matthias-runge.de/fedora/python-django-discover-runner.spec SRPM: http://www.matthias-runge.de/fedora/python-django-discover-runner-0.3-2.fc18.src.rpm [mrunge@turing SPECS]$ diff -u python-django-discover-runner.spec.1 python-django-discover-runner.spec --- python-django-discover-runner.spec.1 2013-02-08 12:29:06.986580175 +0100 +++ python-django-discover-runner.spec 2013-02-08 12:28:06.558772695 +0100 @@ -2,12 +2,17 @@ Name: python-%{pypi_name} Version: 0.3 -Release: 1%{?dist} +Release: 2%{?dist} Summary: A Django test runner based on unittest2's test discovery License: BSD URL: http://pypi.python.org/pypi/django-discover-runner/0.3 Source0: http://pypi.python.org/packages/source/d/%{pypi_name}/%{pypi_name}-%{version}.tar.gz + +# license file is not included +# https://github.com/jezdez/django-discover-runner/issues/6 +# wget -O python-django-discover-runner-license.txt https://raw.github.com/jezdez/django-discover-runner/master/LICENSE +Source1: python-django-discover-runner-license.txt BuildArch: noarch BuildRequires: python2-devel @@ -25,6 +30,8 @@ # Remove bundled egg-info rm -rf %{pypi_name}.egg-info +# copy license file to sources as well. +cp -a %{SOURCE1} . %build @@ -36,10 +43,13 @@ %files -%doc README.rst +%doc README.rst python-django-discover-runner-license.txt %{python_sitelib}/discover_runner %{python_sitelib}/django_discover_runner-%{version}-py?.?.egg-info %changelog +* Fri Feb 08 2013 Matthias Runge <mrunge> - 0.3-2 +- include license from upstream + * Wed Feb 06 2013 Matthias Runge <mrunge> - 0.3-1 - Initial package.
Hi Matthias: In the README.rst file, can be read: "Fixed setup.py to work on Python 3. This should make this app compatible to Python 3". as Django yet don't have python3 support in the system-wide version, I guess that the package build in python3 in this moment, makes no sense Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/makerpm/discover/908493-python-django-discover- runner/licensecheck.txt License file is not included, searched on upstream and added, BSD OK [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep Note: Cannot find sources under BUILD (using prebuilt sources?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (django-discover-runner-0.3.tar.gz) [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python-django-discover-runner-0.3-2.fc17.src.rpm python-django-discover-runner-0.3-2.fc17.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-django-discover-runner 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- python-django-discover-runner-0.3-2.fc17.noarch.rpm (rpmlib, GLIBC filtered): python(abi) = 2.7 python-unittest2 Provides -------- python-django-discover-runner-0.3-2.fc17.noarch.rpm: python-django-discover-runner = 0.3-2.fc17 MD5-sum check ------------- http://pypi.python.org/packages/source/d/django-discover-runner/django-discover-runner-0.3.tar.gz : CHECKSUM(SHA256) this package : 1241aab1af00df14a892af7ff680a270f4991254790e6af8880b2d957a37b1ae CHECKSUM(SHA256) upstream package : 1241aab1af00df14a892af7ff680a270f4991254790e6af8880b2d957a37b1ae ---------------- PACKAGE APPROVED ----------------
Thank you for your review. Django-1.5 supports Python3, so I'll introduce py3 in rawhide, when django-1.5 is released. New Package SCM Request ======================= Package Name: python-django-discover-runner Short Description: A Django test runner based on unittest2's test discovery Owners: mrunge Branches: f18
Git done (by process-git-requests).
python-django-discover-runner-0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-django-discover-runner-0.3-2.fc18
python-django-discover-runner-0.3-2.fc18 has been pushed to the Fedora 18 testing repository.
python-django-discover-runner-0.3-2.fc18 has been pushed to the Fedora 18 stable repository.
Package Change Request ====================== Package Name: python-django-discover-runner New Branches: el6 Owners: mrunge