Created attachment 694257 [details] patch to improve wording "Escape character is '^]'." is the message show by telnet as well as the one of virt-sandbox-service when connecting to the console of a service. But the keyboard shortcut doesn't do the same thing ( ie, on telnet, you have a prompt ). While telnet is likely to be unheard from newer admins, I think a better message could be : Type '^]' to detach from the console. or better : Type 'Ctrl + ]' to detach from the console. Here is a trivial patch for that
Thanks for the contribution. Would you mind resubmitting your patch upstream to libvir-list, so that it will get reviewed faster? (Not all the list readers browse bugzilla as frequently.)
Given the high volume of the list, that was something I tried to avoid, but yeah, I can do it.
(In reply to comment #2) > Given the high volume of the list, that was something I tried to avoid, but > yeah, I can do it. If you were worried about adding a high volume of new mail to your inbox, don't worry - you don't have to subscribe in order to post, and list policy is to reply-to-all so that non-subscribers stay in the loop on one-time contributions. Conversely, if you were worried that sending your patch to the list would add to list volume and make your patch get lost in the noise, don't worry - libvirt does not have near as high a volume as some other lists (hello lkml), and the fact that I'm taking the time to reply to this BZ generally means that I will also reply to your patch on-list. Besides, libvirt is just one of several projects that prefers that EVERY patch should go through the list. If you don't end up posting to the list, then the maintainer that scrapes your patch out of the BZ on your behalf would end up reposting it to the list as a courtesy to state why they applied the patch. But making the maintainers scrape patches out of BZs doesn't scale well (trust me - I much prefer a simple 'git am' on someone else's email than the steps I have to take when saving a file from BZ and then doing a git commit with proper authorship information, followed by sending an email about what I did), which is why we prefer to ask if you would do the list post.
Actually I would like to get rid of console altogether, since we now have the ability to executes commands within the container. In upstream you can execute virt-sandbox-service execute name -- /bin/sh And the shell will run in the container, ^d then becomes the way to end the shell.
Merged upstream in commit 4b218ec94f6a3c20f8e23e2cca9737c41091c358 Author: Dan Walsh <dwalsh> Date: Fri Feb 8 15:09:22 2013 -0500 better wording when connecting to a console patch from Michael Scherer. Included in 0.1.2 release